From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Daniel Machon <daniel.machon@microchip.com>
Cc: UNGLinuxDriver@microchip.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
jacob.e.keller@intel.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, robert.marko@sartura.hr
Subject: Re: [PATCH net-next v4 6/9] net: sparx5: verify RGMII speeds
Date: Fri, 13 Dec 2024 19:48:59 +0000 [thread overview]
Message-ID: <Z1yPq6OEziTNjWHK@shell.armlinux.org.uk> (raw)
In-Reply-To: <20241213-sparx5-lan969x-switch-driver-4-v4-6-d1a72c9c4714@microchip.com>
On Fri, Dec 13, 2024 at 02:41:05PM +0100, Daniel Machon wrote:
> When doing a port config, we verify the port speed against the PHY mode
> and supported speeds of that PHY mode. Add checks for the four RGMII phy
> modes: RGMII, RGMII_ID, RGMII_TXID and RGMII_RXID.
>
> Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
> Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
You do realise that phylink knows what speeds each interface supports
(see phylink_get_capabilities()) and restricts the media advertisement
to ensure that ethtool link modes that can't be supported by the MAC
capabilities and set of interfaces that would be used are not
advertised.
This should mean none of your verification ever triggers. If it does,
then I'd like to know about it.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-12-13 19:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 13:40 [PATCH net-next v4 0/9] net: lan969x: add RGMII support Daniel Machon
2024-12-13 13:41 ` [PATCH net-next v4 1/9] net: sparx5: do some preparation work Daniel Machon
2024-12-13 13:41 ` [PATCH net-next v4 2/9] net: sparx5: add function for RGMII port check Daniel Machon
2024-12-13 13:41 ` [PATCH net-next v4 3/9] net: sparx5: use is_port_rgmii() throughout Daniel Machon
2024-12-13 13:41 ` [PATCH net-next v4 4/9] net: sparx5: skip low-speed configuration when port is RGMII Daniel Machon
2024-12-13 13:41 ` [PATCH net-next v4 5/9] net: sparx5: only return PCS for modes that require it Daniel Machon
2024-12-13 19:45 ` Russell King (Oracle)
2024-12-13 13:41 ` [PATCH net-next v4 6/9] net: sparx5: verify RGMII speeds Daniel Machon
2024-12-13 19:48 ` Russell King (Oracle) [this message]
2024-12-16 12:10 ` Daniel Machon
2024-12-13 13:41 ` [PATCH net-next v4 7/9] net: lan969x: add RGMII registers Daniel Machon
2024-12-13 13:41 ` [PATCH net-next v4 8/9] net: lan969x: add RGMII implementation Daniel Machon
2024-12-13 13:41 ` [PATCH net-next v4 9/9] dt-bindings: net: sparx5: document RGMII delays Daniel Machon
2024-12-17 15:18 ` Rob Herring (Arm)
2024-12-13 19:54 ` [PATCH net-next v4 0/9] net: lan969x: add RGMII support Robert Marko
2024-12-18 14:33 ` Daniel Machon
2025-01-02 9:37 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1yPq6OEziTNjWHK@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=jacob.e.keller@intel.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).