From: William McVicker <willmcvicker@google.com>
To: "André Draszik" <andre.draszik@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Sam Protsenko <semen.protsenko@linaro.org>,
Roy Luo <royluo@google.com>,
kernel-team@android.com, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v4 4/7] phy: exynos5-usbdrd: fix EDS distribution tuning (gs101)
Date: Thu, 26 Dec 2024 09:31:00 -0800 [thread overview]
Message-ID: <Z22S1PPAQ4NKdrrY@google.com> (raw)
In-Reply-To: <20241206-gs101-phy-lanes-orientation-phy-v4-4-f5961268b149@linaro.org>
On 12/06/2024, André Draszik wrote:
> This code's intention is to configure lane0 and lane2 tunings, but for
> lane2 there is a typo and it ends up tuning something else.
>
> Fix the typo, as it doesn't appear to make sense to apply different
> tunings for lane0 vs lane2.
>
> The same typo appears to exist in the bootloader, hence we restore the
> original value in the typo'd registers as well. This can be removed
> once / if the bootloader is updated.
>
> Note that this is incorrect in the downstream driver as well - the
> values had been copied from there.
>
> Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
> Tested-by: Peter Griffin <peter.griffin@linaro.org>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
Verified on my Pixel 6 Pro.
Tested-by: Will McVicker <willmcvicker@google.com>
Thanks,
Will
<snip>
next prev parent reply other threads:[~2024-12-26 17:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 16:31 [PATCH v4 0/7] USB31DRD phy updates for Google Tensor gs101 (orientation & DWC3 rpm) André Draszik
2024-12-06 16:31 ` [PATCH v4 1/7] dt-bindings: phy: samsung,usb3-drd-phy: add blank lines between DT properties André Draszik
2024-12-06 16:31 ` [PATCH v4 2/7] dt-bindings: phy: samsung,usb3-drd-phy: gs101: require Type-C properties André Draszik
2024-12-11 15:47 ` Rob Herring (Arm)
2024-12-06 16:31 ` [PATCH v4 3/7] phy: exynos5-usbdrd: convert to dev_err_probe André Draszik
2024-12-26 17:29 ` William McVicker
2024-12-06 16:31 ` [PATCH v4 4/7] phy: exynos5-usbdrd: fix EDS distribution tuning (gs101) André Draszik
2024-12-26 17:31 ` William McVicker [this message]
2024-12-06 16:31 ` [PATCH v4 5/7] phy: exynos5-usbdrd: gs101: configure SS lanes based on orientation André Draszik
2024-12-26 17:31 ` William McVicker
2024-12-06 16:31 ` [PATCH v4 6/7] phy: exynos5-usbdrd: subscribe to orientation notifier if required André Draszik
2024-12-07 21:31 ` Peter Griffin
2024-12-11 17:55 ` Peter Griffin
2024-12-26 17:33 ` William McVicker
2025-02-14 19:30 ` Marek Szyprowski
2025-02-15 9:24 ` Krzysztof Kozlowski
2025-02-15 9:34 ` Krzysztof Kozlowski
2025-02-15 10:07 ` Krzysztof Kozlowski
2025-02-15 16:09 ` André Draszik
2024-12-06 16:31 ` [PATCH v4 7/7] phy: exynos5-usbdrd: allow DWC3 runtime suspend with UDC bound (E850+) André Draszik
2024-12-07 22:03 ` Peter Griffin
2024-12-11 17:53 ` Peter Griffin
2024-12-26 17:34 ` William McVicker
2024-12-26 17:28 ` [PATCH v4 0/7] USB31DRD phy updates for Google Tensor gs101 (orientation & DWC3 rpm) William McVicker
2025-01-06 14:26 ` André Draszik
2025-02-13 6:59 ` André Draszik
2025-02-13 18:16 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z22S1PPAQ4NKdrrY@google.com \
--to=willmcvicker@google.com \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=royluo@google.com \
--cc=s.nawrocki@samsung.com \
--cc=semen.protsenko@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).