Re: [PATCH v2 2/6] phy: qcom: Introduce PCIe UNIPHY 28LP driver

Dmitry Baryshkov
2024-12-04T23:01:37Z

On Wed, Dec 04, 2024 at 05:03:25PM +0530, Varadarajan Narayanan wrote:
> From: Nitheesh Sekar <quic_nsekar@quicinc.com>
>
> Add Qualcomm PCIe UNIPHY 28LP driver support present
> in Qualcomm IPQ5332 SoC and the phy init sequence.
>
> Signed-off-by: Nitheesh Sekar <quic_nsekar@quicinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> v2: Drop IPQ5018 related code and data
> Use uniform prefix for struct names
> Place "}, {", on the same line
> In qcom_uniphy_pcie_init(), use for-loop instead of while
> Swap reset and clock disable order in qcom_uniphy_pcie_power_off
> Add reset assert to qcom_uniphy_pcie_power_on's error path
> Use macros for usleep duration
> Inlined qcom_uniphy_pcie_get_resources & use devm_platform_get_and_ioremap_resource
> Drop 'clock-output-names' from phy_pipe_clk_register
> ---
> drivers/phy/qualcomm/Kconfig | 12 +
> drivers/phy/qualcomm/Makefile | 1 +
> .../phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c | 307 ++++++++++++++++++
> 3 files changed, 320 insertions(+)
> create mode 100644 drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c
>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

--
With best wishes
Dmitry