Re: [PATCH v2 2/6] phy: qcom: Introduce PCIe UNIPHY 28LP driver

Krzysztof Kozlowski
2024-12-06T08:47:07Z

On 05/12/2024 10:39, Krzysztof Kozlowski wrote:
> On Wed, Dec 04, 2024 at 05:03:25PM +0530, Varadarajan Narayanan wrote:
>> + return 0;
>> +}
>> +
>> +static struct platform_driver qcom_uniphy_pcie_driver = {
>> + .probe = qcom_uniphy_pcie_probe,
>> + .driver = {
>> + .name = "qcom-uniphy-pcie",
>> + .owner = THIS_MODULE,
>
> Srsly, upstreaming 10 year old code? No one figured out to fix 10 year
> old code before sending it upstream or entirely drop it and use new code
> as template?
>
> NAK

I should express clearer what is the problem. You sent code which looks
like 10-or-more years old driver. This means that you have there all the
issues we fixed over last 10 years. It is really meaningless for the
reviewers to point out all the things we already fixed. It is much
better if you start from new driver from scratch, thus not replicating
10-year old bugs or deprecated styles.

I suggest dropping this driver entirely and starting from scratch from
the newest accepted driver.

Whatever you choose, be 100% sure that standard tools are happy, see
below instruction:

Please run standard kernel tools for static analysis, like coccinelle,
smatch and sparse, and fix reported warnings. Also please check for
warnings when building with W=1. Most of these commands (checks or W=1
build) can build specific targets, like some directory, to narrow the
scope to only your code. The code here looks like it needs a fix. Feel
free to get in touch if the warning is not clear.

Best regards,
Krzysztof