From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Paul Handrigan <paulha@opensource.cirrus.com>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<linux-clk@vger.kernel.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<devicetree@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: Re: [PATCH v2 2/2] clk: cs2600: Add Fractional-N clock driver
Date: Thu, 19 Dec 2024 12:45:26 +0000 [thread overview]
Message-ID: <Z2QVZjSfrptMtTv6@opensource.cirrus.com> (raw)
In-Reply-To: <73077b74-10b0-4191-a024-8b9edb21f507@kernel.org>
On Thu, Dec 19, 2024 at 12:40:30PM +0100, Krzysztof Kozlowski wrote:
> On 19/12/2024 11:51, Charles Keepax wrote:
> > On Thu, Dec 19, 2024 at 09:48:05AM +0100, Krzysztof Kozlowski wrote:
> >> On Wed, Dec 18, 2024 at 08:46:31PM -0600, Paul Handrigan wrote:
> >>> +#define CS2600_PLL_OUT 0
> >>> +#define CS2600_CLK_OUT 1
> >>> +#define CS2600_BCLK_OUT 2
> >>> +#define CS2600_FSYNC_OUT 3
> >>
> >> No, the entire point of the binding header is to bind. Drop all four
> >> above and use properly your header.
> >>
> >> Otherwise I claim your binding header is not used or not really a
> >> binding.
> >
> > This excert is from the drivers internal header not the binding
> > header?
> I replied in patch two, stripping unnecessary context. There is no
> binding header here, so I do not understand your comment.
Ah sorry yes my bad, you mean drop these defines and use the ones
from the binding header instead.
Thanks,
Charles
next prev parent reply other threads:[~2024-12-19 12:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 2:46 [PATCH v2 0/2] Cirrus Logic CS2600 clock device Paul Handrigan
2024-12-19 2:46 ` [PATCH v2 1/2] dt-binding: clock: cs2600: Add support for the CS2600 Paul Handrigan
2024-12-19 8:51 ` Krzysztof Kozlowski
2024-12-19 11:02 ` Charles Keepax
2024-12-19 11:39 ` Krzysztof Kozlowski
2024-12-19 12:59 ` Charles Keepax
2024-12-19 13:16 ` Krzysztof Kozlowski
2024-12-19 13:36 ` Richard Fitzgerald
2024-12-19 15:57 ` Krzysztof Kozlowski
2024-12-19 16:22 ` Richard Fitzgerald
2024-12-21 20:19 ` Krzysztof Kozlowski
2024-12-19 2:46 ` [PATCH v2 2/2] clk: cs2600: Add Fractional-N clock driver Paul Handrigan
2024-12-19 8:48 ` Krzysztof Kozlowski
2024-12-19 10:51 ` Charles Keepax
2024-12-19 11:40 ` Krzysztof Kozlowski
2024-12-19 12:45 ` Charles Keepax [this message]
2024-12-19 12:52 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2QVZjSfrptMtTv6@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=patches@opensource.cirrus.com \
--cc=paulha@opensource.cirrus.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).