From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B203F9D2 for ; Sat, 21 Dec 2024 11:17:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734779838; cv=none; b=j5rgDT++qLKvWQyIWWclRcFE6qoyoTsG8H9pgUX+7/Q3gh90IvgbcmhiUOGNy7IwyMdJmMMSqCePcy53EWX05Xxl5HBlISRWGKsfnu5q/E/2/Aym5Ny16mGyumCq38FDwFSDGk4Xx38IrFCDJFB3Y/TG81gPSIpKlfhd41Hf8/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734779838; c=relaxed/simple; bh=G8GJdO5n3/0fPpcWJpIfNuyasHivROKITjpIp/CoHSU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pnFBvRJ1z5hZCLkY3H9IR52TsVBqm5ucqn+k9E/LeJlnnosAExCUSsNPHiirln3AJ+3Ch5fhYOo/u7eqPEInddmIaET421YI6BB2BG2MLSySr61H4CH3oLkKO0wOcSuSo6hIKm0gufHb/IRE8we8zmRA+lOgcd73XPWPHV6vwe0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=tS7B+7ao; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="tS7B+7ao" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-725d9f57d90so2087371b3a.1 for ; Sat, 21 Dec 2024 03:17:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1734779835; x=1735384635; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MUwi0cqWQPVLFktl7L0hzqf3cqViWihp2T6NPO7hxEA=; b=tS7B+7aoIfrQNFn22grYLFzRIXnb4wtLc6Ru4JrXbNtIIowORYnizDZ8/j5mSng9cp z3iWQLMbUBOGwjoLz/3gFEP3YUwgUpCUQPES0DzR2mV1+47hEC14AvLpez9I88sxg1gx bod/5+49yI8S83KQD+92/PoeCYN6J6kqclaiLCX4KWE7lbi/z0yl9FJ5zNq0SQs7iyLC wkWT+sFu7ziJwLebUpCa74IlZC3p55RX+4GbN8EzxMERx2MP+eLoHRNXdQ6DP1SHwS8J rxYo7MfbT1C67SSRPYcfNAWZ4bk9cJrasUoO1WLIT3lJFGC+D7VMwHO1N79D/r32D/sV NYug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734779835; x=1735384635; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MUwi0cqWQPVLFktl7L0hzqf3cqViWihp2T6NPO7hxEA=; b=w5dzVoADE4oTqeT7vdG7Rj3o1RhF1g0ut4mBYvBGsmRMOblIlNox+i3jFl6g35w5qZ padGDPBtpZfDcNL9D/CeGUCEyeSw9CD1+6iChDSDvQfk+vjjPAbwI6iJTmRUPvPe/78V zEkywq4YvNXHCgD7mspLLCXVNs47j/usq8HizpBM+zOwxC3eXTBbu2mLPzefgz/Ne+Qc RyP4rGXP2A4tomBBO/Z1cMP8LtZk0gkJ2tYk2fSOy0Inf86DVJLZQmicRVZbEorq2rqd GE23SWAk8H9EKZLwiT1P65lIKMzKLiabo9K/EK10/JwSugOEwoLUIJ2OKND7MGfZzcDp kATg== X-Forwarded-Encrypted: i=1; AJvYcCWKkMVYGhF0iTsMITudtDvMNEShfluy+Ii9UUiiZLIAIfrrlqYc3lUg4jnP7s4iiBTLxhC/I6XifwFn@vger.kernel.org X-Gm-Message-State: AOJu0YxrgxcEWj3PUoJdHl89G0EldnhBshYg8zdyYvm7s8WuWZmT7llv gxGfYcLN+1XYdqgX+NgUT40bsegrEqqiKl7iMxU2BLhZC1hiZ816Q8jwgNxGB1UrKY8F8jHTi/A z X-Gm-Gg: ASbGncuVW6JL6ua2Kwx63fqUmB57LgXlnjdgPYorR9h909sY9T926kLUrbzXbmuCLeL ZR32A0DM2EDj6DfGz+Rq5xsOAhPg42L9N5YmzmQqd4/DoYRY9Lb7Ii3fkr3ivT8FLasNGuLUy2I V4hhtXqY4F85p51bF1Ecwj4YkjLzyC+IZswVUsZ9CGJvS6aiPvLEsfSEivQ94pxyBPfm8trHWcs AEx/4gdaMi++rnUsVuPa6xTSTAJJvmLWgA3TlhO4RVmHKbVnpw4/hcQCL/Zdr9jbqptPZFOhQo1 ARkiKwTygK6OBXRX X-Google-Smtp-Source: AGHT+IETtl39lfiWah7ZB6Wjx81ZG/H3eQ/XeN1Pwp4p0WHw+hzES8qCUaNjmE9BHQM4U1V4zI75bA== X-Received: by 2002:a05:6a20:7f8a:b0:1e3:e6f3:6372 with SMTP id adf61e73a8af0-1e5e07bc390mr9835251637.27.1734779834852; Sat, 21 Dec 2024 03:17:14 -0800 (PST) Received: from dev-linux (syn-076-088-115-008.res.spectrum.com. [76.88.115.8]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad815804sm4585320b3a.32.2024.12.21.03.17.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Dec 2024 03:17:14 -0800 (PST) Date: Sat, 21 Dec 2024 03:16:26 -0800 From: Sukrut Bellary To: Judith Mendez Cc: Tony Lindgren , Kevin Hilman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bin Liu Subject: Re: [PATCH] ARM: dts: ti: am437x-l4: remove autoidle for UART Message-ID: References: <20241220223523.2125278-1-jm@ti.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241220223523.2125278-1-jm@ti.com> On Fri, Dec 20, 2024 at 04:35:23PM -0600, Judith Mendez wrote: > According to the TRM [0] in 21.5.1.42 UART_SYSC Register, > the autoidle bit should not be set for UART, so remove the > appropriate SYSC_OMAP2_AUTOIDLE flag. > > [0] https://www.ti.com/lit/ug/spruhl7i/spruhl7i.pdf > Signed-off-by: Judith Mendez > --- > arch/arm/boot/dts/ti/omap/am437x-l4.dtsi | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi > index 824b9415ebbe9..fd4634f8c6293 100644 > --- a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi > +++ b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi > @@ -180,8 +180,7 @@ target-module@9000 { /* 0x44e09000, ap 16 04.0 */ > <0x9058 0x4>; > reg-names = "rev", "sysc", "syss"; > ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | > - SYSC_OMAP2_SOFTRESET | > - SYSC_OMAP2_AUTOIDLE)>; > + SYSC_OMAP2_SOFTRESET)>; > ti,sysc-sidle = , > , > , > @@ -698,8 +697,7 @@ target-module@22000 { /* 0x48022000, ap 8 0a.0 */ > <0x22058 0x4>; > reg-names = "rev", "sysc", "syss"; > ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | > - SYSC_OMAP2_SOFTRESET | > - SYSC_OMAP2_AUTOIDLE)>; > + SYSC_OMAP2_SOFTRESET)>; > ti,sysc-sidle = , > , > , > @@ -726,8 +724,7 @@ target-module@24000 { /* 0x48024000, ap 10 1c.0 */ > <0x24058 0x4>; > reg-names = "rev", "sysc", "syss"; > ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | > - SYSC_OMAP2_SOFTRESET | > - SYSC_OMAP2_AUTOIDLE)>; > + SYSC_OMAP2_SOFTRESET)>; > ti,sysc-sidle = , > , > , > @@ -1385,8 +1382,7 @@ target-module@a6000 { /* 0x481a6000, ap 40 16.0 */ > <0xa6058 0x4>; > reg-names = "rev", "sysc", "syss"; > ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | > - SYSC_OMAP2_SOFTRESET | > - SYSC_OMAP2_AUTOIDLE)>; > + SYSC_OMAP2_SOFTRESET)>; > ti,sysc-sidle = , > , > , > @@ -1413,8 +1409,7 @@ target-module@a8000 { /* 0x481a8000, ap 42 20.0 */ > <0xa8058 0x4>; > reg-names = "rev", "sysc", "syss"; > ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | > - SYSC_OMAP2_SOFTRESET | > - SYSC_OMAP2_AUTOIDLE)>; > + SYSC_OMAP2_SOFTRESET)>; > ti,sysc-sidle = , > , > , > @@ -1441,8 +1436,7 @@ target-module@aa000 { /* 0x481aa000, ap 44 12.0 */ > <0xaa058 0x4>; > reg-names = "rev", "sysc", "syss"; > ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | > - SYSC_OMAP2_SOFTRESET | > - SYSC_OMAP2_AUTOIDLE)>; > + SYSC_OMAP2_SOFTRESET)>; > ti,sysc-sidle = , > , > , > -- > 2.47.1 > Looks good to me. Reviewed-by: Sukrut Bellary