From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A046A59; Wed, 8 Jan 2025 07:40:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736322061; cv=none; b=ach/StjxW+eYUgPsKVhnsHgvlNt86cGU/oeoi8MdpdW0nilrKdYc20KXcWtjOb4HDYzhoFnzEOLYB99o0y6jXoJ/kgUUcl47UA3wnP53M5UF+UToyupjLjPL5BlYYVM4c7yZYernJ9TbJL3YW97XyV3u++1RcsOJ+/5cn3eWSsU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736322061; c=relaxed/simple; bh=2P1CHrm8JZwuseKLaSN0OkMEkHw2V+L5suFY042b03A=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lHnrf9wz8+OVQgN3HSg8kB/0rkN7Q2P1FuuqM/UZeaLS83JGcLAh+pCA7txUs/OlwOryErRngOGqaKkKLMeFM356nzjqgooRUDKVFwO/iJte0eZnouluNPKbHvChVd3wJabNrF9xLa63nU50AFQBipJXiuMxjlNi9DUQ9qAUwro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=VF8G+ALC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="VF8G+ALC" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5087DcHL004852; Wed, 8 Jan 2025 07:40:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=AFcLa64MHCpVfa37awLVAMKs qRcEELW2evvgmYO5Fbc=; b=VF8G+ALCwx6h9LWfIqVVXrxe1ar1rycWfV6dvt2R kL3JRaerH8OjWG9nAP5jMOAVQ2ns2Y1NvOMrWGf0oFp+vDXkU7Aa0lswnbQbHV9k XkTgTAlHbwrkeddLX4b6Yb+Sh7hJTPlfIL6kr8HQgkfp/D1PAqDwAXrtMyLn4aRO jGzflBpsZgl8mUXrjAolXo1mXMVoQXIynhsR4LHtjSxrYqb7q7l0dVWaa0BwyRYm lCb2pPqxbA82SpPNgfCnsbGRtaiuKYaP0SMwmqpCIiWRi/5zfUdewPlMzxLwtmzH GSfptRI8NqibTHyv9Zr557nsi7NMkt8hLbrT0DQSXbCM4Q== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 441msq026e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jan 2025 07:40:47 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 5087elcm027579 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 8 Jan 2025 07:40:47 GMT Received: from hu-varada-blr.qualcomm.com (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 7 Jan 2025 23:40:40 -0800 Date: Wed, 8 Jan 2025 13:10:36 +0530 From: Varadarajan Narayanan To: Krzysztof Kozlowski CC: , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v5 3/5] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe controller Message-ID: References: <20250102113019.1347068-1-quic_varada@quicinc.com> <20250102113019.1347068-4-quic_varada@quicinc.com> <4hwclzotaowog6rzfejiixqvvg7iumg4udbvq3h72mmh42dbki@piphsf37vhpv> <50b03189-bf2c-46c8-b7c2-4aa5eed97c35@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <50b03189-bf2c-46c8-b7c2-4aa5eed97c35@kernel.org> X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: MqRpy0peP3xR2VvtoYQ3B19Hgx7Iie9w X-Proofpoint-GUID: MqRpy0peP3xR2VvtoYQ3B19Hgx7Iie9w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 clxscore=1015 priorityscore=1501 mlxlogscore=995 suspectscore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 spamscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501080060 On Wed, Jan 08, 2025 at 08:19:19AM +0100, Krzysztof Kozlowski wrote: > On 07/01/2025 12:05, Varadarajan Narayanan wrote: > >>> --- > >>> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 10 ++++++++-- > >>> 1 file changed, 8 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > >>> index bd87f6b49d68..9f37eca1ce0d 100644 > >>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > >>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > >>> @@ -26,7 +26,6 @@ properties: > >>> - qcom,pcie-ipq8064-v2 > >>> - qcom,pcie-ipq8074 > >>> - qcom,pcie-ipq8074-gen3 > >>> - - qcom,pcie-ipq9574 > >> > >> I don't understand this change at all and your commit msg explains > >> here nothing. > > > > All DT entries except "reg" is similar between ipq5332 and > > ipq9574. ipq9574 has 5 registers while ipq5332 has 6. MHI is the > > additional (i.e. sixth) entry for ipq5332. > > > > If ipq9574 is not removed from here, dt_binding_check gives the > > following errors > > > > 1. /local/mnt/workspace/varada/upstream/pci-v6/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dtb: pcie@18000000: reg: [[557056, 12288], [402653184, 3869], [402657056, 168], [402657280, 4096], [403701760, 4096], [569344, 4096]] is too long > > > > Failed validating 'maxItems' in schema['allOf'][2]['then']['properties']['reg']: > > {'maxItems': 5, 'minItems': 5} > > > > 2. /local/mnt/workspace/varada/upstream/pci-v6/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dtb: pcie@18000000: reg-names: ['parf', 'dbi', 'elbi', 'atu', 'config', 'mhi'] is too long > > > > Failed validating 'maxItems' in schema['allOf'][2]['then']['properties']['reg-names']: > > {'items': [{'const': 'dbi'}, > > {'const': 'elbi'}, > > {'const': 'atu'}, > > {'const': 'parf'}, > > {'const': 'config'}], > > 'maxItems': 5, > > 'minItems': 5, > > 'type': 'array'} > > > > Hence had to remove it from here and add it to the sdx55 reg > > definition. > > So you entirely dropped constrain for regs. No. This has to be fixed, > not dropped. ipq9574 is not dropped entirely. It is clubbed with sdx55's constraints. Please see this @@ -206,6 +208,8 @@ allOf: compatible: contains: enum: + - qcom,pcie-ipq5332 + - qcom,pcie-ipq9574 - qcom,pcie-sdx55 then: properties: Thanks Varada