From: Johan Hovold <johan@kernel.org>
To: Abel Vesa <abel.vesa@linaro.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
Sibi Sankar <quic_sibis@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Trilok Soni <quic_tsoni@quicinc.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 2/6] usb: typec: Add support for Parade PS8830 Type-C Retimer
Date: Tue, 7 Jan 2025 10:46:29 +0100 [thread overview]
Message-ID: <Z3z39Z_BH1stsO0c@hovoldconsulting.com> (raw)
In-Reply-To: <Z3vlTwR+SiZQWVh7@linaro.org>
On Mon, Jan 06, 2025 at 04:14:39PM +0200, Abel Vesa wrote:
> On 24-12-04 17:24:54, Johan Hovold wrote:
> > On Tue, Nov 12, 2024 at 07:01:11PM +0200, Abel Vesa wrote:
> > > + /* skip resetting if already configured */
> > > + if (regmap_test_bits(retimer->regmap, REG_USB_PORT_CONN_STATUS_0,
> > > + CONN_STATUS_0_CONNECTION_PRESENT))
> > > + return 0;
> >
> > What if the device is held in reset? This looks like it only works if
> > the boot firmware has already enabled the retimer. Otherwise you may
> > return success from probe here with the retimer still in reset.
>
> Please correct me if I'm wrong, but if the read above fails or reads
> anything else than "connection present", then below we go through the
> resetting sequence. If it reads "connection present", then retimer can't
> be in reset.
regmap_test_bits() returns a negative errno if the read fails, so you
need to check that the return value is 1 here to avoid returning success
from probe on failure.
Johan
next prev parent reply other threads:[~2025-01-07 9:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 17:01 [PATCH v5 0/6] usb: typec: Add new driver for Parade PS8830 Type-C Retimer Abel Vesa
2024-11-12 17:01 ` [PATCH v5 1/6] dt-bindings: usb: Add Parade PS8830 Type-C retimer bindings Abel Vesa
2024-11-15 16:44 ` Rob Herring
2024-11-12 17:01 ` [PATCH v5 2/6] usb: typec: Add support for Parade PS8830 Type-C Retimer Abel Vesa
2024-12-04 16:24 ` Johan Hovold
2024-12-05 23:05 ` Bjorn Andersson
2024-12-07 21:45 ` Abel Vesa
2025-01-06 14:14 ` Abel Vesa
2025-01-07 9:46 ` Johan Hovold [this message]
2024-11-12 17:01 ` [PATCH v5 3/6] arm64: dts: qcom: x1e80100-crd: Describe the Parade PS8830 retimers Abel Vesa
2024-11-12 17:01 ` [PATCH v5 4/6] arm64: dts: qcom: x1e80100-crd: Enable external DisplayPort support Abel Vesa
2024-11-12 17:05 ` Abel Vesa
2024-11-13 6:03 ` Greg Kroah-Hartman
2025-01-06 14:24 ` Abel Vesa
2024-11-12 17:01 ` [PATCH v5 5/6] arm64: dts: qcom: x1e80100-t14s: Describe the Parade PS8830 retimers Abel Vesa
2024-11-12 17:01 ` [PATCH v5 6/6] arm64: dts: qcom: x1e80100-t14s: Enable external DisplayPort support Abel Vesa
2024-11-12 17:05 ` Abel Vesa
2024-11-15 15:13 ` [PATCH v5 0/6] usb: typec: Add new driver for Parade PS8830 Type-C Retimer Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3z39Z_BH1stsO0c@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).