[PATCH 0/5] Add support for RZ/G3E WDT

[PATCH 0/5] Add support for RZ/G3E WDT

[Biju Das]

The RZ/G3E WDT IP is similar to RZ/V2H WDT. WDT0 can be used for CM33 cold
reset, system reset and asserting WDTUDFCM pin where as WDT1 can be used
for CA55 cold reset, system reset and asserting WDTUDFCA pin. Other 2
watchdogs can be used for system reset. So define WDT{1..3} in SoC dtsi.

Biju Das (5):
  dt-bindings: watchdog: renesas,wdt: Document RZ/G3E support
  clk: renesas: r9a09g047: Add WDT clocks/resets
  watchdog: Make RZV2HWDT driver depend on ARCH_R9A09G47
  arm64: dts: renesas: r9a09g047: Add WDT1-WDT3 nodes
  arm64: dts: renesas: r9a09g047e57-smarc: Enable watchdog

 .../bindings/watchdog/renesas,wdt.yaml        |  4 +++
 arch/arm64/boot/dts/renesas/r9a09g047.dtsi    | 30 +++++++++++++++++++
 .../boot/dts/renesas/r9a09g047e57-smarc.dts   |  4 +++
 drivers/clk/renesas/r9a09g047-cpg.c           | 15 ++++++++++
 drivers/watchdog/Kconfig                      |  7 +++--
 5 files changed, 57 insertions(+), 3 deletions(-)

-- 
2.43.0

[PATCH 1/5] dt-bindings: watchdog: renesas,wdt: Document RZ/G3E support

[Biju Das]

Document the support for the watchdog IP available on RZ/G3E SoC. The
watchdog IP available on RZ/G3E SoC is identical to the one found on
RZ/V2H SoC.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
index 29ada89fdcdc..3e0a8747a357 100644
--- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
@@ -75,6 +75,10 @@ properties:
               - renesas,r8a779h0-wdt     # R-Car V4M
           - const: renesas,rcar-gen4-wdt # R-Car Gen4
 
+      - items:
+          - const: renesas,r9a09g047-wdt # RZ/G3E
+          - const: renesas,r9a09g057-wdt # RZ/V2H(P)
+
       - const: renesas,r9a09g057-wdt       # RZ/V2H(P)
 
   reg:
-- 
2.43.0

Re: [PATCH 1/5] dt-bindings: watchdog: renesas,wdt: Document RZ/G3E support

[Krzysztof Kozlowski]

On Wed, Jan 15, 2025 at 10:38:50AM +0000, Biju Das wrote:
> Document the support for the watchdog IP available on RZ/G3E SoC. The
> watchdog IP available on RZ/G3E SoC is identical to the one found on
> RZ/V2H SoC.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml | 4 ++++
>  1 file changed, 4 insertions(+)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 1/5] dt-bindings: watchdog: renesas,wdt: Document RZ/G3E support

[Geert Uytterhoeven]

On Wed, Jan 15, 2025 at 11:39 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Document the support for the watchdog IP available on RZ/G3E SoC. The
> watchdog IP available on RZ/G3E SoC is identical to the one found on
> RZ/V2H SoC.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 4/5] arm64: dts: renesas: r9a09g047: Add WDT1-WDT3 nodes

[Biju Das]

Add WDT1-WDT3 nodes to RZ/G3E ("R9A09G047") SoC DTSI.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r9a09g047.dtsi | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
index 200e9ea89193..133aa3272d3a 100644
--- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
@@ -175,6 +175,36 @@ scif0: serial@11c01400 {
 			status = "disabled";
 		};
 
+		wdt1: watchdog@14400000 {
+			compatible = "renesas,r9a09g047-wdt", "renesas,r9a09g057-wdt";
+			reg = <0 0x14400000 0 0x400>;
+			clocks = <&cpg CPG_MOD 0x4d>, <&cpg CPG_MOD 0x4e>;
+			clock-names = "pclk", "oscclk";
+			resets = <&cpg 0x76>;
+			power-domains = <&cpg>;
+			status = "disabled";
+		};
+
+		wdt2: watchdog@13000000 {
+			compatible = "renesas,r9a09g047-wdt", "renesas,r9a09g057-wdt";
+			reg = <0 0x13000000 0 0x400>;
+			clocks = <&cpg CPG_MOD 0x4f>, <&cpg CPG_MOD 0x50>;
+			clock-names = "pclk", "oscclk";
+			resets = <&cpg 0x77>;
+			power-domains = <&cpg>;
+			status = "disabled";
+		};
+
+		wdt3: watchdog@13000400 {
+			compatible = "renesas,r9a09g047-wdt", "renesas,r9a09g057-wdt";
+			reg = <0 0x13000400 0 0x400>;
+			clocks = <&cpg CPG_MOD 0x51>, <&cpg CPG_MOD 0x52>;
+			clock-names = "pclk", "oscclk";
+			resets = <&cpg 0x78>;
+			power-domains = <&cpg>;
+			status = "disabled";
+		};
+
 		i2c0: i2c@14400400 {
 			compatible = "renesas,riic-r9a09g047", "renesas,riic-r9a09g057";
 			reg = <0 0x14400400 0 0x400>;
-- 
2.43.0

Re: [PATCH 4/5] arm64: dts: renesas: r9a09g047: Add WDT1-WDT3 nodes

[Geert Uytterhoeven]

On Wed, Jan 15, 2025 at 11:39 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Add WDT1-WDT3 nodes to RZ/G3E ("R9A09G047") SoC DTSI.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.15.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 5/5] arm64: dts: renesas: r9a09g047e57-smarc: Enable watchdog

[Biju Das]

Enable WDT1 watchdog on RZ/G3E SMARC EVK platform.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
index c063d47e2952..33b036b6a93c 100644
--- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
+++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
@@ -29,3 +29,7 @@ &scif0 {
 	pinctrl-0 = <&scif_pins>;
 	pinctrl-names = "default";
 };
+
+&wdt1 {
+	status = "okay";
+};
-- 
2.43.0

RE: [PATCH 5/5] arm64: dts: renesas: r9a09g047e57-smarc: Enable watchdog

[Biju Das]

Hi All,

> -----Original Message-----
> From: Biju Das <biju.das.jz@bp.renesas.com>
> Sent: 15 January 2025 10:39
> Subject: [PATCH 5/5] arm64: dts: renesas: r9a09g047e57-smarc: Enable watchdog
> 
> Enable WDT1 watchdog on RZ/G3E SMARC EVK platform.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> index c063d47e2952..33b036b6a93c 100644
> --- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> +++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> @@ -29,3 +29,7 @@ &scif0 {
>  	pinctrl-0 = <&scif_pins>;
>  	pinctrl-names = "default";
>  };
> +
> +&wdt1 {
> +	status = "okay";
> +};

I will move this node to SoM dtsi on the next version, to have consistency with
other Renesas RZ/G2L SoM modules.

Cheers,
Biju

Re: [PATCH 5/5] arm64: dts: renesas: r9a09g047e57-smarc: Enable watchdog

[Geert Uytterhoeven]

Hi Biju,

On Wed, Jan 15, 2025 at 6:20 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> > Enable WDT1 watchdog on RZ/G3E SMARC EVK platform.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Thanks for your patch!

> > index c063d47e2952..33b036b6a93c 100644
> > --- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> > @@ -29,3 +29,7 @@ &scif0 {
> >       pinctrl-0 = <&scif_pins>;
> >       pinctrl-names = "default";
> >  };
> > +
> > +&wdt1 {
> > +     status = "okay";
> > +};
>
> I will move this node to SoM dtsi on the next version, to have consistency with
> other Renesas RZ/G2L SoM modules.

I can move it to arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
while applying, so you don't have to resend any patches related to
other subsystems than the watchdog subsystem.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.15.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH 5/5] arm64: dts: renesas: r9a09g047e57-smarc: Enable watchdog

[Biju Das]

Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 23 January 2025 10:18
> Subject: Re: [PATCH 5/5] arm64: dts: renesas: r9a09g047e57-smarc: Enable watchdog
> 
> Hi Biju,
> 
> On Wed, Jan 15, 2025 at 6:20 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > > From: Biju Das <biju.das.jz@bp.renesas.com> Enable WDT1 watchdog on
> > > RZ/G3E SMARC EVK platform.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Thanks for your patch!
> 
> > > index c063d47e2952..33b036b6a93c 100644
> > > --- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> > > +++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> > > @@ -29,3 +29,7 @@ &scif0 {
> > >       pinctrl-0 = <&scif_pins>;
> > >       pinctrl-names = "default";
> > >  };
> > > +
> > > +&wdt1 {
> > > +     status = "okay";
> > > +};
> >
> > I will move this node to SoM dtsi on the next version, to have
> > consistency with other Renesas RZ/G2L SoM modules.
> 
> I can move it to arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> while applying, so you don't have to resend any patches related to other subsystems than the watchdog
> subsystem.

Thanks for taking care it.

Cheers,
Biju

Re: [PATCH 0/5] Add support for RZ/G3E WDT

[Tommaso Merciai]

Hi Biju,

On Wed, Jan 15, 2025 at 10:38:49AM +0000, Biju Das wrote:
> The RZ/G3E WDT IP is similar to RZ/V2H WDT. WDT0 can be used for CM33 cold
> reset, system reset and asserting WDTUDFCM pin where as WDT1 can be used
> for CA55 cold reset, system reset and asserting WDTUDFCA pin. Other 2
> watchdogs can be used for system reset. So define WDT{1..3} in SoC dtsi.

For all the series:
Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>

> 
> Biju Das (5):
>   dt-bindings: watchdog: renesas,wdt: Document RZ/G3E support
>   clk: renesas: r9a09g047: Add WDT clocks/resets
>   watchdog: Make RZV2HWDT driver depend on ARCH_R9A09G47
>   arm64: dts: renesas: r9a09g047: Add WDT1-WDT3 nodes
>   arm64: dts: renesas: r9a09g047e57-smarc: Enable watchdog
> 
>  .../bindings/watchdog/renesas,wdt.yaml        |  4 +++
>  arch/arm64/boot/dts/renesas/r9a09g047.dtsi    | 30 +++++++++++++++++++
>  .../boot/dts/renesas/r9a09g047e57-smarc.dts   |  4 +++
>  drivers/clk/renesas/r9a09g047-cpg.c           | 15 ++++++++++
>  drivers/watchdog/Kconfig                      |  7 +++--
>  5 files changed, 57 insertions(+), 3 deletions(-)
> 
> -- 
> 2.43.0
> 
> 

Thanks & Regards,
Tommaso