From: Andy Shevchenko <andy@kernel.org>
To: Andre Werner <andre.werner@systec-electronic.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
hvilleneuve@dimonoff.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
lech.perczak@camlingroup.com, krzk+dt@kernel.org,
conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v7] serial: sc16is7xx: Add polling mode if no IRQ pin is available
Date: Thu, 16 Jan 2025 11:02:43 +0200 [thread overview]
Message-ID: <Z4jLM-EQPOXWj2Xx@smile.fi.intel.com> (raw)
In-Reply-To: <20250116083447.453615-1-andre.werner@systec-electronic.com>
On Thu, Jan 16, 2025 at 09:34:47AM +0100, Andre Werner wrote:
> Fall back to polling mode if no interrupt is configured because there
> is no possibility to connect the interrupt pin.
>
> If no interrupt pin is available the driver uses a delayed worker to
> poll the state of interrupt status registers (IIR).
The commit message should be changed to reflect the code.
I.e. "Fix the IRQ check to treat the negative values as No IRQ."
> Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
> Link: https://lore.kernel.org/r/20250110073104.1029633-2-andre.werner@systec-electronic.com
This should not be here.
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
It's not signed by Greg.
> V7:
> - Try to improve and unify comments as requested.
> - Fix typo in commit message: pull -> poll
Version should be 1 and Subject has to be changed accordingly.
...
> - s->polling = !!irq;
> + s->polling = (irq <= 0);
This is the only line has to be changed in the patch.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-01-16 9:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 7:04 [PATCH v7 1/2] dt-bindings: serial: sc16is7xx: Add description for polling mode Andre Werner
2025-01-14 7:04 ` [PATCH v7 2/2] serial: sc16is7xx: Add polling mode if no IRQ pin is available Andre Werner
2025-01-14 14:56 ` Andy Shevchenko
2025-01-15 5:23 ` [External Email] " Andre Werner
2025-01-15 15:08 ` Andy Shevchenko
2025-01-16 8:34 ` [PATCH v7] " Andre Werner
2025-01-16 8:42 ` Andre Werner
2025-01-16 9:03 ` Andy Shevchenko
2025-01-16 9:02 ` Andy Shevchenko [this message]
2025-01-17 11:50 ` Greg KH
2025-01-17 12:37 ` [External Email] " Andre Werner
2025-01-17 12:40 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4jLM-EQPOXWj2Xx@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=andre.werner@systec-electronic.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lech.perczak@camlingroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).