From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B0C022CF35 for ; Thu, 16 Jan 2025 17:06:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737047193; cv=none; b=HJrg9po57UIVSaNNqSl47DPe5Wu5i9TDX+CutJhg0lekwPwV9xi/Ywt0kp7Enws42E2HuPDtLPWck0yDDNvBboqqMiW2XrfsgC4ihTWoLiRqpxmqzHjNys/dM/vxtKZWYEOBnpT8ZUBSO3q0C86ZNXeEeMr7J7r6PkFjQ1rtEYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737047193; c=relaxed/simple; bh=W+QGc9oosMrG2hvhQQqwCmRtn0fdpGyURO0Yr4Zq1co=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M1pVtcrBt2GrppUJv2haOLGjHykdEhmP0AdLtMVlcM87cGDvzPJEsz2qtKMBy6xZoGzE+vI83CctTCAg6WNMJN9c1x6xq8Jzb0q1aVQf1kFwvkT7YfX9ul82gOw0R6ckm9DJygSdeHw4uksjHqd6rNLaI3z9r8aU1PTtpE6KzO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QAy0B+XM; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QAy0B+XM" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-aaf8f0ea963so223355766b.3 for ; Thu, 16 Jan 2025 09:06:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737047189; x=1737651989; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BUIr9PWzb9ez1XMOIgMRecuSTosnClxVHi549vZTFOM=; b=QAy0B+XMNCd+Vld5BC8lhiUO7muW33DE7ITBNoqDuLScEIRdYgMNG+qt3W70gqpHHI X2/mW0WUlBcDl15j9rBtJMoeOTPseb7dtDBiRUV3ElwBGYKJhmSHEPM47SGH2LhQGiJf F0VfieJ+6+fwKTdJ1YM+eX9J3CycUFbokQlRKPikW9R49ou15DikiTped/y/250JBFgK Kvi15zHErjAiOhkviT/QW0q2m2TdygueOXVrOn8S3s+sOvpIBLOs4JGdqUGRc2iD2tKK Or64eT1wk+RBnPkPZnbqjvAZK/9rAGEAcMVA8a/c/b+BbdA4WPPvmT94yE97fTus7y07 8xvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737047189; x=1737651989; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BUIr9PWzb9ez1XMOIgMRecuSTosnClxVHi549vZTFOM=; b=OWOIA93RHVFWV70R4U1p53QbstLCRWeVV1rfpNa+dhQOHZC4i/85ir+sik2dvJTIhH A7NWk829Kev5EVSgG/vtAEXm95r1InYF12UxhOdJIDgLbxc7npiBRY+oODnLZOxlZEd/ MT9nNoz/ZKDiW+URkOZIR2I66QnDxUQxkieRgJa7+hK3caKjvBiHt/vG3jA7YNQSNw0x QN1TrhL3QEk5RuCwQudgIsFPgcZwCb8uXn0ygmIZ4hbeagZU/HOCc1yhH6NvaZAdgwm9 z16frI1mtQFZ2iv5YA9tcKTkwX1lbG7FIVDSdy6yhkmOwrYT7be9d5ssOUeioLekXj+r NhEg== X-Forwarded-Encrypted: i=1; AJvYcCUntQDBgvMdD6MFbFsc2LjAtHukLIvQEMpRv3ZCmkyjBcdleuPnoMt6M4sHuQ8eAqOSX7mO0jIvX34x@vger.kernel.org X-Gm-Message-State: AOJu0YyFbZ+S7uQztcV4VT1AiwSvrfYLXlwDK7VTs+mbyQ7n8znz12kd PQ1bxbyjdBVO3xgY5K6Snc2O4YubE/SpfuzAQbfrLHHazt/UsUb1wF9jf1rrFjU= X-Gm-Gg: ASbGncs5JdIaieupqgkmuJq8GbilJtujtDnGglsyoUTNz83YkvwazmNYfpTcR8aG1s7 6OChxd7FxcJbNtjruyLMh6UtfIaI3gtWsdPAJzCguNZ0/FzybjI91p6FwrNym8gdKgAQxDvzUBg r7U5/z3nRca73e1Dzrp9A4ymFDjD7UnOQ5O7LHc7Dkm2/5pwWDUQXvr34LUarjUpN4RX6AVyjmG lrr4m5rMlxVboJXmqs+BE34s+cwvs8NsmbafocXccdY6qDuhBP3wBDBItKBX8sLIkIo X-Google-Smtp-Source: AGHT+IEWnTHAyFXkE0XlaBZ/9fyifrzBZNDc9Ug+NzTkqqLyaR8APJQHdyWg+XE5PT7+tDEl09HKBA== X-Received: by 2002:a17:907:2d06:b0:ab3:47cc:a7dd with SMTP id a640c23a62f3a-ab347ccb3bdmr852600366b.25.1737047188599; Thu, 16 Jan 2025 09:06:28 -0800 (PST) Received: from linaro.org ([2a02:2454:ff21:ef30:d082:eaaf:227f:16cd]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab384f87d70sm21166266b.142.2025.01.16.09.06.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 09:06:28 -0800 (PST) Date: Thu, 16 Jan 2025 18:06:26 +0100 From: Stephan Gerhold To: Melody Olvera Cc: Thara Gopinath , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Satya Durga Srinivasu Prabhala , Trilok Soni , linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Gaurav Kashyap Subject: Re: [PATCH 2/6] arm64: dts: qcom: sm8750: Add QCrypto nodes Message-ID: References: <20250113-sm8750_crypto_master-v1-0-d8e265729848@quicinc.com> <20250113-sm8750_crypto_master-v1-2-d8e265729848@quicinc.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250113-sm8750_crypto_master-v1-2-d8e265729848@quicinc.com> On Mon, Jan 13, 2025 at 01:16:22PM -0800, Melody Olvera wrote: > From: Gaurav Kashyap > > Add the QCE and Crypto BAM DMA nodes. > > Signed-off-by: Gaurav Kashyap > Signed-off-by: Melody Olvera > --- > arch/arm64/boot/dts/qcom/sm8750.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi > index 3bbd7d18598ee0a3a0d5130c03a3166e1fc14d82..1ddb33ea83885e73bf15244c9cbd7067ae28cded 100644 > --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi > @@ -1939,6 +1939,36 @@ mmss_noc: interconnect@1780000 { > #interconnect-cells = <2>; > }; > > + cryptobam: dma-controller@1dc4000 { > + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > + reg = <0x0 0x01dc4000 0x0 0x28000>; > + > + interrupts = ; > + > + #dma-cells = <1>; > + > + iommus = <&apps_smmu 0x480 0>, > + <&apps_smmu 0x481 0>; Should be equivalent to iommus = <&apps_smmu 0x480 0x1>? > + > + qcom,ee = <0>; > + qcom,controlled-remotely; If you don't have clocks here, you need to provide num-channels and qcom,num-ees. Otherwise, there is a risk this will crash if the BAM is not up while being probed. Thanks, Stephan