From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37D1E13C807; Fri, 24 Jan 2025 14:07:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737727642; cv=none; b=OKCVpM3ZwFiZrhnYqsm5k/z8LTLmoBFkMVPdIZmBD5FYe9GHXJDxKhlUOMLc0lD4qBWHf8oQ6Jqq5uccm8EACqlgtk+wpbSLZGnWrxt0f2+KXqXAMgH7zp8Pa7VdiI3YizhYxw14zIpZra3xKI1dRMt49UCaWvZZ1my6TRT+9dg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737727642; c=relaxed/simple; bh=wxYCuWnJt+GTJlbMqLQWecdmDxpr7pUhECUTtYJ6/I4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u6O+99HpzrhKMD7y2eJv1G+jongOB9wOHN6s0wCPb80DakExM5U7bQYJuqT3cL7V+nQhpV/6y9DIVc+qyPsOS3tBbfVOGfAsuvVZSz4oSlj2hHAaoUkaHCqfkAIyzJB0iPJvqGd/ECfTwjSjzqj/8JzFsQjgJIa+DD3s6zqP+mM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PISFTcUW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PISFTcUW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AD29C4CED2; Fri, 24 Jan 2025 14:07:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737727642; bh=wxYCuWnJt+GTJlbMqLQWecdmDxpr7pUhECUTtYJ6/I4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PISFTcUWLvH42s6xDtcILB0SJDo54dASpkJMzyqUkbw02Kfn4T82hLkn5yVmnRWIe jSSkeJJ7eAycnUYlzmWZtxbGlp1j2n4aIqSH47D8a+0pvhsK/e5ai6nBrNiW9ldIJT Wod4ZZOxW1RRxyln3aXqDQ9OhED9cBzP2D/rEDTOgkwgQtLbDzhGGju9D7SIa6uLUn ngDf/JkzLnSSlANTlti3zWW5kFMVOl/7EobN01Ey3tt4vDDG3irnxFwi6H2paYhoKd aSyHaL8AIPzGdg3OLxxWmbZB3aQ9JRnb/D5t1Pjn16WJ3n3XgCZux30yS9zMFLsMBv phX0uqev/tF3Q== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1tbKLI-000000007bb-3rDQ; Fri, 24 Jan 2025 15:07:28 +0100 Date: Fri, 24 Jan 2025 15:07:28 +0100 From: Johan Hovold To: Tobias Heider Cc: Johan Hovold , Alexandre Belloni , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Jonathan Marek , linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] rtc: pm8xxx: add support for uefi offset Message-ID: References: <20250120144152.11949-1-johan+linaro@kernel.org> <20250120144152.11949-4-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jan 24, 2025 at 01:56:56PM +0100, Tobias Heider wrote: > On Mon, Jan 20, 2025 at 03:41:48PM GMT, Johan Hovold wrote: > > On many Qualcomm platforms the PMIC RTC control and time registers are > > read-only so that the RTC time can not be updated. Instead an offset > > needs be stored in some machine-specific non-volatile memory, which the > > driver can take into account. > > > > Add support for storing a 32-bit offset from the GPS time epoch in a > > UEFI variable so that the RTC time can be set on such platforms. > Thanks for the great work Johan, seems to work nicely here! Thanks for testing. > I think you might need to add MODULE_IMPORT_NS(EFIVAR) for the efivar_* > API calls you added. It's already there (inside the ifdef): > > +#ifdef CONFIG_EFI > > + > > +MODULE_IMPORT_NS("EFIVAR"); Johan