From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A3701DE4C3 for ; Tue, 28 Jan 2025 08:05:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738051545; cv=none; b=YsFHT8eEgmyv3CpedxPMg2g8bAYo7fwIt7bMaXXEGIjWvZrzWB3N4yeb1vr7dC6Vc448m7stzOonhgxsQ6iA7RoUxkBFfkDnXVn/IyKiowhBVcO/V1wTtJcqDs/O0Un5b6DBM0LVMIICf6QgjqVnOe60SwyRo2K3cJy/iZYsi9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738051545; c=relaxed/simple; bh=Q0YF0DVZeFVEE1vVCuvD4EYSrmuqlryjxIBMgxE8T2E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JKb3kRSKqxv0Pbul2jlR6eX32XjnJHkxY21xjY4Q0rV0pydbxFLQgE6q08chvPJPEjfUxH2YYNwBbhSrTys6DLCYK3iOAbz8BU/Qv4MAmaPTauwThlxwCDotii+0VBwhmLlkwQH7ypq+lLwSN/w7OgZZHgMNYL6aGAsBj+4VSmk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gsv2se+q; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gsv2se+q" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43624b2d453so58007045e9.2 for ; Tue, 28 Jan 2025 00:05:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738051541; x=1738656341; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=qEMfYzXmSLIgnMJtxwb+i6Gd8d/iSboKcUt4HSkm4vw=; b=gsv2se+qhy/112hYZDKgd5EDkOr8F4BBLakH2jhMiA6UQzjRw9XiYMrOUuUDaMQ9Y3 RptUlttdNbH+Gg7ih/4N1XYfFNlB8aXzmBXh429dOOaMxrcGfjnBpS8qlYrlHOa6wFx1 obS4FCUo8owNau6u/Tyog+VERxUJOv+CudOXIh/iQ83Z1iRYJS+kcnEWltSNXC8rLTG8 PTgoBv9wMYQ/gqbjZ+N/NXwqY0dYx3FycemQrbwI0L61aWmfWqciPKNT6tGxeFJZGD3h VJy8k1Z9b9kdGSpTBINcYQoU2ulz+IBoajFzHcP+zWANpC3ey4hPypJpueaBeHa76/2S FSkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738051541; x=1738656341; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qEMfYzXmSLIgnMJtxwb+i6Gd8d/iSboKcUt4HSkm4vw=; b=DBftRsaxyjWXSHcOG7VKOUctbyrDpVFuBEvIvisz3dH5PA8G4cxxZ0F/CCussbO1QA tXWmSuabW8MgF3R4dF4fm5RfkR49WI9u4CQGGhyikKCXjLaJK6jRl054PJ4+9z577NQb thTOB8rfD0e1BoFt7N2YOgxYLgCD7V6K2qAPUenDWn2eUASbbF+/QM2P4p/lsIPqgBAl 1bMYgAFGciVqmDnBSHujinLALfsXgp0fc4ej22gHvKgSTG+x1Ee7Ic2pmV/Pjf8oT+Mj JrBrGh4pMVN5z6QwuNMhpnEsgtdIVQL+jmgqrkQGboH3juiGM9m8Bvo+hZBLzivfe8Fj pQ7Q== X-Forwarded-Encrypted: i=1; AJvYcCVhSXZnky0AVvVEbO2pntyeNBT54oTPpfiqXTBTxCprK3PNFOJg5vFWOnfirZbQ5tWW3aRjLXycKxDY@vger.kernel.org X-Gm-Message-State: AOJu0YxfXdeCGpnrrFfBTIb0kyGLhonUlBagSWcjTIHRCOVdBZxg8LVx W9sS02vzqV2B9DMIvDU3dmQR9MltOUF7gyesbWiTtD6M/vKXqQxOu3ur9TgwgI4= X-Gm-Gg: ASbGncu57u4204U1Q1mN/iQHRAqx4ChVAx6wWH2eQEadIJtMes4LrhxRaW/igapBFS2 lQTixspSjGNeU1ge48DIskZCqpxQBobCQ8oJTn7TQDatnhFIT5USDeQhisyZR3ahLGuWYBUQRPc fV2Q+iOTw9iqMgQn2eSDCSAvqsNV/E2fAiDM5t33Nk6cV94TuvMfjdWk4XEa538joznYCeT51DF he+mT+FappPJ51wcGbTQeQvy6/Fs+8urkroLXhfKGgxuHooEfuedofLCMIPLAgduNvyIsXPFaAT 9b8Tf1CSiCQpBMwCTAwiqE4DhoY= X-Google-Smtp-Source: AGHT+IEUh1KxWHB9u86+B2/y74R2MigmbSK1pRU1jrbd6wN67RRwueEsOCnR5xhqWQ9cL9gUplaNNg== X-Received: by 2002:a05:600c:8712:b0:434:a802:e9a6 with SMTP id 5b1f17b1804b1-438913ce0b7mr434865235e9.7.1738051541203; Tue, 28 Jan 2025 00:05:41 -0800 (PST) Received: from linaro.org ([2a02:2454:ff21:ef30:3210:3bfd:4b47:59da]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438bd507fe8sm157336445e9.24.2025.01.28.00.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 00:05:40 -0800 (PST) Date: Tue, 28 Jan 2025 09:05:38 +0100 From: Stephan Gerhold To: Luca Weiss Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , Konrad Dybcio , Matti =?iso-8859-1?Q?Lehtim=E4ki?= , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 09/13] ARM: dts: qcom: msm8226: Add modem remoteproc node Message-ID: References: <20250127-msm8226-modem-v3-0-67e968787eef@lucaweiss.eu> <20250127-msm8226-modem-v3-9-67e968787eef@lucaweiss.eu> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250127-msm8226-modem-v3-9-67e968787eef@lucaweiss.eu> On Mon, Jan 27, 2025 at 11:45:41PM +0100, Luca Weiss wrote: > Add a node for the modem remoteproc found on MSM8226. > > Co-developed-by: Matti Lehtimäki > Signed-off-by: Matti Lehtimäki > Signed-off-by: Luca Weiss Reviewed-by: Stephan Gerhold > --- > .../dts/qcom/qcom-apq8026-samsung-milletwifi.dts | 2 + > .../qcom/qcom-msm8226-samsung-matisse-common.dtsi | 6 +- > arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 82 ++++++++++++++++++++++ > arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts | 2 + > 4 files changed, 90 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-milletwifi.dts b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-milletwifi.dts > index 7d519156d91d156d801c477711751aba66cc3224..a8543ca7b5569549418683b6be320784eba1768c 100644 > --- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-milletwifi.dts > +++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-milletwifi.dts > @@ -12,6 +12,8 @@ > #include "pm8226.dtsi" > > /delete-node/ &adsp_region; > +/delete-node/ &mba_region; > +/delete-node/ &mpss_region; > /delete-node/ &smem_region; > > / { > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi > index a15a44fc0181bf23e7531ecdc8978505ca48189d..fbd568c7d6b7415d240aa1a2329d07cf9135274c 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi > +++ b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi > @@ -8,6 +8,8 @@ > #include "pm8226.dtsi" > > /delete-node/ &adsp_region; > +/delete-node/ &mba_region; > +/delete-node/ &mpss_region; > /delete-node/ &smem_region; > > / { > @@ -145,12 +147,12 @@ framebuffer@3200000 { > no-map; > }; > > - mpss@8400000 { > + mpss_region: mpss@8400000 { > reg = <0x08400000 0x1f00000>; > no-map; > }; > > - mba@a300000 { > + mba_region: mba@a300000 { > reg = <0x0a300000 0x100000>; > no-map; > }; > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi > index 7e0838af6c2d0dc26e0082471b70578bc627491d..55bb070dcf489064f5b14902da1acd2762232ef9 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi > +++ b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi > @@ -213,6 +213,18 @@ smem_region: smem@3000000 { > no-map; > }; > > + mpss_region: mpss@8000000 { > + reg = <0x08000000 0x5100000>; > + no-map; > + status = "disabled"; > + }; > + > + mba_region: mba@d100000 { > + reg = <0x0d100000 0x100000>; > + no-map; > + status = "disabled"; > + }; > + > adsp_region: adsp@dc00000 { > reg = <0x0dc00000 0x1900000>; > no-map; > @@ -253,6 +265,31 @@ adsp_smp2p_in: slave-kernel { > }; > }; > > + smp2p-modem { > + compatible = "qcom,smp2p"; > + qcom,smem = <435>, <428>; > + > + interrupt-parent = <&intc>; > + interrupts = ; > + > + mboxes = <&apcs 14>; > + > + qcom,local-pid = <0>; > + qcom,remote-pid = <1>; > + > + modem_smp2p_out: master-kernel { > + qcom,entry-name = "master-kernel"; > + #qcom,smem-state-cells = <1>; > + }; > + > + modem_smp2p_in: slave-kernel { > + qcom,entry-name = "slave-kernel"; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + }; > + > smsm { > compatible = "qcom,smsm"; > #address-cells = <1>; > @@ -879,6 +916,51 @@ spmi_bus: spmi@fc4cf000 { > #interrupt-cells = <4>; > }; > > + modem: remoteproc@fc880000 { > + compatible = "qcom,msm8226-mss-pil"; > + reg = <0xfc880000 0x100>, > + <0xfc820000 0x020>; > + reg-names = "qdsp6", "rmb"; > + > + interrupts-extended = <&intc GIC_SPI 24 IRQ_TYPE_EDGE_RISING>, > + <&modem_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, > + <&modem_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, > + <&modem_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, > + <&modem_smp2p_in 3 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "wdog", "fatal", "ready", "handover", "stop-ack"; > + > + clocks = <&gcc GCC_MSS_Q6_BIMC_AXI_CLK>, > + <&gcc GCC_MSS_CFG_AHB_CLK>, > + <&gcc GCC_BOOT_ROM_AHB_CLK>, > + <&xo_board>; > + clock-names = "iface", "bus", "mem", "xo"; > + > + resets = <&gcc GCC_MSS_RESTART>; > + reset-names = "mss_restart"; > + > + power-domains = <&rpmpd MSM8226_VDDCX>; > + power-domain-names = "cx"; > + > + qcom,ext-bhs-reg = <&tcsr_regs_1 0x194>; > + qcom,halt-regs = <&tcsr_regs_1 0x180 0x200 0x280>; > + > + qcom,smem-states = <&modem_smp2p_out 0>; > + qcom,smem-state-names = "stop"; > + > + memory-region = <&mba_region>, <&mpss_region>; > + > + status = "disabled"; > + > + smd-edge { > + interrupts = ; > + > + mboxes = <&apcs 12>; > + qcom,smd-edge = <0>; > + > + label = "modem"; > + }; > + }; > + > tcsr_mutex: hwlock@fd484000 { > compatible = "qcom,msm8226-tcsr-mutex", "qcom,tcsr-mutex"; > reg = <0xfd484000 0x1000>; > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts > index 3037344eb24055071cc77c9cfce0f1d0f95de921..18396623a91dd4bf4b66f01c1d983c391722f3b5 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts > +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts > @@ -9,6 +9,8 @@ > #include "pm8226.dtsi" > > /delete-node/ &adsp_region; > +/delete-node/ &mba_region; > +/delete-node/ &mpss_region; > /delete-node/ &smem_region; > > / { > > -- > 2.48.1 >