From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Kartik Rajput <kkartik@nvidia.com>,
gregkh@linuxfoundation.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, thierry.reding@gmail.com,
jonathanh@nvidia.com, hvilleneuve@dimonoff.com, arnd@kernel.org,
geert+renesas@glider.be, robert.marko@sartura.hr,
schnelle@linux.ibm.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3 2/2] serial: tegra-utc: Add driver for Tegra UART Trace Controller (UTC)
Date: Thu, 13 Feb 2025 10:09:17 +0200 [thread overview]
Message-ID: <Z62orWpDF5obQZLy@smile.fi.intel.com> (raw)
In-Reply-To: <6f3e6958-25eb-4835-88e1-2d531c892dbe@kernel.org>
On Thu, Feb 13, 2025 at 08:38:15AM +0100, Jiri Slaby wrote:
> On 12. 02. 25, 16:09, Andy Shevchenko wrote:
...
> > > + pending = uart_port_tx(port, c,
> > > + !(tegra_utc_tx_readl(tup, TEGRA_UTC_FIFO_STATUS) & TEGRA_UTC_FIFO_FULL),
> > > + tegra_utc_tx_writel(tup, c, TEGRA_UTC_DATA));
> >
> > Make the last two to reside in temporary variables with self-explanatory names.
>
> Not sure what you mean here? They are needed to be evaluated (read/written)
> in every loop.
Ah, uart_port_tx() is a macro!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-02-13 8:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 10:41 [PATCH v3 0/2] Add support for Tegra UART Trace Controller (UTC) client Kartik Rajput
2025-02-12 10:41 ` [PATCH v3 1/2] dt-bindings: serial: Add bindings for nvidia,tegra264-utc Kartik Rajput
2025-02-13 7:41 ` Krzysztof Kozlowski
2025-02-12 10:41 ` [PATCH v3 2/2] serial: tegra-utc: Add driver for Tegra UART Trace Controller (UTC) Kartik Rajput
2025-02-12 15:09 ` Andy Shevchenko
2025-02-13 7:38 ` Jiri Slaby
2025-02-13 8:09 ` Andy Shevchenko [this message]
2025-02-13 9:05 ` Kartik Rajput
2025-02-13 9:55 ` andriy.shevchenko
2025-02-13 10:11 ` Kartik Rajput
2025-02-13 10:57 ` andriy.shevchenko
2025-02-13 12:28 ` Kartik Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z62orWpDF5obQZLy@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
--cc=schnelle@linux.ibm.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox