From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3555322173E for ; Thu, 13 Feb 2025 13:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739452700; cv=none; b=cPNKBOTX8a90vsd4o5WK2ztLKjrdsHVJLx7GDO8CrasOuvIe7IG3oV4dsuwohEpXVkK5GC6XPyd2aq0+FWf/uEoq/P+drcWNYheTDefm1aqbuPjg/97v8/HI/+egtjZdEerlRbspQAdlsKlTHtPWO8MvJ5fyUJQWrFio1aoyfG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739452700; c=relaxed/simple; bh=VYOekO3BhgmyJ2mRkTHWmdQc7mvwMTx6VCsRCmwif3I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MMBp+1Sp/3G+9CeM0tHPvOOzxq0pkTF+4vXHO4fjZCQuWmlIk6OtyZU3Ix5R/kqnFBeDR5lDHxG1iX2/ccf/dmOLHo+Oin7yiFCBVRa2VxEC+toLec+x9RnH8Thz7JgALIah4If7pinNClHmv7XGcWnOYMwT9mi8Wx1dS/X9dgI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fO/1QNBH; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fO/1QNBH" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4395578be70so9074775e9.2 for ; Thu, 13 Feb 2025 05:18:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739452694; x=1740057494; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FWhe4fmPRfS/OuuLJyzpwpMFHkOJTb48vA//XF7nq9c=; b=fO/1QNBHYu64PUCvliYqzbVO+9vtspSOPymDC4RZwvxk/2ngkxyt5z/MoPfpV139eI zBQlLsTYrhcv8XMHQAmkiU99JE1zT5Mo50pPcGqjgESyrsiMlktaNGpV2nhplgQgbfQ6 iI86K7iDM7vTw+OdMbKFmhDgEotvTfWKdLdyjmJP/UHvK55rR972ko/q5KTIrZjR9LGG mX6fgBsPbSxLlD7LOBwzJRLO1bohK1OmQGtWgQpQla0NDzEAk3RxqSmZ2OkHCQKGk1LQ i1m8xcrKRAT8+TDAzpevtzzsZWZX2RkbTlKggZoJEfOp99QW169iFBsTLd+JBm9nrjqk LE5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739452694; x=1740057494; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FWhe4fmPRfS/OuuLJyzpwpMFHkOJTb48vA//XF7nq9c=; b=DQPbiDiUiU0cW2lWZgoRKfDgOD1wQPi+O3tJ+l6ICoUy4tRyWgNObNqShp4vDGmXuI qNrKeF1nts2NRu/JtOxmOn24m3xegdAeDmEe6yl24Tk/LYxtJFLScD+F1HDsEznl63kc /NZLZy4mKQ7ecoRlO5/s3ZORKB8TCY+nVfBB9oeMmOTHUnF/RIOtRhGysQaRlGJ3+qs2 JhO71E8LrobSgL4OrM4pK0r8fTDTfnPP9p6u9TRBQEZ003kBVAqrHl/Z70qzT2mlUvg8 fNjL8F06woWBRH8wHkkRW90J7ZlVov/+fgZc0EpfyR8D+AwmdDUm5lbUEGe97+5sTsYq 38DA== X-Forwarded-Encrypted: i=1; AJvYcCV1OFEgIJQ2ECsRdAT3g6MfBzu6+YAN81HU1duBUwQYHuy+/3kwI9EV1ytzUBrfb6Kzt/YIGK97SEP/@vger.kernel.org X-Gm-Message-State: AOJu0YxoH64SmowgwaDmoGq+NiBS1xn2npMdM1OGpAoqQVhEHj6KAH9m E4a2hPwxhCd63kdKCTrQ19B7GWxwcsjvx/KR0OglC58fWl5yfgfWXs8g/ba3V3I= X-Gm-Gg: ASbGncvQ0FEFWWJgX6s76jRsR1MyxavS5f2yxEXQYkIpeBsP3BCrDnOEgLmSDxvMhkI QeVCbRmRNl8QhkruOVlH46nE3FGL72NT/rqRCisaB/gLRljcPdM1K35NnTywr2ZrBUM/NVqr7Oj 0dPAhn7WXuqNfyPtlqLZW8o2ReAkSi0qV9m8Ef1HJVmO+/KsbtlBPkMYEl+mPlLHKwgPuScyxp8 aR3vyTaac+Sr0ICt23zYOvQuQxER4S8foVa6KnTWLAgONm6OjA9RruF3JHYfESpzrUcRQvGQ6MW Nr9Wfg1Oie9zzgpQ7aiToRNEswM= X-Google-Smtp-Source: AGHT+IGHqjRAk+WlggZTFqzb819IIhxvnxQcq7g9sio13JgVwPMgDgJww0I8NXCQ3krJi8bYVfB3tQ== X-Received: by 2002:a05:600c:3b92:b0:439:4c83:2b8b with SMTP id 5b1f17b1804b1-439581b192dmr69872385e9.19.1739452694323; Thu, 13 Feb 2025 05:18:14 -0800 (PST) Received: from linaro.org ([2a02:2454:ff21:ef30:5695:683f:dbf5:a2f6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-439618a9b03sm17254135e9.38.2025.02.13.05.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2025 05:18:13 -0800 (PST) Date: Thu, 13 Feb 2025 14:18:09 +0100 From: Stephan Gerhold To: Abel Vesa Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Johan Hovold , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: x1e80100: Add crypto engine Message-ID: References: <20250213-x1e80100-crypto-v1-1-f93afdd4025a@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250213-x1e80100-crypto-v1-1-f93afdd4025a@linaro.org> On Thu, Feb 13, 2025 at 02:44:02PM +0200, Abel Vesa wrote: > On X Elite, there is a crypto engine IP block similar to ones found on > SM8x50 platforms. > > Describe the crypto engine and its BAM. > > Signed-off-by: Abel Vesa > --- > https://lore.kernel.org/all/20250213-dt-bindings-qcom-qce-x1e80100-v1-1-d17ef73a1c12@linaro.org/ > --- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > index 9d38436763432892ceef95daf0335d4cf446357c..5a2c5dd1dc2950b918af23c0939a112cbe47398b 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > @@ -3708,6 +3708,36 @@ pcie4_phy: phy@1c0e000 { > status = "disabled"; > }; > > + cryptobam: dma-controller@1dc4000 { > + compatible = "qcom,bam-v1.7.0"; Hm, I would expect this is at least "qcom,bam-v1.7.4", "qcom,bam-v1.7.0" given that this is a pretty recent SoC. I don't think this makes any functional difference though, and we don't seem to have it on other recent SoCs... > + reg = <0 0x01dc4000 0 0x28000>; > + > + interrupts = ; > + > + #dma-cells = <1>; > + > + iommus = <&apps_smmu 0x480 0>, > + <&apps_smmu 0x481 0>; Should be same as <&apps_smmu 0x480 0x1> (0x1 is applied as mask to the SID, and 0x481 & ~0x1 = 0x480). > + > + qcom,ee = <0>; > + qcom,controlled-remotely; Please add "num-channels" and "qcom,num-ees". Otherwise you risk causing crashes if the interconnect listed below isn't up (anymore) when the driver probes the device. See: https://lore.kernel.org/linux-arm-msm/20250213-x1e80100-crypto-v1-1-f93afdd4025a@linaro.org/T/ > + }; > + > + crypto: crypto@1dfa000 { > + compatible = "qcom,x1e80100-qce", "qcom,sm8150-qce", "qcom,qce"; > + reg = <0 0x01dfa000 0 0x6000>; > + > + interconnects = <&aggre2_noc MASTER_CRYPTO QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; > + interconnect-names = "memory"; > + > + dmas = <&cryptobam 4>, <&cryptobam 5>; > + dma-names = "rx", "tx"; > + > + iommus = <&apps_smmu 0x480 0>, > + <&apps_smmu 0x481 0>; <&apps_smmu 0x480 0x1>; Thanks, Stephan