From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34FE0227EBC for ; Thu, 13 Feb 2025 13:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739452832; cv=none; b=NtCMND4d7oJ7ka2LogzZvbNygY15PlrbpTb4f6QrEIgcN7EG6Vb1gkPHrVN0r1csxZ3DVLR2/LzhYaxZEdIK0092Yzo3+aHxl0KWEn//p0Khxk3f8yEESWUu5at/BOfIsoEwRuiDQCQ83P6JnV9Oj16cl/uZObE7EG6gqVyzpYY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739452832; c=relaxed/simple; bh=5mMVKySb8+gpzJOBAymm9Q7LjgPAm74RfF5CFTTcYUM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dkSdbmPVxY608VxWzWsfUWIY0mKN3nmgk27KQtbkCoRF/mS756yAD6hb/PFgKQiFTymqwcOBX4loq9sQa3TKSLnA9QkGLjd8ye/zUj7Wn3hZ7qe+/5uTn84kzmTi19hvY/tfukeYjQotlbjtM0m5r4Vx63yjeztFzPBdcscBWcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OpUD3bTQ; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OpUD3bTQ" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-38dd14c99c3so395927f8f.3 for ; Thu, 13 Feb 2025 05:20:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739452828; x=1740057628; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CwLioipVK8naZwbwKxpHl8Exj/kHTAEgP/Hsr4XIrU4=; b=OpUD3bTQ3kRN85fqZamyvZOWeCkLAa9MZ/vGRhLsBViPwCcqFwS5ywWBYQzTMZ5XMP OJIWYcvaBJLNn00jyI1AbTHjxT7gDaL4sui+bZWlTMgp3lkkvaRbHWKbrsaUzr8Op6Gu uoQO/0y9Mk6vz3ClY2nevXd+WRv7alXVSRE9uFLPptS16fZIHIkiNmZsBJwBOd86DeDM gp5oUeXLX90eGLjgrtbyYfT4v3npmYXSxderwI2cbhzoj1SYZEeAW2zkSOlIwKuESkC9 U6s8qE+gi4ay+v7WsG+EXcG3naZ2lb/4qlW03mDcOcqWz8VqvM7VAF7z7o6k2qVvVDMI gp9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739452828; x=1740057628; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CwLioipVK8naZwbwKxpHl8Exj/kHTAEgP/Hsr4XIrU4=; b=Z9snza9OZgRMDJTCCseS82y57H1i1bkKlGkHlPxHCkBbQmoUExkSzYKSnGR/hSsGps 7sForsIFyqNJ/oyLr2/Yu6B8eO/royPZez1dZKspU7JqBWa3sezYU5ejsR7LbQ53oVtI AfPokl/Pr9v+qJYPNurwbZ8zTz8fQ1Rk+toEYwwjeVOSmgvBsvjyugkoeTdcWlbOrmwg kQnPCuB9ebxXU85ThiFnYrf9dqDKxIbrwBHJ092k0Gnam2ie5abThCS7sYDviryXw7yM grmlqucdSE8b/S3Bkpl7m5lQRQCh4sZnDYD/BGL/TGseQQC9WWpsGTiY+b4fm0WFktyc eVFA== X-Forwarded-Encrypted: i=1; AJvYcCXZms/c94EEKzPH5rWS/M5t7kE/RDrEhFwrVcE7BXrbsmAMQcbhXN26yTq+ZRn/6C3MOg88qj/42Uyy@vger.kernel.org X-Gm-Message-State: AOJu0Yz1DqOHF21EQVKvSHh5r5DU7VqI1Y8T/qY2YKy+okNXz6b3PMJe pdBm1OBskelJsjXoLVeixaOMuLaTFYlqnzSWLvCwSKkoB5F3EBdTWjWNA8pkyuA= X-Gm-Gg: ASbGncug8c131fHDNIYWI08hFGCwBVo38GLaWmcKTOYVLytjRvbNkO6FfxYUTqBvSj9 IIESTvWwNFGCypT8J3VKNJPJwGApyDTOlbzrvyHHDWLXRSyhWHi7u827RDUCxn3AnuBx3y20Ki4 7ltTwbiP/syoejERVTfkTRcF6c0kEUYFJMfHaethhZWG47qn5gvDzVhQyhdoXj8XCm7kBST4HOM RuJcML3ZwIGTcDvyhw5Yh2bZ1VO2OS3EMmn8S5ygljVIPRUEgbseMVCDViupPd3gI7tZvQHjA+X 121lQk1+D3e7AyjeHO+kSjQVu4A= X-Google-Smtp-Source: AGHT+IHa0iJhUdI7Oeca63Utadvd2nIPWbwBwu9HdjYNmDjYhPAnw2Ag6cr+5vfrRyb7rW16Cvn+DQ== X-Received: by 2002:a05:6000:2aa:b0:38b:da31:3e3e with SMTP id ffacd0b85a97d-38dea28ccf8mr7582277f8f.28.1739452828283; Thu, 13 Feb 2025 05:20:28 -0800 (PST) Received: from linaro.org ([2a02:2454:ff21:ef30:5695:683f:dbf5:a2f6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258ddbb2sm1858848f8f.40.2025.02.13.05.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2025 05:20:27 -0800 (PST) Date: Thu, 13 Feb 2025 14:20:23 +0100 From: Stephan Gerhold To: Abel Vesa Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Johan Hovold , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: x1e80100: Add crypto engine Message-ID: References: <20250213-x1e80100-crypto-v1-1-f93afdd4025a@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 13, 2025 at 02:18:09PM +0100, Stephan Gerhold wrote: > On Thu, Feb 13, 2025 at 02:44:02PM +0200, Abel Vesa wrote: > > On X Elite, there is a crypto engine IP block similar to ones found on > > SM8x50 platforms. > > > > Describe the crypto engine and its BAM. > > > > Signed-off-by: Abel Vesa > > --- > > https://lore.kernel.org/all/20250213-dt-bindings-qcom-qce-x1e80100-v1-1-d17ef73a1c12@linaro.org/ > > --- > > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 30 ++++++++++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > index 9d38436763432892ceef95daf0335d4cf446357c..5a2c5dd1dc2950b918af23c0939a112cbe47398b 100644 > > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > @@ -3708,6 +3708,36 @@ pcie4_phy: phy@1c0e000 { > > status = "disabled"; > > }; > > > > + cryptobam: dma-controller@1dc4000 { > > + compatible = "qcom,bam-v1.7.0"; > > Hm, I would expect this is at least "qcom,bam-v1.7.4", "qcom,bam-v1.7.0" > given that this is a pretty recent SoC. I don't think this makes any > functional difference though, and we don't seem to have it on other > recent SoCs... > > > + reg = <0 0x01dc4000 0 0x28000>; > > + > > + interrupts = ; > > + > > + #dma-cells = <1>; > > + > > + iommus = <&apps_smmu 0x480 0>, > > + <&apps_smmu 0x481 0>; > > Should be same as <&apps_smmu 0x480 0x1> (0x1 is applied as mask to the > SID, and 0x481 & ~0x1 = 0x480). > > > + > > + qcom,ee = <0>; > > + qcom,controlled-remotely; > > Please add "num-channels" and "qcom,num-ees". Otherwise you risk causing > crashes if the interconnect listed below isn't up (anymore) when the > driver probes the device. See: > https://lore.kernel.org/linux-arm-msm/20250213-x1e80100-crypto-v1-1-f93afdd4025a@linaro.org/T/ Sorry, I meant: https://lore.kernel.org/linux-arm-msm/20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org/T/ Oops. Stephan