From: Patrick Wildt <patrick@blueri.se>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Kever Yang <kever.yang@rock-chips.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: add MNT Reform 2
Date: Mon, 10 Feb 2025 23:14:23 +0100 [thread overview]
Message-ID: <Z6p6Pw34JsEa06Gc@windev.fritz.box> (raw)
In-Reply-To: <cd6edfed-08a8-44de-9bfb-5199fd2813fd@kernel.org>
On Thu, Jan 30, 2025 at 01:05:45PM +0100, Krzysztof Kozlowski wrote:
> On 30/01/2025 12:54, Patrick Wildt wrote:
> > + rk806_dvs1_slp: rk806_dvs1_slp {
>
> No underscores in node names. Missing suffix also suggests this fails
> tests, so standard disclaimer:
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
> Maybe you need to update your dtschema and yamllint. Don't rely on
> distro packages for dtschema and be sure you are using the latest
> released dtschema.
Hi Krzysztof,
You were right, I did not know about that; thanks for bringing that to
my attention! I've prepared a v2 that I'll send out now which does seem
to be happy with the schema, and hope fix those issues plus a few more.
Please let me know if there's anything else that I might have missed.
Thanks,
Patrick
next prev parent reply other threads:[~2025-02-10 22:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 11:53 [PATCH 1/2] dt-bindings: arm: rockchip: Add MNT Reform 2 (RCORE) Patrick Wildt
2025-01-30 11:54 ` [PATCH 2/2] arm64: dts: rockchip: add MNT Reform 2 Patrick Wildt
2025-01-30 12:05 ` Krzysztof Kozlowski
2025-02-10 22:14 ` Patrick Wildt [this message]
2025-01-30 23:38 ` [PATCH 1/2] dt-bindings: arm: rockchip: Add MNT Reform 2 (RCORE) Rob Herring (Arm)
2025-01-31 7:42 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6p6Pw34JsEa06Gc@windev.fritz.box \
--to=patrick@blueri.se \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).