From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4767D22424B; Wed, 26 Feb 2025 17:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740590401; cv=none; b=nzfK2Oadu7Hc5doFIcLzSPF0f+hkt4XbtgkJo3UDGzhZh+g4m181EmaoqnScqtyQRBEEKaaHT4lrk4Hqr0pl0MjvhpKhvEzgXM7HD0UjsOop/8bnBJbT4wCZobIUmvQnyJAzhSCdaa/ZEeZwRVuy3E4605oDZeqcCzkf7jnamFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740590401; c=relaxed/simple; bh=iGdWGd+u9Zw8XuMYIbWjrQD+w6VWtvu/cVGoEvur0E0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XxYtghZ87AdQHEKVRAuAH3QEU8/rZ94gX27wkdyRs7fPKgI3hJWcOdc0SsSRW2teigLcsw+HAsSVrPdCFJhkYt13/DEMVsCRDZDRVpLR2Y+AW65oAI/6aPySjbPqmHDD7NWkZJKv6t7p2ovHWz+7ncXv4BqHlWjUpei6EqB42vU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 312EA1516; Wed, 26 Feb 2025 09:20:14 -0800 (PST) Received: from bogus (e133711.arm.com [10.1.196.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4536D3F673; Wed, 26 Feb 2025 09:19:56 -0800 (PST) Date: Wed, 26 Feb 2025 17:19:53 +0000 From: Sudeep Holla To: Rob Herring Cc: "Peng Fan (OSS)" , cristian.marussi@arm.com, Sudeep Holla , saravanak@google.com, krzk+dt@kernel.org, conor+dt@kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [RFC] dt-bindings: firmware: scmi: Introduce compatible string Message-ID: References: <20250226094456.2351571-1-peng.fan@oss.nxp.com> <20250226160945.GA2505223-robh@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250226160945.GA2505223-robh@kernel.org> On Wed, Feb 26, 2025 at 10:09:45AM -0600, Rob Herring wrote: > On Wed, Feb 26, 2025 at 05:44:56PM +0800, Peng Fan (OSS) wrote: > > Quote Sudeep's reply" > > I am not blocking you. What I mentioned is I don't agree that DT can be used > > to resolve this issue, but I don't have time or alternate solution ATM. So > > if you propose DT based solution and the maintainers agree for the proposed > > bindings I will take a look and help you to make that work. But I will raise > > any objections I may have if the proposal has issues mainly around the > > compatibility and ease of maintenance. > > " > > This all looks to me like SCMI has failed to provide common interfaces. > We can look into this if having such common interface can solve this problem. > I'm indifferent. If everyone involved thinks adding compatibles will > solve whatever the issues are, then it's going to be fine with me > (other than the issue above). It doesn't seem like you have that, so I > don't know that I'd keep going down this path. Sorry if I was ambiguous with my stance as quoted above. For me, 2 devices pointing to the same node seems implementation issue rather than fixing/ working around by extending DT bindings like this $subject patch is attempting. If you disagree with that and think 2 devices in the kernel shouldn't point to the same device tree node, then yes I see this is right approach to take. ATM I don't know which is correct and what are other developer's include DT maintainer opinion on this. I just didn't like the way Peng was trying to solve it with some block/allow list which wouldn't have fixed the issue or just created new ones. -- Regards, Sudeep