From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EF2F1B4247; Wed, 19 Feb 2025 20:18:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739996339; cv=none; b=FqbJ15cBu6JDfSg4mvPO2fucy+lFUlCDK9AtavzQztw8J8OQ1JgUEA3e3eIX2L4D923jibvICM9uU6v+bx40am32FX/LPxTZITannj41870nnyH4vASCLxHkKJOUKn+9ldgDO0egfV51A56d1LO3E7NCyCayjYmceFJfM01Bwug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739996339; c=relaxed/simple; bh=oXeGgZ0czwVwUtkAvKWihshapBTjaKnRt7r/lDXjwUg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G/dEnmsOAglL3+olUOgRRtworeDEMhVKXJjN7EXo24F9qSTcByeBQPveedK1N6JXjeAG6xTH7xqMWjoR0DKQot1gAcC0xtAhguTscQNYjEISqbfBnfEaBeJoba+oO8/McdOE8mAYkq7LO0G8ZyyPv51Cl1/Z7rDG/ixKHM4VcfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Q2hpu+3V; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Q2hpu+3V" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739996338; x=1771532338; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=oXeGgZ0czwVwUtkAvKWihshapBTjaKnRt7r/lDXjwUg=; b=Q2hpu+3VcrCRlHkvWLhmtgMWXagzMGN6IzF3XEoSKkB8S75vJPiqrjpV nxyyNpYw5oCMMQ9cQYIpUTjHtazcwPn4b9U24hLvmKoaawcasppXLbMLp 0t/0OK/I34XUOq7tZzzawPehEw4l3q9e1egUczWhDGRcQesFkCUFNNHd2 kirYqC6sJIHEfX5m4vvdundIhE5qMsivBNvvX50+/0JCo9FGMZ+16FJOT UxwW041ZPeMm3OOySCgV/41ImWBgzzr8CqrDmKcxoZvV4GTUvFsy37umT mRX83A5FTcGhWLvpxA8iw95Pg5tOFU7aJ/rVW3CAnFiWkQK9Lrom/tD4T A==; X-CSE-ConnectionGUID: KtbOo9zsTl6ZLs51G89LzA== X-CSE-MsgGUID: SJ245mD+TyeUsZcdq/1PLA== X-IronPort-AV: E=McAfee;i="6700,10204,11350"; a="51734465" X-IronPort-AV: E=Sophos;i="6.13,299,1732608000"; d="scan'208";a="51734465" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2025 12:18:57 -0800 X-CSE-ConnectionGUID: vlRCi91XTOu32FEws8/1Vg== X-CSE-MsgGUID: yYmc9FLARoeVY4knBxElMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,299,1732608000"; d="scan'208";a="138038520" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2025 12:18:52 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tkqWv-0000000D7cB-47Tq; Wed, 19 Feb 2025 22:18:49 +0200 Date: Wed, 19 Feb 2025 22:18:49 +0200 From: Andy Shevchenko To: Svyatoslav Ryhel Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , Lars-Peter Clausen , Pavel Machek , Daniel Thompson , Jingoo Han , Helge Deller , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-leds@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v2 2/2] mfd: lm3533: convert to use OF Message-ID: References: <20250218132702.114669-1-clamor95@gmail.com> <20250218132702.114669-3-clamor95@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Feb 19, 2025 at 07:39:29PM +0200, Svyatoslav Ryhel wrote: > ср, 19 лют. 2025 р. о 17:56 Andy Shevchenko > пише: > > On Wed, Feb 19, 2025 at 05:13:15PM +0200, Svyatoslav Ryhel wrote: > > > ср, 19 лют. 2025 р. о 17:07 Andy Shevchenko > > > пише: > > > > On Wed, Feb 19, 2025 at 04:36:38PM +0200, Svyatoslav Ryhel wrote: > > > > > ср, 19 лют. 2025 р. о 16:27 Andy Shevchenko > > > > > пише: ... > > > > > MFD part is removed since MFD cells binding is unconditional, while > > > > > the device supports any amount of children grater then one. For > > > > > example, my device uses only backlight at bank A, while all other > > > > > subdevices are not present and used. This patch switches to dynamic > > > > > bind of children. > > > > > > > > MFD does the same. Please, take your time and get familiar with how MFD works. > > > > > > It does not. I have tried. If mfd cell binding is missing, driver will > > > complain and fail. > > > > I really don't know what exactly is going on here, you can check it later, but > > I'm 100% sure that MFD works for only driver that are present. What you are > > describing is how component framework is designed. > > > > To proove my words you can check drivers/mfd/intel_soc_pmic_*.c and find listed > > cells that never had a driver in the Linux kernel. They are just placeholders. > > This example is not valid since those drivers do not use device tree. You didn't get the point. I'm telling that it should not matter if there is a device driver present or absent. The rest will be enumerated as usual. I even checked the code that handles of_compatible member from struct mfd_cell and at a brief glance I do not see that it can do otherwise. Care to elaborate what and where is the error happened exactly? -- With Best Regards, Andy Shevchenko