Re: [PATCH v2 2/8] dt-bindings: dsp: fsl,dsp: Add resets property

Daniel Baluta
2025-02-20T13:11:44Z

On Thu, Feb 20, 2025 at 12:37 PM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> Hi,
>
> Am Mittwoch, 19. Februar 2025, 20:20:56 CET schrieb Daniel Baluta:
> > On i.MX8MP we introduced support for using a reset controller
> > to control DSP operation.
> >
> > This patch adds reset property which is required for i.MX8MP.
> >
> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> > ---
> > .../devicetree/bindings/dsp/fsl,dsp.yaml | 19 ++++++++++++++++++-
> > 1 file changed, 18 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> > index ab93ffd3d2e5..923e7f079f1b 100644
> > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> > @@ -82,6 +82,13 @@ properties:
> > description:
> > Phandle to syscon block which provide access for processor enablement
> >
> > + resets:
> > + description:
> > + A pair consisting of phandle to audio-blk-control and an index referencing
> > + the DSP Run/Stall bit in audiomix registers.
> > + See include/dt-bindings/reset/imx8mp-reset-audiomix.h for each index meaning.
> > + maxItems: 1
> > +
> > required:
> > - compatible
> > - reg
> > @@ -164,6 +171,16 @@ allOf:
> > - const: txdb1
> > - const: rxdb0
> > - const: rxdb1
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - fsl,imx8mp-dsp
> > + - fsl,imx8mp-hifi4
> > + then:
> > + required:
> > + - "resets"
> >
> > additionalProperties: false
> >
> > @@ -220,5 +237,5 @@ examples:
> > <&mu2 3 0>;
> > memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>,
> > <&dsp_vdev0vring1>, <&dsp_reserved>;
> > - fsl,dsp-ctrl = <&audio_blk_ctrl>;
> > + resets = <&audio_blk_ctrl IMX8MP_AUDIOMIX_DSP>;
>
> Am I missing something here? fsl,dsp-ctrl is used to get the regmap from syscon.

fsl,dsp-ctrl was used to control the DSP. This functionality for
imx8mp have been now replaced by
using the reset controller.

The example where the diff happens is for imx8mp so for this reason I
changed it to use the
new way of doing the rest.