Re: [PATCH v2 8/8] imx_dsp_rproc: Use reset controller API to control the DSP

Philipp Zabel
2025-02-20T15:45:50Z

On Do, 2025-02-20 at 00:22 +0200, Laurentiu Mihalcea wrote:
>
> On 2/19/2025 9:21 PM, Daniel Baluta wrote:
> > Use the reset controller API to control the DSP on i.MX8MP. This way
> > we can have a better control of the resources and avoid using a syscon
> > to access the audiomix bits.
> >
> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> > Reviewed-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > drivers/remoteproc/imx_dsp_rproc.c | 25 +++++++++++++++++--------
> > drivers/remoteproc/imx_rproc.h | 2 ++
> > 2 files changed, 19 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
> > index ea5024919c2f..631563e4f86d 100644
> > --- a/drivers/remoteproc/imx_dsp_rproc.c
> > +++ b/drivers/remoteproc/imx_dsp_rproc.c
> > @@ -19,6 +19,7 @@
> > #include <linux/pm_runtime.h>
> > #include <linux/regmap.h>
> > #include <linux/remoteproc.h>
> > +#include <linux/reset.h>
> > #include <linux/slab.h>
> >
> > #include "imx_rproc.h"
> > @@ -111,6 +112,7 @@ enum imx_dsp_rp_mbox_messages {
> > */
> > struct imx_dsp_rproc {
> > struct regmap *regmap;
> > + struct reset_control *reset;
>
> Maybe rename this to "stall"? There's also the DAP stuff that's actually used
> to reset the core so this might be a bit confusing?

So Run/Stall does not actually reset anything? Maybe then it should not
be modeled as a reset control. It looks to me like the
DAP_PWRCTL[CORERESET] bit in the Audio Processor Debug region would be
a much better fit.

regards
Philipp