Re: [PATCH v2 2/8] dt-bindings: dsp: fsl,dsp: Add resets property

Frank Li
2025-02-19T21:27:08Z

On Wed, Feb 19, 2025 at 09:20:56PM +0200, Daniel Baluta wrote:
> On i.MX8MP we introduced support for using a reset controller
> to control DSP operation.
>
> This patch adds reset property which is required for i.MX8MP.

Avoid words "this patch" according to kernel submit patch document.

Just said: Add reset property ...

>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> .../devicetree/bindings/dsp/fsl,dsp.yaml | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> index ab93ffd3d2e5..923e7f079f1b 100644
> --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> @@ -82,6 +82,13 @@ properties:
> description:
> Phandle to syscon block which provide access for processor enablement
>
> + resets:
> + description:
> + A pair consisting of phandle to audio-blk-control and an index referencing
> + the DSP Run/Stall bit in audiomix registers.
> + See include/dt-bindings/reset/imx8mp-reset-audiomix.h for each index meaning.

Generally, needn't description for such common property. Or just said
for example, i.MX8MP, ... , because it may change to difference reset
providor in future.

Anyway, I think it is fine leave here.

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> + maxItems: 1
> +
> required:
> - compatible
> - reg
> @@ -164,6 +171,16 @@ allOf:
> - const: txdb1
> - const: rxdb0
> - const: rxdb1
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - fsl,imx8mp-dsp
> + - fsl,imx8mp-hifi4
> + then:
> + required:
> + - "resets"
>
> additionalProperties: false
>
> @@ -220,5 +237,5 @@ examples:
> <&mu2 3 0>;
> memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>,
> <&dsp_vdev0vring1>, <&dsp_reserved>;
> - fsl,dsp-ctrl = <&audio_blk_ctrl>;
> + resets = <&audio_blk_ctrl IMX8MP_AUDIOMIX_DSP>;
> };
> --
> 2.25.1
>