From: Niklas Cassel <cassel@kernel.org>
To: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, michal.simek@amd.com,
bharat.kumar.gogada@amd.com, jingoohan1@gmail.com
Subject: Re: [PATCH v14 0/3] Add support for AMD MDB IP as Root Port
Date: Mon, 24 Feb 2025 14:38:44 +0100 [thread overview]
Message-ID: <Z7x2ZLOiNK4cBCp2@ryzen> (raw)
In-Reply-To: <20250224073117.767210-1-thippeswamy.havalige@amd.com>
On Mon, Feb 24, 2025 at 01:01:14PM +0530, Thippeswamy Havalige wrote:
> This series of patch add support for AMD MDB IP as Root Port.
>
> The AMD MDB IP support's 32 bit and 64bit BAR's at Gen5 speed.
Which PCIe controller does not support 64-bit BARs?
Seems like quite a random sentence IMO.
> As Root Port it supports MSI and legacy interrupts.
You are not submitting Endpoint mode support for your controller,
so it seems a bit weird to talk about "As Root Port ...".
Your patch only includes Root Complex mode, and makes no reference
to Endpoint mode anywhere, so perhaps just state that the controller
supports MSI and INTx interrupts.
Kind regards,
Niklas
prev parent reply other threads:[~2025-02-24 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 7:31 [PATCH v14 0/3] Add support for AMD MDB IP as Root Port Thippeswamy Havalige
2025-02-24 7:31 ` [PATCH v14 1/3] dt-bindings: PCI: dwc: Add AMD Versal2 mdb slcr support Thippeswamy Havalige
2025-02-24 7:31 ` [PATCH v14 2/3] dt-bindings: PCI: amd-mdb: Add AMD Versal2 MDB PCIe Root Port Bridge Thippeswamy Havalige
2025-02-24 7:31 ` [PATCH v14 3/3] PCI: amd-mdb: Add AMD MDB Root Port driver Thippeswamy Havalige
2025-02-24 7:57 ` Krzysztof Kozlowski
2025-02-24 9:59 ` Havalige, Thippeswamy
2025-02-24 9:30 ` Manivannan Sadhasivam
2025-02-24 11:05 ` Havalige, Thippeswamy
2025-02-24 13:12 ` Manivannan Sadhasivam
2025-02-24 15:08 ` Havalige, Thippeswamy
2025-02-25 14:18 ` Havalige, Thippeswamy
2025-02-24 20:03 ` Bjorn Helgaas
2025-02-25 11:46 ` Havalige, Thippeswamy
2025-02-24 13:38 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7x2ZLOiNK4cBCp2@ryzen \
--to=cassel@kernel.org \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).