From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2128.outbound.protection.outlook.com [40.107.117.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 066EF2566C7; Mon, 24 Feb 2025 10:40:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.117.128 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740393609; cv=fail; b=MazkRFY4Lm57IngHI+3WVBA8pgJmM8JmNTP3BOyX7LhfBzgzl52JQ5VWx9N8ZeCEjmEk79gqSvcal9d+Fv12/lcz9RO4lcjk4m6uMlkWnS1bUoarSC5Y6JVsWJPSSb3Lc34D59Q54c0/6PimnuyEUAjoAp0XdfUaHQt8fpIdfOk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740393609; c=relaxed/simple; bh=bn2AZHGvWgIxdGs5AzhtM8YkAQk3iJYg7+o/Zu9uZJ8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Iy/tJlbKaaxTVkVUwpV+Uiv/GFB3ogQz/lzT6K9PsCn6P4GgigLH9he0X3TiMjcKfwLUSO/9IKkfbPj8kWrzpW8hh/YTpNfFA2WAB2M4PrTj4Q6o6+vlvPnwXDocwJ0A3T6sjl/GCwqO2jPsC/idMvUvYmpaXpseSvsKl/ooDkU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cixtech.com; spf=pass smtp.mailfrom=cixtech.com; dkim=pass (2048-bit key) header.d=cixtech.com header.i=@cixtech.com header.b=Bk0hP03e; arc=fail smtp.client-ip=40.107.117.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cixtech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cixtech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cixtech.com header.i=@cixtech.com header.b="Bk0hP03e" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ox08jtdVfH8EqRod2dn6c7HzHlORiCdjaJDXWfNuFC3cDdw0UiKvQNEijlU0Tsm/spCscNx58OIUwN4PC4kzwXXInek/ZuLKCop+mIS+CE99aufM2g/9pFR/zIIP9nqRAIWtDVcVUkAFpfuNA4ObbqyL/yrPZklea98ZArEhvPn68464i7mv+CFiOl0LqpLpT41Iow+GB9Qq6eLi/JgoMauSY6ePVqDuXh+Jx3LRevm+bL3CDX+a2/2JhDBeK4jFmyXz1goCKKtvkUxJwUJv6l4TB5v5SSceBaoFJVSOQ9k7D5s5kAtiHw8aQtZz8RG4vMv+MUTTi1TLnlKNE1KnUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dSwXXP6BNRG345UsPxtpYVjxYEHIPH2f5chGbN0cL38=; b=eYk7RFsBCxPxJx3LOzRWOFew9wxunY7cgm235EJtX2Uz+jZpSqmi3JCJLeRFWiG6FE5TYGOQq9eeJcsek0XF9E5VPMILXp0E//bAou5G9omdece3OdPKmJQrnpqAttjOXiwvHZerjX0TcOMZ+of276r5nsoYk+JLaAOIv4XjDLkuJ5/b8yk1GZdwssyBPikTvzyrw61nUVFbMH23k99kVFhW1A+1cWuawtL2gsg9EQz5VydlHTcv5kRZXpu/buDEXygacUT4jfqmx7rjktbpZToxn6gYsSNtQRjsjYjn7Kt161Sm9q4x1u3hO4N7lQa6Hqh2+CVxjDO/EMcJDgWZ+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 222.71.101.198) smtp.rcpttodomain=arm.com smtp.mailfrom=cixtech.com; dmarc=bestguesspass action=none header.from=cixtech.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cixtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dSwXXP6BNRG345UsPxtpYVjxYEHIPH2f5chGbN0cL38=; b=Bk0hP03e+FnZHnt2F6SJUNhkoC8AGuorqwHtQn1ZBC4OpvETRV29PwES6Z6DBVmGhoc+0rgh08pMpWi5lvESV/3sPdAXPCTUNRkJycjASiaHV9jjRvuUL3Pai9A+yKSPSEKSKPRsFaHvONE2CzWk2u6NEM3PGHQvTZxcHHKXG6fVj87LW2PntYxSzpSBhspilGgSJzyHjCpRAgOH9vHyOPuDFlUu3q1nX7w1Hp8rMj0sXlVlTsqEkBcFjjGX+jV/RTKddmV9dEDbp0b5J+EpSm0f/0JRI5xeR4FOebzf+tJh+ZvBgKR1jBCGoHMNzwfR8Ts2p3DdnW8cj0W3sffR0A== Received: from SG2PR04CA0187.apcprd04.prod.outlook.com (2603:1096:4:14::25) by TYZPR06MB6619.apcprd06.prod.outlook.com (2603:1096:400:451::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.20; Mon, 24 Feb 2025 10:40:02 +0000 Received: from SG2PEPF000B66D0.apcprd03.prod.outlook.com (2603:1096:4:14:cafe::6f) by SG2PR04CA0187.outlook.office365.com (2603:1096:4:14::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8466.20 via Frontend Transport; Mon, 24 Feb 2025 10:40:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 222.71.101.198) smtp.mailfrom=cixtech.com; dkim=none (message not signed) header.d=none;dmarc=bestguesspass action=none header.from=cixtech.com; Received-SPF: Pass (protection.outlook.com: domain of cixtech.com designates 222.71.101.198 as permitted sender) receiver=protection.outlook.com; client-ip=222.71.101.198; helo=smtprelay.cixcomputing.com; pr=C Received: from smtprelay.cixcomputing.com (222.71.101.198) by SG2PEPF000B66D0.mail.protection.outlook.com (10.167.240.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Mon, 24 Feb 2025 10:40:01 +0000 Received: from nchen-desktop (unknown [172.16.64.25]) by smtprelay.cixcomputing.com (Postfix) with ESMTPSA id BC78F4160505; Mon, 24 Feb 2025 18:40:00 +0800 (CST) Date: Mon, 24 Feb 2025 18:39:54 +0800 From: Peter Chen To: Krzysztof Kozlowski Cc: Arnd Bergmann , Rob Herring , krzk+dt@kernel.org, Conor Dooley , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com, "Fugang . duan" Subject: Re: [PATCH 6/6] arm64: dts: cix: add initial CIX P1(SKY1) dts support Message-ID: References: <20250220084020.628704-1-peter.chen@cixtech.com> <20250220084020.628704-7-peter.chen@cixtech.com> <4add2867-8c09-454a-b3e2-b4baaeccfd44@app.fastmail.com> <5f88cdbe-f396-49c6-bb48-f50cbbb21caf@kernel.org> <0bd5af6c-979b-4403-b1e7-5847979a8780@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0bd5af6c-979b-4403-b1e7-5847979a8780@kernel.org> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG2PEPF000B66D0:EE_|TYZPR06MB6619:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ab20a6f-b882-457d-f206-08dd54bf979d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LUf8xSPUqL9/dTXAuFkPSkZ0N/zopa3mdzqjHD56epsL9lVYav/MFNxeJ6Pb?= =?us-ascii?Q?ndeefG8DYPbraPbOqnc/FiaaKv7+vT2dL7ViYROhe+7ZDmfudNwSzeVTwzt4?= =?us-ascii?Q?evs8E1YDk+fH/dJ64SsUN0Yo6edReUF4+nPW+hph2AfV5RsbftSLu7T4hfpu?= =?us-ascii?Q?mBD/6Z95P6eaWBzN14HDoKvjYVamUNJCaZjut7BMot0yHE5mZwgikEWEkHjS?= =?us-ascii?Q?ln+oXPrLbbrGZzItOsOQn6vwyUIYU4NmPxwafsmbs7G9DTboK7RujwXPksu3?= =?us-ascii?Q?bC3lgSoqRGeXk9mZxmhIC2KEaC31NBRlJ6+mMwgtf0u8AjXcfmbR7KVBvSpU?= =?us-ascii?Q?/Xtyd8X4+VRGG5fnob+jkRJ2feoZyxbaEzVpHRhUsVCN79VyrDRdCaqy0Bsi?= =?us-ascii?Q?I0FQmxNjQrVkTUwr4ij4tWWIDOJt7rYLuQmYxrWsY8Wb08ZgsfPxyuQ+kj6r?= =?us-ascii?Q?gFb+az4DqO1tsd9O8kB375Um5JV7J3OVidtQ9uRtCQMm5MYB4hFFmn9nshwe?= =?us-ascii?Q?QvJtBKbFF1nIPkEWahAwd+D72F9O/c2IzckErTNdfiELm/8bQtx/hsV9+d1p?= =?us-ascii?Q?47cxvvAF1LA5zaTLIq7k5neoHb3LhGwJcl9+Kb3UG/k7P2v8RvhNfZTG9kYC?= =?us-ascii?Q?pLoZQ0t1Dekq4ZPJCCx0agmXPynTXw7/SUU8VIF1aRau4z4+6wo+je5eZr+N?= =?us-ascii?Q?ZQ2NAmULovY0Cfabki6XXDvKcwkaZJ4GGPtQ83pQxnqZf/HH2Tww/WpCQOCu?= =?us-ascii?Q?khNbJAAPOXI4FLrDhJva/HOsYpH7mCMiApX3AS9LJO+SDU0dExuaI8TUTpQr?= =?us-ascii?Q?f2b2abMZOokwkBPSJTlcS5QergUjYLON9zTTzkXv3i09qriv0848oF6E8e0n?= =?us-ascii?Q?FCWJNuXzRLIdDwY6eOW/WJQT+HX/LGEDGPE/OtEZZt0648YRRGDjyY3c1yXR?= =?us-ascii?Q?8lHSLaRVgDoaqL6nTLAIdaZKSXlUWjqPCUZtDZF8GgMUE2jGoZl2pu5y3OKu?= =?us-ascii?Q?s8mYk10mWm7lUVVKlV4fp1z4hwOtgfiIQeKuXJNfKrH0SqO32+gNaMPtdMAl?= =?us-ascii?Q?2b3BBk0nNGdBzlfcvn2R3PRX0ukB5k/rVZfRHIXWxzPdUQwvhtxmYPM+MDVX?= =?us-ascii?Q?ndRaUfem3U+zS3esY5lsVhPIpEFWdyHLioRYsxNao+b0sJoWsY1IuH51SM+4?= =?us-ascii?Q?M6zQQFG6RY+Zj0xPCLbiPk3uiMwYxet/ysacrKn6NZv11h/73vk1DJXdpy9v?= =?us-ascii?Q?BHP1edVd8sUyQ+bQpSyfgWbfLvBGC39XhmK/AeMK90ob5Nty5ybUugKcMZem?= =?us-ascii?Q?yi4kwwSAJdEt0885pJ2Th3LZ1DJjrXmoSOj1K3DT8HBzBXiKl5QHc+c5iXuM?= =?us-ascii?Q?7u1aH9l3/LzUCAbOeHsUT2RDcjG/rXRdKPkcyxsx4o1fwLGahT6MIBAZvDu3?= =?us-ascii?Q?pgT3PsfPLJiYrQl32bXjwrFdhFFctqfTQftHM3SaVSjrqIlfNDYwsEs5MAlo?= =?us-ascii?Q?0Gp6ybdgnyCRVOk=3D?= X-Forefront-Antispam-Report: CIP:222.71.101.198;CTRY:CN;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:smtprelay.cixcomputing.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(1800799024)(82310400026);DIR:OUT;SFP:1102; X-OriginatorOrg: cixtech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2025 10:40:01.3957 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0ab20a6f-b882-457d-f206-08dd54bf979d X-MS-Exchange-CrossTenant-Id: 0409f77a-e53d-4d23-943e-ccade7cb4811 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0409f77a-e53d-4d23-943e-ccade7cb4811;Ip=[222.71.101.198];Helo=[smtprelay.cixcomputing.com] X-MS-Exchange-CrossTenant-AuthSource: SG2PEPF000B66D0.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6619 On 25-02-24 09:06:23, Krzysztof Kozlowski wrote: > >> Your "in fact" is not really related to the problem described. If you > >> put it in the correct place, drivers will work just as fine. > > > > You also mentioned that in your comments. Yes, indeed the board dts file > > could remap physical controller index as different board serial number, > > but it is not what we would like to do (at least for CIX platforms). > > In our both HW and SW documents, we have fixed our uart usage cases, > > for example, UART2 as AP serial ports. UART0-UART1 as uart application,eg > > bluetooth. Customer will do their design to follow above rules, and > > it avoids each customer writing this alias at their board file. > > Follow standard rules, you don't get an exception. That's not a property > of the SoC. Okay. I see below documents describes it: Documentation/devicetree/bindings/serial/qcom,msm-uartdm.yaml:23: serialN aliases should be in a .dts file instead of in a .dtsi file. Documentation/devicetree/usage-model.rst:327:at all. The /chosen, /aliases, and /memory nodes are informational > >>> > >>>> > >>>>> + sky1_fixed_clocks: fixed-clocks { > >>>>> + uartclk: uartclk { > >>>>> + compatible = "fixed-clock"; > >>>>> + #clock-cells = <0>; > >>>>> + clock-frequency = <100000000>; > >>>>> + clock-output-names = "uartclk"; > >>>> > >>>>> + uart_apb_pclk: uart_apb_pclk { > >>>>> + compatible = "fixed-clock"; > >>>>> + #clock-cells = <0>; > >>>>> + clock-frequency = <200000000>; > >>>>> + clock-output-names = "apb_pclk"; > >>>> > >>>> > >>>> Clock names don't need "clk" in them, and there should > >>>> be no underscore -- use '-' instead of '_' when separating > >>>> strings in DT. > >>> > >>> Will change to: > >>> uart_apb: clock-uart-apb { > >> > >> No, instead explain why this is part of SoC - or what are you missing > >> here - and use preferred naming. > > > > It is in SoC part, APB clock uses to visit register, and the function > > amba_get_enable_pclk at file drivers/amba/bus.c needs it during uart > > device probes. It uses common Arm uart pl011 IP, the binding doc > > described at: Documentation/devicetree/bindings/serial/pl011.yaml > > So you added fake clock? Everything you wrote is not the reason to add > such clock. Not a fake clock, it is the real clocks, but depends on firmware open their parents and configure their rate. It could let others do their upstream work based on workable console. Which option you would like to accept? - Option-1: use fixed clock in this initial version, and will be replaced later. uart_apb: clock-200000000 { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <200000000>; clock-output-names = "apb_pclk"; }; uart_clk: clock-200000000 { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <100000000>; clock-output-names = "uart_clk"; }; uart2: uart@040d0000 { compatible = "arm,pl011", "arm,primecell"; reg = <0x0 0x040d0000 0x0 0x1000>; interrupts = ; clock-names = "uartclk", "apb_pclk"; clocks = <&uart_clk>, <&uart_apb>; status = "disabled"; }; - Option-2: delete the console uart node and its fixed clock. In that way, the user could boot the kernel at orion-o6 board, but could not use its console. -- Best regards, Peter