[PATCH] ARM: dts: imx31: Use nand-controller as node name

[PATCH] ARM: dts: imx31: Use nand-controller as node name

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

According to mxc-nand.yaml, the correct node name must be
'nand-controller'.

Change it accordingly to fix the following dt-schema warning:

$nodename:0: 'nand@b8000000' does not match '^nand-controller(@.*)?'

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx31.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx31.dtsi b/arch/arm/boot/dts/nxp/imx/imx31.dtsi
index 00006c90d9a7..813a81558c40 100644
--- a/arch/arm/boot/dts/nxp/imx/imx31.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx31.dtsi
@@ -340,7 +340,7 @@ emi@b8000000 { /* External Memory Interface */
 			#address-cells = <1>;
 			#size-cells = <1>;
 
-			nfc: nand@b8000000 {
+			nfc: nand-controller@b8000000 {
 				compatible = "fsl,imx31-nand", "fsl,imx27-nand";
 				reg = <0xb8000000 0x1000>;
 				interrupts = <33>;
-- 
2.34.1

Re: [PATCH] ARM: dts: imx31: Use nand-controller as node name

[Rob Herring (Arm)]

On Thu, 20 Feb 2025 10:03:45 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> According to mxc-nand.yaml, the correct node name must be
> 'nand-controller'.
> 
> Change it accordingly to fix the following dt-schema warning:
> 
> $nodename:0: 'nand@b8000000' does not match '^nand-controller(@.*)?'
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm/boot/dts/nxp/imx/imx31.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/nxp/' for 20250220130345.2375204-1-festevam@gmail.com:

arch/arm/boot/dts/nxp/imx/imx31-bug.dtb: nand-controller@b8000000: #size-cells: 0 was expected
	from schema $id: http://devicetree.org/schemas/mtd/mxc-nand.yaml#
arch/arm/boot/dts/nxp/imx/imx31-bug.dtb: nand-controller@b8000000: compatible:0: 'fsl,imx27-nand' was expected
	from schema $id: http://devicetree.org/schemas/mtd/mxc-nand.yaml#
arch/arm/boot/dts/nxp/imx/imx31-bug.dtb: nand-controller@b8000000: compatible: ['fsl,imx31-nand', 'fsl,imx27-nand'] is too long
	from schema $id: http://devicetree.org/schemas/mtd/mxc-nand.yaml#
arch/arm/boot/dts/nxp/imx/imx31-bug.dtb: nand-controller@b8000000: #size-cells: 0 was expected
	from schema $id: http://devicetree.org/schemas/mtd/nand-controller.yaml#
arch/arm/boot/dts/nxp/imx/imx31-bug.dtb: /soc/emi@b8000000/nand-controller@b8000000: failed to match any schema with compatible: ['fsl,imx31-nand', 'fsl,imx27-nand']
arch/arm/boot/dts/nxp/imx/imx31-lite.dtb: nand-controller@b8000000: #size-cells: 0 was expected
	from schema $id: http://devicetree.org/schemas/mtd/mxc-nand.yaml#
arch/arm/boot/dts/nxp/imx/imx31-lite.dtb: nand-controller@b8000000: compatible:0: 'fsl,imx27-nand' was expected
	from schema $id: http://devicetree.org/schemas/mtd/mxc-nand.yaml#
arch/arm/boot/dts/nxp/imx/imx31-lite.dtb: nand-controller@b8000000: compatible: ['fsl,imx31-nand', 'fsl,imx27-nand'] is too long
	from schema $id: http://devicetree.org/schemas/mtd/mxc-nand.yaml#
arch/arm/boot/dts/nxp/imx/imx31-lite.dtb: nand-controller@b8000000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'clocks', 'compatible', 'dma-names', 'dmas', 'nand-bus-width', 'nand-ecc-mode', 'nand-on-flash-bbt' were unexpected)
	from schema $id: http://devicetree.org/schemas/mtd/mxc-nand.yaml#
arch/arm/boot/dts/nxp/imx/imx31-lite.dtb: nand-controller@b8000000: #size-cells: 0 was expected
	from schema $id: http://devicetree.org/schemas/mtd/nand-controller.yaml#
arch/arm/boot/dts/nxp/imx/imx31-lite.dtb: /soc/emi@b8000000/nand-controller@b8000000: failed to match any schema with compatible: ['fsl,imx31-nand', 'fsl,imx27-nand']

Re: [PATCH] ARM: dts: imx31: Use nand-controller as node name

[Shawn Guo]

On Thu, Feb 20, 2025 at 10:03:45AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> According to mxc-nand.yaml, the correct node name must be
> 'nand-controller'.
> 
> Change it accordingly to fix the following dt-schema warning:
> 
> $nodename:0: 'nand@b8000000' does not match '^nand-controller(@.*)?'
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!

Re: [PATCH] ARM: dts: imx31: Use nand-controller as node name

[Krzysztof Kozlowski]

On 20/02/2025 14:03, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> According to mxc-nand.yaml, the correct node name must be
> 'nand-controller'.
> 
> Change it accordingly to fix the following dt-schema warning:
> 
> $nodename:0: 'nand@b8000000' does not match '^nand-controller(@.*)?'
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm/boot/dts/nxp/imx/imx31.dtsi | 2 +-

Sending one fix per each node name is quite a churn, so please fix all
files in given vendor at once.

Best regards,
Krzysztof