[PATCH 1/1] arm64: dts: im8mq: move dwc3 usb port under ports

[PATCH 1/1] arm64: dts: im8mq: move dwc3 usb port under ports

[Frank Li]

Move port@0 and port@1 under ports to fix below DTB_CHECK warnings.

arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: usb@38100000: port@0:reg:0:0: 0 is less than the minimum of 1
	from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: usb@38100000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'dr_mode', 'phy-names', 'phys', 'port@0', 'port@1', 'snps,parkmode-disable-ss-quirk' were unexpected)
	from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../dts/freescale/imx8mq-librem5-devkit.dts   | 25 +++++++++++--------
 .../boot/dts/freescale/imx8mq-librem5.dtsi    | 25 +++++++++++--------
 2 files changed, 28 insertions(+), 22 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index 9d8e7231b7c63..d9f203c795197 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -979,24 +979,27 @@ &usb3_phy1 {
 };
 
 &usb_dwc3_0 {
-	#address-cells = <1>;
-	#size-cells = <0>;
 	dr_mode = "otg";
 	status = "okay";
 
-	port@0 {
-		reg = <0>;
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
 
-		typec_hs: endpoint {
-			remote-endpoint = <&usb_con_hs>;
+		port@0 {
+			reg = <0>;
+
+			typec_hs: endpoint {
+				remote-endpoint = <&usb_con_hs>;
+			};
 		};
-	};
 
-	port@1 {
-		reg = <1>;
+		port@1 {
+			reg = <1>;
 
-		typec_ss: endpoint {
-			remote-endpoint = <&usb_con_ss>;
+			typec_ss: endpoint {
+				remote-endpoint = <&usb_con_ss>;
+			};
 		};
 	};
 };
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index c19ffa8e8a79a..9e0e2d7271efb 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -1321,25 +1321,28 @@ &usb3_phy1 {
 };
 
 &usb_dwc3_0 {
-	#address-cells = <1>;
-	#size-cells = <0>;
 	dr_mode = "otg";
 	usb-role-switch;
 	status = "okay";
 
-	port@0 {
-		reg = <0>;
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
 
-		typec_hs: endpoint {
-			remote-endpoint = <&usb_con_hs>;
+		port@0 {
+			reg = <0>;
+
+			typec_hs: endpoint {
+				remote-endpoint = <&usb_con_hs>;
+			};
 		};
-	};
 
-	port@1 {
-		reg = <1>;
+		port@1 {
+			reg = <1>;
 
-		typec_ss: endpoint {
-			remote-endpoint = <&usb_con_ss>;
+			typec_ss: endpoint {
+				remote-endpoint = <&usb_con_ss>;
+			};
 		};
 	};
 };
-- 
2.34.1

Re: [PATCH 1/1] arm64: dts: im8mq: move dwc3 usb port under ports

[Rob Herring]

On Mon, Feb 24, 2025 at 1:33 PM Frank Li <Frank.Li@nxp.com> wrote:
>
> Move port@0 and port@1 under ports to fix below DTB_CHECK warnings.
>
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: usb@38100000: port@0:reg:0:0: 0 is less than the minimum of 1
>         from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: usb@38100000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'dr_mode', 'phy-names', 'phys', 'port@0', 'port@1', 'snps,parkmode-disable-ss-quirk' were unexpected)
>         from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../dts/freescale/imx8mq-librem5-devkit.dts   | 25 +++++++++++--------
>  .../boot/dts/freescale/imx8mq-librem5.dtsi    | 25 +++++++++++--------
>  2 files changed, 28 insertions(+), 22 deletions(-)

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 1/1] arm64: dts: im8mq: move dwc3 usb port under ports

[Shawn Guo]

On Mon, Feb 24, 2025 at 02:33:07PM -0500, Frank Li wrote:
> Move port@0 and port@1 under ports to fix below DTB_CHECK warnings.
> 
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: usb@38100000: port@0:reg:0:0: 0 is less than the minimum of 1
> 	from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: usb@38100000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'dr_mode', 'phy-names', 'phys', 'port@0', 'port@1', 'snps,parkmode-disable-ss-quirk' were unexpected)
> 	from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Applied with a change on subject prefix, s/im8mq/im8mq-librem5, thanks!