From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Conor Dooley <conor@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Christophe Roullier <christophe.roullier@st.com>,
Conor Dooley <conor+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org,
Emil Renner Berthing <kernel@esmil.dk>,
Eric Dumazet <edumazet@google.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jakub Kicinski <kuba@kernel.org>,
Jose Abreu <joabreu@synopsys.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Lad,linux-arm-kernel@lists.infradead.org,linux-riscv@lists.infradead.org,linux-stm32@st-md-mailman.stormreply.com,Maxime
Coquelin <mcoquelin.stm32@gmail.com>,Minda Chen
<minda.chen@starfivetech.com>,netdev@vger.kernel.org,Palmer
Dabbelt <palmer@dabbelt.com>,Paolo Abeni
<pabeni@redhat.com>,Paul Walmsley
<paul.walmsley@sifive.com>,Prabhakar"
<prabhakar.csengg@gmail.com>, Rob Herring <robh@kernel.org>,
Samin Guo <samin.guo@starfivetech.com>
Subject: Re: [PATCH net-next 0/7] net: stmmac: deprecate "snps,en-tx-lpi-clockgating" property
Date: Mon, 10 Mar 2025 16:37:29 +0000 [thread overview]
Message-ID: <Z88VST3TIOgzeIyd@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250310-january-sensually-b6b88f7cd1d0@spud>
On Mon, Mar 10, 2025 at 04:35:55PM +0000, Conor Dooley wrote:
> On Sun, Mar 09, 2025 at 03:01:45PM +0000, Russell King (Oracle) wrote:
> > Hi,
> >
> > This series deprecates the "snps,en-tx-lpi-clockgating" property for
> > stmmac.
> >
> > MII Transmit clock gating, where the MAC hardware supports gating this
> > clock, is a function of the connected PHY capabilities, which it
> > reports through its status register.
> >
> > GMAC versions that support transmit clock gating twiddle the LPITCSE
> > bit accordingly in the LPI control/status register, which is handled
> > by the GMAC core specific code.
> >
> > So, "snps,en-tx-lpi-clockgating" not something that is a GMAC property,
> > but is a work-around for phylib not providing an interface to determine
> > whether the PHY allows the transmit clock to be disabled.
> >
> > This series converts the two SoCs that make use of this property (which,
> > I hasten to add, is set in the SoC code) to use the PHY capability bit
> > instead of a DT property, then removes the DT property from the .dtsi,
> > deprecates it in the snps,dwmac binding, and finally in the stmmac code.
> >
>
> > I am expecting some discussion on how to merge this, as I think the
> > order in which these changes is made is important - we don't want to
> > deprecate the old way until the new code has landed.
>
> I'm happy enough to have the jh7110 dtsi change go via netdev, rather
> than sit on till the driver change propagates to my tree in a release's
> time.
Thanks! Could I have a r-b or a-b for it please?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2025-03-10 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-09 15:01 [PATCH net-next 0/7] net: stmmac: deprecate "snps,en-tx-lpi-clockgating" property Russell King (Oracle)
2025-03-09 15:01 ` [PATCH net-next 1/7] net: stmmac: allow platforms to use PHY tx clock stop capability Russell King (Oracle)
2025-03-11 13:20 ` Lad, Prabhakar
2025-03-09 15:01 ` [PATCH net-next 2/7] net: stmmac: starfive: use PHY capability for TX clock stop Russell King (Oracle)
2025-03-09 15:01 ` [PATCH net-next 3/7] net: stmmac: stm32: " Russell King (Oracle)
2025-03-09 15:02 ` [PATCH net-next 4/7] riscv: dts: starfive: remove "snps,en-tx-lpi-clockgating" property Russell King (Oracle)
2025-03-10 16:37 ` Conor Dooley
2025-03-09 15:02 ` [PATCH net-next 5/7] ARM: dts: stm32: " Russell King (Oracle)
2025-03-09 15:02 ` [PATCH net-next 6/7] dt-bindings: deprecate " Russell King (Oracle)
2025-03-10 12:53 ` Rob Herring (Arm)
2025-03-11 13:30 ` Lad, Prabhakar
2025-03-09 15:02 ` [PATCH net-next 7/7] net: stmmac: " Russell King (Oracle)
2025-03-10 16:35 ` [PATCH net-next 0/7] " Conor Dooley
2025-03-10 16:37 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z88VST3TIOgzeIyd@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alex@ghiti.fr \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=christophe.roullier@st.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kernel@esmil.dk \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=prabhakar.csengg@gmail.com \
--cc=robh@kernel.org \
--cc=samin.guo@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).