Re: [PATCH v3 17/17] media: rzg2l-cru: Add support for RZ/G3E SoC

kernel test robot
2025-02-27T22:29:18Z

Hi Tommaso,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.14-rc4 next-20250227]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Tommaso-Merciai/media-dt-bindings-renesas-rzg2l-csi2-Document-Renesas-RZ-V2H-P-SoC/20250226-233919
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20250226152418.1132337-18-tommaso.merciai.xr%40bp.renesas.com
patch subject: [PATCH v3 17/17] media: rzg2l-cru: Add support for RZ/G3E SoC
config: arm-randconfig-001-20250227 (https://download.01.org/0day-ci/archive/20250228/202502280652.KV7uk1gP-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250228/202502280652.KV7uk1gP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502280652.KV7uk1gP-lkp@intel.com/

All warnings (new ones prefixed by >>):

drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c: In function 'rzg3e_cru_get_current_slot':
>> drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:677:65: warning: left shift count >= width of type [-Wshift-count-overflow]
677 | amnmadrs |= ((dma_addr_t)rzg2l_cru_read(cru, AMnMADRSH) << 32);
| ^~
In file included from include/linux/device.h:15,
from include/linux/pm_runtime.h:11,
from drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:16:
>> drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:685:27: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
685 | dev_err(cru->dev, "Invalid MB address 0x%llx (out of range)\n", amnmadrs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:154:56: note: in expansion of macro 'dev_fmt'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:685:9: note: in expansion of macro 'dev_err'
685 | dev_err(cru->dev, "Invalid MB address 0x%llx (out of range)\n", amnmadrs);
| ^~~~~~~
drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:685:52: note: format string is defined here
685 | dev_err(cru->dev, "Invalid MB address 0x%llx (out of range)\n", amnmadrs);
| ~~~^
| |
| long long unsigned int
| %x

vim +677 drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c

664
665 static int rzg3e_cru_get_current_slot(struct rzg2l_cru_dev *cru)
666 {
667 dma_addr_t amnmadrs;
668 unsigned int slot;
669
670 /*
671 * When AMnMADRSL is read, AMnMADRSH of the higher-order
672 * address also latches the address.
673 *
674 * AMnMADRSH must be read after AMnMADRSL has been read.
675 */
676 amnmadrs = rzg2l_cru_read(cru, AMnMADRSL);
> 677 amnmadrs |= ((dma_addr_t)rzg2l_cru_read(cru, AMnMADRSH) << 32);
678
679 /* Ensure amnmadrs is within this buffer range */
680 for (slot = 0; slot < cru->num_buf; slot++)
681 if (amnmadrs >= cru->buf_addr[slot] &&
682 amnmadrs < cru->buf_addr[slot] + cru->format.sizeimage)
683 return slot;
684
> 685 dev_err(cru->dev, "Invalid MB address 0x%llx (out of range)\n", amnmadrs);
686 return -EINVAL;
687 }
688

--
0-DAY CI Kernel Test Service