public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Winchenbach <sam.winchenbach@framepointer.org>
To: kernel test robot <lkp@intel.com>
Cc: linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	oe-kbuild-all@lists.linux.dev, lars@metafoo.de,
	Michael.Hennerich@analog.com, antoniu.miclaus@analog.com,
	jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] iio: filter: admv8818: fix range calculation
Date: Thu, 27 Feb 2025 16:20:32 -0500	[thread overview]
Message-ID: <Z8DXIGxA5mJK0oPN@65YTFL3.secure.tethers.com> (raw)
In-Reply-To: <202502280434.DHtcsf7x-lkp@intel.com>

On Fri, Feb 28, 2025 at 04:23:44AM +0800, kernel test robot wrote:
> Hi Sam,
> 
> kernel test robot noticed the following build errors:
> 
--- snip ---
> >> drivers/iio/filter/admv8818.c:304:34: error: use of undeclared identifier 'lfp_corner_target'; did you mean 'lpf_corner_target'?
>      304 |         ret = __admv8818_lpf_select(st, lfp_corner_target);
>          |                                         ^~~~~~~~~~~~~~~~~
>          |                                         lpf_corner_target
>    drivers/iio/filter/admv8818.c:283:25: note: 'lpf_corner_target' declared here
>      283 |         u64 hpf_corner_target, lpf_corner_target;
>          |                                ^
>    12 warnings and 1 error generated.

Well this is embarassing. I must have have had a fat-finger accident when
inspecting the result of applying the patch to torvalds/master.

I will fix this in v5 once we come to a concensus on the DTS changes.

--- snip ---
>    303	
>  > 304		ret = __admv8818_lpf_select(st, lfp_corner_target);
>    305	exit:
>    306		mutex_unlock(&st->lock);
>    307		return ret;
>    308	}
>    309	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2025-02-27 21:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25 13:46 [PATCH v4 1/2] iio: filter: admv8818: fix range calculation Sam Winchenbach
2025-02-25 13:46 ` [PATCH v4 2/2] dt-bindings: iio: filter: Add lpf/hpf freq margins Sam Winchenbach
2025-02-26  8:03   ` Krzysztof Kozlowski
2025-02-26 17:10     ` Sam Winchenbach
2025-02-26 21:22       ` Krzysztof Kozlowski
2025-02-26 22:16         ` Sam Winchenbach
2025-03-03  8:13           ` Krzysztof Kozlowski
2025-03-03 13:31             ` Sam Winchenbach
2025-03-03 14:16               ` Krzysztof Kozlowski
2025-03-03 14:48                 ` Sam Winchenbach
2025-02-27 20:23 ` [PATCH v4 1/2] iio: filter: admv8818: fix range calculation kernel test robot
2025-02-27 21:20   ` Sam Winchenbach [this message]
2025-03-04 23:55 ` Jonathan Cameron
2025-03-05 12:58   ` Sam Winchenbach
2025-03-08 17:25     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8DXIGxA5mJK0oPN@65YTFL3.secure.tethers.com \
    --to=sam.winchenbach@framepointer.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=antoniu.miclaus@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox