RE: [PATCH v2 1/4] dt-bindings: dma: fsl-edma: add interrupts-extended property

Jacky Bai
2025-03-04T15:41:35Z

> Subject: Re: [PATCH v2 1/4] dt-bindings: dma: fsl-edma: add
> interrupts-extended property
>
> On Tue, Mar 04, 2025 at 05:31:24PM +0800, Jacky Bai wrote:
> > Add interrupts-extended property for edma that has multiple interrupt
> > controllers used.
> >
> > Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> > ---
> > - v2 changes:
> > - newly added entry
> > ---
> > Documentation/devicetree/bindings/dma/fsl,edma.yaml | 11
> ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > index d54140f18d34..549afb8611a9 100644
> > --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > @@ -38,6 +38,10 @@ properties:
> > minItems: 1
> > maxItems: 64
> >
> > + interrupts-extended:
> > + minItems: 1
> > + maxItems: 65
> > +
>
> I suggest add error irq later because optional err-irq patch under review.
> https://lore.kernel.org/imx/20250228-edma_err-v1-0-d1869fe4163e@nxp.c
> om/T/#t
>
> Frank

Ok, need the above patch ready first, then this patch can be dropped, I think.

BR
>
> > interrupt-names:
> > minItems: 1
> > maxItems: 64
> > @@ -87,9 +91,14 @@ required:
> > - "#dma-cells"
> > - compatible
> > - reg
> > - - interrupts
> > - dma-channels
> >
> > +oneOf:
> > + - required:
> > + - interrupts
> > + - required:
> > + - interrupts-extended
> > +
> > allOf:
> > - $ref: dma-controller.yaml#
> > - if:
> > --
> > 2.34.1
> >