From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bayard.4d2.org (bayard.4d2.org [155.254.16.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D82618FDBE; Fri, 7 Mar 2025 06:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=155.254.16.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741329304; cv=none; b=RRNF3mhfq2J0TJIyysrvcBcGERCa07iiUZkDntCi9BpxHw3MNxr5FXxDT0oHstj4wh1MuPzYIMqfB9EKzV5/gH4+JGG6SngVqxqT7ELjFAXqldqRVsdViquGeFsUM9Z4ZRyg0oDEwFB9ZwQXQiMpO+iRtgNlJPQFE21tCcWG8tA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741329304; c=relaxed/simple; bh=D0GUM9vwdTZADtSV9LFCdv8+sJcUQRqRldlU0zdH/Uo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eOWVk8vComdqVx7g928WCqv8piuxg/4M5T0aWBcnwJ1m6hCuQOVWnJoBuyQFhrw870ztoqd6EBT9+jFpq0P1wE12CERco//EJrWRRjs5t6S/nSEZAUW9r/dpOfMKdhD9nzhaFsKDONYa0tF2x9xjhCY32m9YAaIYeM8mpmh1qi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=4d2.org; spf=pass smtp.mailfrom=4d2.org; dkim=pass (2048-bit key) header.d=4d2.org header.i=@4d2.org header.b=I7ZlE6PW; dkim=pass (2048-bit key) header.d=4d2.org header.i=@4d2.org header.b=0oEXldot; arc=none smtp.client-ip=155.254.16.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=4d2.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=4d2.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=4d2.org header.i=@4d2.org header.b="I7ZlE6PW"; dkim=pass (2048-bit key) header.d=4d2.org header.i=@4d2.org header.b="0oEXldot" Received: from bayard.4d2.org (bayard.4d2.org [127.0.0.1]) by bayard.4d2.org (Postfix) with ESMTP id D22E4EC59F6; Thu, 06 Mar 2025 22:35:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=4d2.org; s=mail; t=1741329300; bh=D0GUM9vwdTZADtSV9LFCdv8+sJcUQRqRldlU0zdH/Uo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I7ZlE6PWaawE93M3WiN3Ctu8ZMkfFbWmBZcco7iFTg2miH6Nb7t6zuDELQwrLhCJ/ KQUC1xnD5eXMMcdGsH0BnfKU0iTikfafXQm5phKMnv8ujrxJJv2je7vgEUTLIK16i7 MZ4T8ScsTeFhJ9bdjed/nGuJ14yUCIxq4hPjpq1Jk5D1hJXwCmcgUQMFI5YndozlFd iokjC9YfGJ4zXAFrykQXpdaTc7VwSpsiNLzzTdsNOd5e7pbqRJwiJCpPhmZu9Q3c2P 61GykHhV9N7DDtEKqWYpNUy5cAc4I+f1aVOIHDWxQcoe5EdgrKhoHdoBfdbTDXjXYI TVWt77h5BEhPA== X-Virus-Scanned: amavisd-new at 4d2.org Received: from bayard.4d2.org ([127.0.0.1]) by bayard.4d2.org (bayard.4d2.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZVSd8SIkaOAx; Thu, 6 Mar 2025 22:34:57 -0800 (PST) Received: from ketchup (unknown [183.217.80.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) (Authenticated sender: heylenay@4d2.org) by bayard.4d2.org (Postfix) with ESMTPSA id 1F74EEC59F2; Thu, 06 Mar 2025 22:34:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=4d2.org; s=mail; t=1741329297; bh=D0GUM9vwdTZADtSV9LFCdv8+sJcUQRqRldlU0zdH/Uo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0oEXldotZARGvdAvlWurLFHbM4qjHDcFLotl2vSXHITGYzNoDq/oWYl67NBfdFL5M mW7FREbGrtIrLlKHdHKTsYxw97Bi8T0R0a2q2+P4cicA5l5zl4SCMg5Y8Re6+//8t3 KShp/r8nOMlFxEv09O6jNtAs+SfXb7QyUzQzV1fTwkuhdOgA3WkXJb+NFRKKNRkrPN EmKPs/0fUmUWYg1EitGOvAk9q6MdJ0nw3ccBi8eE8pzOmByj3FEEsrIB4f/vxdcG7y qPVlyWLu9zsqltQLnvs9GVst9O9IrAytpK+/Evs6AUsD6UxFgTkS0v7TpLOtdAek4Q oxDApqq2bPxJw== Date: Fri, 7 Mar 2025 06:34:47 +0000 From: Haylen Chu To: Yixun Lan Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Haylen Chu , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, spacemit@lists.linux.dev, Inochi Amaoto , Chen Wang , Jisheng Zhang , Meng Zhang Subject: Re: [PATCH v5 2/5] dt-bindings: clock: spacemit: Add spacemit,k1-pll Message-ID: References: <20250306175750.22480-2-heylenay@4d2.org> <20250306175750.22480-4-heylenay@4d2.org> <20250307002943-GYA64516@gentoo> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250307002943-GYA64516@gentoo> On Fri, Mar 07, 2025 at 12:29:43AM +0000, Yixun Lan wrote: > Hi Haylen: > > On 17:57 Thu 06 Mar , Haylen Chu wrote: > > Add definition for the PLL found on Spacemit K1 SoC, which takes the > > external 24MHz oscillator as input and generates clocks in various > > frequencies for the system. > > > > Signed-off-by: Haylen Chu > > --- > > .../bindings/clock/spacemit,k1-pll.yaml | 50 +++++++++++++++++++ > > include/dt-bindings/clock/spacemit,k1-ccu.h | 37 ++++++++++++++ > > 2 files changed, 87 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/spacemit,k1-pll.yaml > > > > diff --git a/Documentation/devicetree/bindings/clock/spacemit,k1-pll.yaml b/Documentation/devicetree/bindings/clock/spacemit,k1-pll.yaml > > new file mode 100644 > > index 000000000000..23d7aa1bc573 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/spacemit,k1-pll.yaml > > @@ -0,0 +1,50 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/spacemit,k1-pll.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Spacemit K1 PLL > > + > > +maintainers: > > + - Haylen Chu > > + > > +properties: > > + compatible: > > + const: spacemit,k1-pll > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + description: External 24MHz oscillator > > + > > + spacemit,mpmu: > how about naming it as "spacemit,mpmu-syscon" explicitly? > to indicate this is a syscon phandle, it's more readable It's okay but I'm not sure whether this helps a lot... will wait for the maintainer to decide the name. > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Phandle to the "Main PMU (MPMU)" syscon. It is used to check PLL > > + lock status. > > + > > + "#clock-cells": > > + const: 1 > > + description: > > + See for valid indices. > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - spacemit,mpmu > > + - "#clock-cells" > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + clock-controller@d4090000 { > > + compatible = "spacemit,k1-pll"; > > + reg = <0xd4090000 0x1000>; > > + clocks = <&vctcxo_24m>; > > + spacemit,mpmu = <&sysctl_mpmu>; > > + #clock-cells = <1>; > > + }; > -- ... > Yixun Lan (dlan) > Gentoo Linux Developer > GPG Key ID AABEFD55 Best regards, Haylen Chu