From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3BCA2153DF for ; Fri, 7 Mar 2025 11:07:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741345639; cv=none; b=adgBrYAHPRqI1ynzyZ01Urgv+mzjtjjYxdpabvarSYD7XRAIP/NGJZxt2ow59YwZciw7GBWK/mHaLtNZLcxNG6ycf61i96FayOpL9uUa7FBzfwTUSlViiecw4h4MQ9BEikHMx6BIVbH0FpK5IjPvp7L3TW0cSgLFNeCWMlpZc6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741345639; c=relaxed/simple; bh=HPiNzXTTHqoN0cuKMmWCn9O3pvGZPQvws6UsejGOLII=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LXV+Gz2wDlL3JSYnGzi6AzuWuVuSYk2L2NpmuhS9Larw8YI3mxIC8giBLFwQ5PSINojRL9CiPHE34L64pEwp/s+yiHGDxKhA1GNiO38S4RJt+1fcQfEzmrv/80PD7aFDRUqPCHupF+8d4KL63V+s2bylgKSd+5dZws0eWI5Zz+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bUilmfFz; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bUilmfFz" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-abbd96bef64so264168466b.3 for ; Fri, 07 Mar 2025 03:07:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741345634; x=1741950434; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=yfDn9FH6gBIL3kasCeeYhlqgNKvkAd8JgXjYP0PTb+0=; b=bUilmfFz7vdQaUcWEcIMefdQ8tcllfhalTXjcQuO7pi6omynsQI5WzuXI8lgi0bqpr QLT+jnTdMZAwoioFcNhEQ9/0ciVV6NjsV8S3+8eFtvAD03RsHMnh5szl7QH6+10fCUAL JEN+GkhItbbSUE4ERU5t0Ru6aSIw7x1t5Tr2A/bD1O/eZthgRjsScDyr7YO4zyHWOJLa wxLfM6/QbYCFQhMb0LKdr/2Q09od3wHstqU5ERycaC1JtxQW46LHJlSngNd4JAQO55k3 8wDc41JRhBs+22/US681irq+C/1SE7hjvwAzI4y6er4ZJYYx+rXIY2wC/XkPgCzRZwHi EwCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741345634; x=1741950434; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yfDn9FH6gBIL3kasCeeYhlqgNKvkAd8JgXjYP0PTb+0=; b=vtOlOYIILvQduFNsMa9qjGsQwllEpvBJd0tBWKQpQYqvMbWWbJeCpWwkhTTMCiLOug tXXZD7Zb61S5zpxl3kPbet7FsX2AnF/LGDn/HhYMks+CHS4CIDkhXIq3tAaQUsFhVku3 pj4wg+R8zO2oawRjTODU9RnhYFmpixQJqJwOpowrH172EpAeK1ZdkXWEIaVhXR/fwfF/ 9nmvudH8y+AENWyLQN4UzgWj47OwS9ozh9gq911TL+T260+KONosJOYYAFQDvAUGXREo kekDKT6g0epHin4tFWiGQPt7W4OT/zwM7AR03U5xkuYuFqnICid8AjFyVZZfmGAyzGR1 gCvg== X-Forwarded-Encrypted: i=1; AJvYcCWumHwaUd2QYF27et6IBC278nBhfuWEcX/oCjF1ERCvcSZcOKehZZa0io9cGJgDbSdw9cECylEe2HMV@vger.kernel.org X-Gm-Message-State: AOJu0YwxIRlL7Dk79sWkE/7eQJqp2RBUepO9qVAVDHrIyCpoD5HRFx69 +S5QP4QwJDKL+lSLBbQtUDluvqz6Uci0qKLidoMCQ5hxsD/DhzIXRySdRWIRM/U= X-Gm-Gg: ASbGncvHlT6lVqwpf5sZoDnsbKvuuzJ4tVtGF/Sv4V7hxRfuEaoAU9ornhoOeUOH26j uMacm6KDmQ7a64WibQvgIoJD9Jbv+/RDOQJ8TN0wwA87XtGSgBGsXIvI1+EK1qx0aIWE0xfGTgG g0gPgAiukqzYGX5/zR2AtguFnTzEyGh2kg7BuUx8n6toxcY6vVQHOGHi1tQtwOOvBa7tJT/1zUa i+1xqzWZbDq50WA5If57P821Z1z6dUcKyMom93OO9VMiVkVE2Bm57hBjNtJCwoAJH0uvUMJUAd4 XTfc4fF0jZMAYVSZ3b2hLteXoS0bg3KlJQWIEOE5jZGsp1PD/TOa X-Google-Smtp-Source: AGHT+IGgkdI1f8j3o1gNtZn8e4RQmGqfj9SGVx8IYAmQaeWhqRp49yPnbjkO8kd42BMMr1gZ+zPEWw== X-Received: by 2002:a17:906:f59c:b0:abf:fb7b:8d09 with SMTP id a640c23a62f3a-ac252ed8b2cmr349617466b.51.1741345633855; Fri, 07 Mar 2025 03:07:13 -0800 (PST) Received: from linaro.org ([2a02:2454:ff21:ef30:c140:2ce9:b81:70]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac239481685sm264956366b.58.2025.03.07.03.07.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Mar 2025 03:07:13 -0800 (PST) Date: Fri, 7 Mar 2025 12:07:07 +0100 From: Stephan Gerhold To: Konrad Dybcio Cc: Joerg Roedel , Will Deacon , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Robert Foss , Greg Kroah-Hartman , Wesley Cheng , Christian Marangi , Bjorn Andersson , Rohit Agarwal , Kyle Deng , Vinod Koul , Marijn Suijten , linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Krzysztof Kozlowski , linux-usb@vger.kernel.org, Konrad Dybcio Subject: Re: [PATCH 03/11] dt-bindings: power: qcom,kpss-acc-v2: Add MSM8916 compatible Message-ID: References: <20250306-topic-dt_bindings_fixups-v1-0-0c84aceb0ef9@oss.qualcomm.com> <20250306-topic-dt_bindings_fixups-v1-3-0c84aceb0ef9@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250306-topic-dt_bindings_fixups-v1-3-0c84aceb0ef9@oss.qualcomm.com> On Thu, Mar 06, 2025 at 07:11:15PM +0100, Konrad Dybcio wrote: > From: Konrad Dybcio > > MSM8916 seems to reuse the same hardware as MSM8974 and friends (for > whom this binding document was created). Add a new compatible for it. > > Signed-off-by: Konrad Dybcio > --- > Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > index 202a5d51ee88c7190805efe8f1bf493bdb69ec45..27dae49163fa0790ceb6fda8a5c674f739d4a41a 100644 > --- a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > +++ b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > @@ -18,7 +18,9 @@ description: > > properties: > compatible: > - const: qcom,kpss-acc-v2 > + enum: > + - qcom,msm8916-kpss-acc Hm, MSM8916 doesn't have a *K*PSS (Krait Processor SubSystem), it has an *A*PSS (ARM Cortex – A53 SubSystem, or Application Processor SubSystem). I think this should be either qcom,msm8916-apss-acc, or you just keep the qcom,msm8916-acc we already use. I'm guessing ACC stands for "Application Clock Controller", so it would be unique enough already. There is actually a patch from Rayyan already with a R-b from Krzysztof. Maybe you, or whoever is responsible, can pick it up? https://lore.kernel.org/linux-arm-msm/20240710155226.130086-1-rayyan.ansari@linaro.org/ Thanks, Stephan