From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Benjamin Larsson <benjamin.larsson@genexis.eu>
Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
ansuelsmth@gmail.com, lorenzo@kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH 2/2] serial: Airoha SoC UART and HSUART support
Date: Sat, 22 Mar 2025 23:42:18 +0200 [thread overview]
Message-ID: <Z98uumXXqj_opuTT@surfacebook.localdomain> (raw)
In-Reply-To: <20250209210241.2622309-3-benjamin.larsson@genexis.eu>
Sun, Feb 09, 2025 at 10:02:41PM +0100, Benjamin Larsson kirjoitti:
> Support for Airoha AN7581 SoC UART and HSUART baud rate
> calculation routine.
...
> drivers/tty/serial/8250/8250_port.c | 26 +++++++++
> + /*
> + * Airoha SoCs have custom registers for baud rate settings
> + */
> + if (port->type == PORT_AIROHA)
> + airoha8250_set_baud_rate(port, baud, 0);
> + if (port->type == PORT_AIROHA_HS)
> + airoha8250_set_baud_rate(port, baud, 1);
Why is this here? Please, make it stay in your module.
...
> +config SERIAL_8250_AIROHA
> + bool "Airoha UART support"
Why bool?
> + depends on ARCH_AIROHA && OF && SERIAL_8250
What is the purpose of the OF dependency?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-22 21:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 21:02 [PATCH v4 0/2] Airoha UART support Benjamin Larsson
2025-02-09 21:02 ` [PATCH 1/2] dt-bindings: serial: 8250: Add Airoha compatibles Benjamin Larsson
2025-02-09 21:02 ` [PATCH 2/2] serial: Airoha SoC UART and HSUART support Benjamin Larsson
2025-03-22 21:42 ` Andy Shevchenko [this message]
2025-03-25 14:19 ` Benjamin Larsson
2025-03-25 14:23 ` Andy Shevchenko
2025-02-10 6:14 ` [PATCH v4 0/2] Airoha UART support Greg KH
2025-03-21 20:37 ` Benjamin Larsson
2025-03-22 21:45 ` Andy Shevchenko
2025-03-25 14:45 ` Benjamin Larsson
2025-03-25 14:54 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2025-01-19 13:01 [PATCH v3 " Benjamin Larsson
2025-01-19 13:01 ` [PATCH 2/2] serial: Airoha SoC UART and HSUART support Benjamin Larsson
2025-01-11 13:22 [PATCH v2 0/2] Airoha UART support Benjamin Larsson
2025-01-11 13:22 ` [PATCH 2/2] serial: Airoha SoC UART and HSUART support Benjamin Larsson
2025-01-12 10:54 ` kernel test robot
2025-01-12 13:04 ` kernel test robot
2025-01-05 13:11 [PATCH 0/2] Airoha UART support Benjamin Larsson
2025-01-05 13:11 ` [PATCH 2/2] serial: Airoha SoC UART and HSUART support Benjamin Larsson
2025-01-05 15:59 ` Greg KH
2025-01-05 20:44 ` Benjamin Larsson
2025-01-06 8:09 ` Greg KH
2025-01-06 12:35 ` Benjamin Larsson
2025-01-07 10:44 ` Greg KH
2025-01-06 7:19 ` Krzysztof Kozlowski
2025-01-06 15:58 ` Benjamin Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z98uumXXqj_opuTT@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=ansuelsmth@gmail.com \
--cc=benjamin.larsson@genexis.eu \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=lorenzo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox