From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AE1D254861; Tue, 11 Mar 2025 11:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741693333; cv=none; b=mdodtUZgocFd0TZXWUWUix1xxskq/eUJuE3rKS7vADFKuHSh6YiZ7+HHIwQcmx9QByye1IYKtxQ9sWPhYMlGJ7Xat8Lgqop0IxYK27L7e1T5W7nN9uGFc/FoPry/EGMppFFGAbO/hy1wu+DvUuGY8O2wf4X7uF+LIVHCAB02Mdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741693333; c=relaxed/simple; bh=0cT+g/6WFHRo97S8MzNd/drxoZXKifddanz+n4Uem64=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D83IQBorCdey99LBtEgzsKLMgQqYzkUioOUSVfKOzE35B+SlLJRaxzFGshumYIcVjd99kKlRUyF90LlWRihOjx6R7zTMdJTheQjRTVVPYBKWfw9QXsyqgXZdc3kzz4kUtaYmL10ZB3h9YmS1yxkLGtqd5Je6nZRIufCUgrRS13A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gUXhwXQL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gUXhwXQL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AE5DC4CEEB; Tue, 11 Mar 2025 11:42:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741693332; bh=0cT+g/6WFHRo97S8MzNd/drxoZXKifddanz+n4Uem64=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gUXhwXQLYpC885YJdW2TRx7RUjZm5rSn13EHYURan6o2jQC3pgD+e2hKRnYvENUev IoPstSAUq6ZbXhledQeIrrlmuOGplzdFM1g8h52AMbNS2RN6NK66yvHRSlMg8wX8FO FCPl/kZqLxUF+z1+oPfxJRZo6aRMd0lLFbbrHDqeWeBS5jYgku6BK34y1E8ambTZfo OM2Cy1Z5ZJ8VAZce1vPKhK2/JbXCBZPNeoLJQJ2V7+WW2ethWoFp5rqjolTGskUcSm TQOzVOGlkbYV9Ho9jsztzeW4fkWX8mLb5QS4yKdedn86e7qDzpe615WK+R8unxCa1d RsALeUlcGrUBA== Date: Tue, 11 Mar 2025 12:42:08 +0100 From: Vinod Koul To: Christian Marangi Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Kishon Vijay Abraham I , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , Lorenzo Bianconi , Daniel Danzberger , Arnd Bergmann , Linus Walleij , Nikita Shubin , Guo Ren , Yangyu Chen , Ben Hutchings , Felix Fietkau , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-usb@vger.kernel.org, upstream@airoha.com Subject: Re: [PATCH 10/13] phy: airoha: Add support for Airoha AN7581 USB PHY Message-ID: References: <20250309132959.19045-1-ansuelsmth@gmail.com> <20250309132959.19045-11-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 11-03-25, 12:40, Vinod Koul wrote: > On 09-03-25, 14:29, Christian Marangi wrote: > > Add support for Airoha AN7581 USB PHY driver. AN7581 supports up to 2 > > USB port with USB 2.0 mode always supported and USB 3.0 mode available > > only if the Serdes port is correctly configured for USB 3.0. > > > > On xLate probe, the Serdes mode is validated and the driver return error > > if the Serdes mode doesn't reflect the expected mode. This is required > > as Serdes mode are controlled by the SCU SSR bits and can be either USB > > 3.0 mode or HSGMII or PCIe 2. In such case USB 3.0 won't work. > > > > If the USB 3.0 mode is not supported, the modes needs to be also > > disabled in the xHCI node or the driver will report unsable clock and > > fail probe. Also I dont see phy depends on rest. Please split this and post phy bits separately at least.. -- ~Vinod