From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: tomm.merciai@gmail.com, linux-renesas-soc@vger.kernel.org,
biju.das.jz@bp.renesas.com, Pavel Machek <pavel@denx.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: clock: renesas: Fix description section
Date: Tue, 18 Mar 2025 08:50:41 +0100 [thread overview]
Message-ID: <Z9kl0dnMuar-0cek@tom-desktop> (raw)
In-Reply-To: <CAMuHMdV4SyviVU0+WhgFD_vCO43BQ31tx8az-JihWDAB9EJS+g@mail.gmail.com>
Hi Geert,
Thanks for your review.
On Mon, Mar 17, 2025 at 11:08:19AM +0100, Geert Uytterhoeven wrote:
> Hi Tommaso,
>
> On Mon, 17 Mar 2025 at 09:32, Tommaso Merciai
> <tommaso.merciai.xr@bp.renesas.com> wrote:
> > Remove not needed "and" into description section.
> >
> > Reported-by: Pavel Machek <pavel@denx.de>
> > Closes: https://lore.kernel.org/cip-dev/Z9P%2F51qOlq2B46FK@duo.ucw.cz/
> > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml
> > +++ b/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml
> > @@ -12,7 +12,7 @@ maintainers:
> > description:
> > On Renesas RZ/{G3E,V2H(P)} SoCs, the CPG (Clock Pulse Generator) handles
> > generation and control of clock signals for the IP modules, generation and
> > - control of resets, and control over booting, low power consumption and power
> > + control of resets, control over booting, low power consumption and power
> > supply domains.
> >
> > properties:
>
> I think the original is fine. When emphasizing the structure:
>
> The CPG handles:
> A. generation and control of clock signals for the IP modules,
> B. generation and control of resets, and
> C. control over booting, low power consumption and power supply domains.
>
> i.e. the "and" is part of the typical "A, B, and C" construct?
Fine to me and thanks for the explanation.
If you agree I will drop this in v2.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Thanks & Regards,
Tommaso
next prev parent reply other threads:[~2025-03-18 7:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 8:32 [PATCH 0/3] clk: renesas: rzv2h: Fixes and improvements Tommaso Merciai
2025-03-17 8:32 ` [PATCH 1/3] dt-bindings: clock: renesas: Fix description section Tommaso Merciai
2025-03-17 10:08 ` Geert Uytterhoeven
2025-03-18 7:50 ` Tommaso Merciai [this message]
2025-03-18 8:21 ` Pavel Machek
2025-03-17 8:32 ` [PATCH 2/3] clk: renesas: rzv2h: Improve rzv2h_ddiv_set_rate() Tommaso Merciai
2025-04-09 12:04 ` Geert Uytterhoeven
2025-03-17 8:32 ` [PATCH 3/3] clk: renesas: rzv2h: Simplify rzv2h_cpg_assert()/rzv2h_cpg_deassert() Tommaso Merciai
2025-04-10 16:25 ` Geert Uytterhoeven
2025-04-10 16:33 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9kl0dnMuar-0cek@tom-desktop \
--to=tommaso.merciai.xr@bp.renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pavel@denx.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).