[PATCH] arm64: dts: qcom: x1e001de-devkit: fix USB retimer reset polarity

[PATCH] arm64: dts: qcom: x1e001de-devkit: fix USB retimer reset polarity

[Johan Hovold]

The ps8830 retimer reset is active low.

Fix up the retimer nodes which were based on an early version of the
driver which inverted the polarity.

Fixes: 019e1ee32fec ("arm64: dts: qcom: x1e001de-devkit: Enable external DP support")
Cc: Sibi Sankar <quic_sibis@quicinc.com>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
index f92bda2d34f2..dc1a8f5d485a 100644
--- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
+++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
@@ -788,7 +788,7 @@ typec-mux@8 {
 		vddat-supply = <&vreg_rtmr2_1p15>;
 		vddio-supply = <&vreg_rtmr2_1p8>;
 
-		reset-gpios = <&tlmm 185 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&tlmm 185 GPIO_ACTIVE_LOW>;
 
 		orientation-switch;
 		retimer-switch;
@@ -843,7 +843,7 @@ typec-mux@8 {
 		vddat-supply = <&vreg_rtmr0_1p15>;
 		vddio-supply = <&vreg_rtmr0_1p8>;
 
-		reset-gpios = <&pm8550_gpios 10 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&pm8550_gpios 10 GPIO_ACTIVE_LOW>;
 
 		retimer-switch;
 		orientation-switch;
@@ -898,7 +898,7 @@ typec-mux@8 {
 		vddat-supply = <&vreg_rtmr1_1p15>;
 		vddio-supply = <&vreg_rtmr1_1p8>;
 
-		reset-gpios = <&tlmm 176 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&tlmm 176 GPIO_ACTIVE_LOW>;
 
 		retimer-switch;
 		orientation-switch;
-- 
2.48.1

Re: [PATCH] arm64: dts: qcom: x1e001de-devkit: fix USB retimer reset polarity

[Konrad Dybcio]

On 3/18/25 8:49 AM, Johan Hovold wrote:
> The ps8830 retimer reset is active low.
> 
> Fix up the retimer nodes which were based on an early version of the
> driver which inverted the polarity.
> 
> Fixes: 019e1ee32fec ("arm64: dts: qcom: x1e001de-devkit: Enable external DP support")
> Cc: Sibi Sankar <quic_sibis@quicinc.com>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH] arm64: dts: qcom: x1e001de-devkit: fix USB retimer reset polarity

[Abel Vesa]

On 25-03-18 08:49:07, Johan Hovold wrote:
> The ps8830 retimer reset is active low.
> 
> Fix up the retimer nodes which were based on an early version of the
> driver which inverted the polarity.
> 
> Fixes: 019e1ee32fec ("arm64: dts: qcom: x1e001de-devkit: Enable external DP support")
> Cc: Sibi Sankar <quic_sibis@quicinc.com>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

Reviewed-by: Abel Vesa <abel.vesa@linaro.org>

> ---
>  arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> index f92bda2d34f2..dc1a8f5d485a 100644
> --- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> @@ -788,7 +788,7 @@ typec-mux@8 {
>  		vddat-supply = <&vreg_rtmr2_1p15>;
>  		vddio-supply = <&vreg_rtmr2_1p8>;
>  
> -		reset-gpios = <&tlmm 185 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&tlmm 185 GPIO_ACTIVE_LOW>;
>  
>  		orientation-switch;
>  		retimer-switch;
> @@ -843,7 +843,7 @@ typec-mux@8 {
>  		vddat-supply = <&vreg_rtmr0_1p15>;
>  		vddio-supply = <&vreg_rtmr0_1p8>;
>  
> -		reset-gpios = <&pm8550_gpios 10 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&pm8550_gpios 10 GPIO_ACTIVE_LOW>;
>  
>  		retimer-switch;
>  		orientation-switch;
> @@ -898,7 +898,7 @@ typec-mux@8 {
>  		vddat-supply = <&vreg_rtmr1_1p15>;
>  		vddio-supply = <&vreg_rtmr1_1p8>;
>  
> -		reset-gpios = <&tlmm 176 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&tlmm 176 GPIO_ACTIVE_LOW>;
>  
>  		retimer-switch;
>  		orientation-switch;
> -- 
> 2.48.1
> 

Re: [PATCH] arm64: dts: qcom: x1e001de-devkit: fix USB retimer reset polarity

[Bjorn Andersson]

On Tue, 18 Mar 2025 08:49:07 +0100, Johan Hovold wrote:
> The ps8830 retimer reset is active low.
> 
> Fix up the retimer nodes which were based on an early version of the
> driver which inverted the polarity.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: x1e001de-devkit: fix USB retimer reset polarity
      commit: 1a7646d784513dcf0e8b16c1d9124ef54b4ec5e0

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>