From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A8AC223719; Thu, 20 Mar 2025 10:55:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742468157; cv=none; b=QGqKDbYRW9NgDb2QyEr335dLY7nzh1O+5CHPoOkgwSC7bmZQYKIVMjcyuh5c+GsCobc28Jl3F/itjgU6IvwM5nJV8z28pdTAgNh0F3JERAZIT9BcV30ikjEHqaB9Xcy8MipBzo9J3MaI0LoqlrWSFlsGQoPGiaEYkHl+A/IDqMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742468157; c=relaxed/simple; bh=ykoVgDYABDMVf/SIURuWh0/t3A52YR9TLAY2jzT42IM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P3BnDOpsILfdSqyxDvV+aWwFi0asETo8rEYHfpMD/CXWb4Ux1UBR8W8PpZ46kXHAbDOTGWPUpGk+yNelwjikfmJ04sz6Xh4xJ7SG9N3pI7HIzSV6OL4igss4cHZCkhh5BNk9yl7s/p7MefiA7Nio7RJg5HSEoP+UgzXCPmjClB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jx7P3NC6; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jx7P3NC6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1742468156; x=1774004156; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ykoVgDYABDMVf/SIURuWh0/t3A52YR9TLAY2jzT42IM=; b=jx7P3NC6KtxE2Gq2jdn6GtBtY7+Pnf/YAR9iA2HMuFnSYZWSzV9afNkA 4n4bAyjgr4gnWxgqFlRKA2NnEnNqWtuRkEIoqY8QLRjg+0tgqQo88Jy3N 6jVlRT4awgXEi1aeWpEM/vs1QiG9cpTiRLuxPc0WftF9DVgU4OO4UWQ6N rUTcEPOPtSwJi+m6cXq2cwT4n9ZMwg9LJgX/1l4x62pNWOQmxSpGpWQk+ MukFOFeH+jo83ZpfAWCEdDIGzzLwzPi89tuv0fU1wsIq2V0NRE9plHJQ7 +yiI8PZg1AwhXit271BQVT0nqbj4ZoSmnsRPfcJCvmVncAf0HiC53xaMs A==; X-CSE-ConnectionGUID: 5bxIVbbKQXaIxYgK/kvxBg== X-CSE-MsgGUID: V85bPgqzSAKEuKF6MnvJEQ== X-IronPort-AV: E=McAfee;i="6700,10204,11378"; a="55068172" X-IronPort-AV: E=Sophos;i="6.14,261,1736841600"; d="scan'208";a="55068172" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2025 03:55:54 -0700 X-CSE-ConnectionGUID: vnYLPlG8Rx2+wpea+c4QCw== X-CSE-MsgGUID: mMcbmQb4TJG2lYawul/ePg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,261,1736841600"; d="scan'208";a="122780192" Received: from smile.fi.intel.com ([10.237.72.58]) by orviesa009.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2025 03:55:49 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tvDYw-00000004CRh-2cFn; Thu, 20 Mar 2025 12:55:46 +0200 Date: Thu, 20 Mar 2025 12:55:46 +0200 From: Andy Shevchenko To: Mathieu Dubois-Briand Cc: Michael Walle , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kamel Bouhara , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mark Brown , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-pwm@vger.kernel.org, =?iso-8859-1?Q?Gr=E9gory?= Clement , Thomas Petazzoni Subject: Re: [PATCH v5 06/11] gpio: regmap: Allow to allocate regmap-irq device Message-ID: References: <20250318-mdb-max7360-support-v5-0-fb20baf97da0@bootlin.com> <20250318-mdb-max7360-support-v5-6-fb20baf97da0@bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Mar 20, 2025 at 09:35:15AM +0100, Mathieu Dubois-Briand wrote: > On Wed Mar 19, 2025 at 8:15 AM CET, Michael Walle wrote: ... > > Also, what is the advantage of this? Your caller doesn't have to > > call devm_regmap_add_irq_chip_fwnode(), but on the flip side you > > have to cram all its parameters in the gpio_regmap config. I'd like > > to keep that small and simple (but still extensible!). IMHO just > > setting the irq_domain is enough to achieve that. > > This was a request from Andy on my previous series. The benefit is deduplication of a lot of code. You may consider it the same as GPIO library does with IRQ chip. This is just the same on a different level. Besides the driver in this series, I would think of other GPIO drivers that are not (yet) converted to regmap (partially because of this is being absent) or existing drivers, if any, that may utilise it. -- With Best Regards, Andy Shevchenko