From: Richard Leitner <richard.leitner@linux.dev>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Ladislav Michl <ladis@linux-mips.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Benjamin Bara <benjamin.bara@skidata.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Richard Leitner <richard.leitner@skidata.com>
Subject: Re: [PATCH 3/3] ASoC: maxim,max9867: add "mclk" support
Date: Thu, 2 Mar 2023 13:45:50 +0100 [thread overview]
Message-ID: <ZACafglBa201CUUd@g0hl1n.net> (raw)
In-Reply-To: <b0a5c0c2-dfbd-460a-af0d-c9d498607d72@sirena.org.uk>
On Thu, Mar 02, 2023 at 12:20:18PM +0000, Mark Brown wrote:
> On Thu, Mar 02, 2023 at 12:55:03PM +0100, richard.leitner@linux.dev wrote:
>
> > + max9867->mclk = devm_clk_get(&i2c->dev, "mclk");
> > + if (IS_ERR(max9867->mclk))
> > + return PTR_ERR(max9867->mclk);
> > + ret = clk_prepare_enable(max9867->mclk);
> > + if (ret < 0)
> > + dev_err(&i2c->dev, "Failed to enable MCLK: %d\n", ret);
> > +
>
> Nothing ever disables the clock - we need a disable in the remove path
> at least.
Sure. Sorry for missing that. I will send a v2 later today.
regards;rl
prev parent reply other threads:[~2023-03-02 12:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 11:55 [PATCH 0/3] Add "mclk" support for maxim,max9867 richard.leitner
2023-03-02 11:55 ` [PATCH 1/3] ASoC: dt-bindings: maxim,max9867: convert txt bindings to yaml richard.leitner
2023-03-02 13:05 ` Rob Herring
2023-03-02 14:34 ` Richard Leitner
2023-03-02 13:31 ` Krzysztof Kozlowski
2023-03-02 13:48 ` Richard Leitner
2023-03-02 11:55 ` [PATCH 2/3] ASoC: dt-bindings: maxim,max9867: add "mclk" property richard.leitner
2023-03-02 13:31 ` Krzysztof Kozlowski
2023-03-02 14:56 ` Richard Leitner
2023-03-02 11:55 ` [PATCH 3/3] ASoC: maxim,max9867: add "mclk" support richard.leitner
2023-03-02 12:20 ` Mark Brown
2023-03-02 12:45 ` Claudiu.Beznea
2023-03-02 14:46 ` Richard Leitner
2023-03-03 10:00 ` Claudiu.Beznea
2023-03-02 12:45 ` Richard Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZACafglBa201CUUd@g0hl1n.net \
--to=richard.leitner@linux.dev \
--cc=alsa-devel@alsa-project.org \
--cc=benjamin.bara@skidata.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=ladis@linux-mips.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=richard.leitner@skidata.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).