* Re: [PATCH] phy: Use of_property_present() for testing DT property presence
2023-03-10 14:47 [PATCH] phy: Use of_property_present() for testing DT property presence Rob Herring
@ 2023-03-13 10:26 ` Andre Przywara
2023-03-14 20:03 ` Jernej Škrabec
2023-03-20 11:39 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Andre Przywara @ 2023-03-13 10:26 UTC (permalink / raw)
To: Rob Herring
Cc: Vinod Koul, Kishon Vijay Abraham I, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, devicetree, linux-phy, linux-arm-kernel,
linux-sunxi, linux-kernel
On Fri, 10 Mar 2023 08:47:20 -0600
Rob Herring <robh@kernel.org> wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
(for both:) Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
> drivers/phy/allwinner/phy-sun4i-usb.c | 2 +-
> drivers/phy/broadcom/phy-bcm-ns-usb2.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c
> index fbcd7014ab43..fc9f6fb447a0 100644
> --- a/drivers/phy/allwinner/phy-sun4i-usb.c
> +++ b/drivers/phy/allwinner/phy-sun4i-usb.c
> @@ -758,7 +758,7 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev)
> return PTR_ERR(data->vbus_det_gpio);
> }
>
> - if (of_find_property(np, "usb0_vbus_power-supply", NULL)) {
> + if (of_property_present(np, "usb0_vbus_power-supply")) {
> data->vbus_power_supply = devm_power_supply_get_by_phandle(dev,
> "usb0_vbus_power-supply");
> if (IS_ERR(data->vbus_power_supply)) {
> diff --git a/drivers/phy/broadcom/phy-bcm-ns-usb2.c b/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> index 6a36e187d100..269564bdf687 100644
> --- a/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> +++ b/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> @@ -107,7 +107,7 @@ static int bcm_ns_usb2_probe(struct platform_device *pdev)
> return -ENOMEM;
> usb2->dev = dev;
>
> - if (of_find_property(dev->of_node, "brcm,syscon-clkset", NULL)) {
> + if (of_property_present(dev->of_node, "brcm,syscon-clkset")) {
> usb2->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(usb2->base)) {
> dev_err(dev, "Failed to map control reg\n");
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] phy: Use of_property_present() for testing DT property presence
2023-03-10 14:47 [PATCH] phy: Use of_property_present() for testing DT property presence Rob Herring
2023-03-13 10:26 ` Andre Przywara
@ 2023-03-14 20:03 ` Jernej Škrabec
2023-03-20 11:39 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Jernej Škrabec @ 2023-03-14 20:03 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Chen-Yu Tsai, Samuel Holland,
Rob Herring
Cc: devicetree, linux-phy, linux-arm-kernel, linux-sunxi,
linux-kernel
Dne petek, 10. marec 2023 ob 15:47:20 CET je Rob Herring napisal(a):
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/phy/allwinner/phy-sun4i-usb.c | 2 +-
for sun4i:
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> drivers/phy/broadcom/phy-bcm-ns-usb2.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c
> b/drivers/phy/allwinner/phy-sun4i-usb.c index fbcd7014ab43..fc9f6fb447a0
> 100644
> --- a/drivers/phy/allwinner/phy-sun4i-usb.c
> +++ b/drivers/phy/allwinner/phy-sun4i-usb.c
> @@ -758,7 +758,7 @@ static int sun4i_usb_phy_probe(struct platform_device
> *pdev) return PTR_ERR(data->vbus_det_gpio);
> }
>
> - if (of_find_property(np, "usb0_vbus_power-supply", NULL)) {
> + if (of_property_present(np, "usb0_vbus_power-supply")) {
> data->vbus_power_supply =
devm_power_supply_get_by_phandle(dev,
>
"usb0_vbus_power-supply");
> if (IS_ERR(data->vbus_power_supply)) {
> diff --git a/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> b/drivers/phy/broadcom/phy-bcm-ns-usb2.c index 6a36e187d100..269564bdf687
> 100644
> --- a/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> +++ b/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> @@ -107,7 +107,7 @@ static int bcm_ns_usb2_probe(struct platform_device
> *pdev) return -ENOMEM;
> usb2->dev = dev;
>
> - if (of_find_property(dev->of_node, "brcm,syscon-clkset", NULL)) {
> + if (of_property_present(dev->of_node, "brcm,syscon-clkset")) {
> usb2->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(usb2->base)) {
> dev_err(dev, "Failed to map control reg\n");
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] phy: Use of_property_present() for testing DT property presence
2023-03-10 14:47 [PATCH] phy: Use of_property_present() for testing DT property presence Rob Herring
2023-03-13 10:26 ` Andre Przywara
2023-03-14 20:03 ` Jernej Škrabec
@ 2023-03-20 11:39 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2023-03-20 11:39 UTC (permalink / raw)
To: Rob Herring
Cc: Kishon Vijay Abraham I, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, devicetree, linux-phy, linux-arm-kernel,
linux-sunxi, linux-kernel
On 10-03-23, 08:47, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
Applied, thanks
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/phy/allwinner/phy-sun4i-usb.c | 2 +-
> drivers/phy/broadcom/phy-bcm-ns-usb2.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c
> index fbcd7014ab43..fc9f6fb447a0 100644
> --- a/drivers/phy/allwinner/phy-sun4i-usb.c
> +++ b/drivers/phy/allwinner/phy-sun4i-usb.c
> @@ -758,7 +758,7 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev)
> return PTR_ERR(data->vbus_det_gpio);
> }
>
> - if (of_find_property(np, "usb0_vbus_power-supply", NULL)) {
> + if (of_property_present(np, "usb0_vbus_power-supply")) {
> data->vbus_power_supply = devm_power_supply_get_by_phandle(dev,
> "usb0_vbus_power-supply");
> if (IS_ERR(data->vbus_power_supply)) {
> diff --git a/drivers/phy/broadcom/phy-bcm-ns-usb2.c b/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> index 6a36e187d100..269564bdf687 100644
> --- a/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> +++ b/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> @@ -107,7 +107,7 @@ static int bcm_ns_usb2_probe(struct platform_device *pdev)
> return -ENOMEM;
> usb2->dev = dev;
>
> - if (of_find_property(dev->of_node, "brcm,syscon-clkset", NULL)) {
> + if (of_property_present(dev->of_node, "brcm,syscon-clkset")) {
> usb2->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(usb2->base)) {
> dev_err(dev, "Failed to map control reg\n");
> --
> 2.39.2
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread