From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: "Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Shreeya Patel" <shreeya.patel@collabora.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Jonathan Cameron" <jic23@kernel.org>,
devicetree@vger.kernel.org,
"Zhigang Shi" <Zhigang.Shi@liteon.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Paul Gazzillo" <paul@pgazz.com>,
"Maxime Ripard" <maxime@cerno.tech>,
"Maíra Canal" <mcanal@igalia.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
"Javier Martinez Canillas" <javierm@redhat.com>,
kunit-dev@googlegroups.com, "Stephen Boyd" <sboyd@kernel.org>,
"Emma Anholt" <emma@anholt.net>,
"Liam Beguin" <liambeguin@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Gow" <davidgow@google.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Brendan Higgins" <brendan.higgins@linux.dev>,
"David Airlie" <airlied@gmail.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 0/8] Support ROHM BU27034 ALS sensor
Date: Wed, 22 Mar 2023 12:01:45 +0200 [thread overview]
Message-ID: <ZBrSCYp+QrHK47dS@smile.fi.intel.com> (raw)
In-Reply-To: <cover.1679474247.git.mazziesaccount@gmail.com>
On Wed, Mar 22, 2023 at 11:05:23AM +0200, Matti Vaittinen wrote:
> Revision history:
> v4 => v5: Mostly fixes to review comments from Andy and Jonathan.
> - more accurate change-log in individual patches
> - copy code from DRM test helper instead of moving it to simplify
> merging
1) Why do you think this is a problem?
2) How would we avoid spreading more copies of the same code in the future?
1) Merge conflicts is not a bad thing. It shows that people tested their code
in isolation and stabilized it before submitting to the upper maintainer.
https://yarchive.net/comp/linux/git_merges_from_upstream.html
2) Spreading the same code when we _know_ this, should be very well justified.
Merge conflict is an administrative point, and not a technical obstacle to
avoid.
> - document all exported GTS helpers.
> - inline a few GTS helpers
> - use again Milli lux for the bu27034 with RAW IIO_LIGHT channel and scale
> - Fix bug from added in v4 bu27034 time setting.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-22 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 9:05 [PATCH v5 0/8] Support ROHM BU27034 ALS sensor Matti Vaittinen
2023-03-22 9:06 ` [PATCH v5 3/8] dt-bindings: iio: light: Support ROHM BU27034 Matti Vaittinen
2023-03-22 10:01 ` Andy Shevchenko [this message]
2023-03-22 10:34 ` [PATCH v5 0/8] Support ROHM BU27034 ALS sensor Javier Martinez Canillas
2023-03-22 10:59 ` Matti Vaittinen
2023-03-22 11:02 ` Andy Shevchenko
2023-03-23 9:28 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBrSCYp+QrHK47dS@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Zhigang.Shi@liteon.com \
--cc=airlied@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=daniel@ffwll.ch \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=javierm@redhat.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kunit-dev@googlegroups.com \
--cc=lars@metafoo.de \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=masahiroy@kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=maxime@cerno.tech \
--cc=mazziesaccount@gmail.com \
--cc=mcanal@igalia.com \
--cc=mripard@kernel.org \
--cc=noralf@tronnes.org \
--cc=paul@pgazz.com \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shreeya.patel@collabora.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox