From: Andreas Klinger <ak@it-klinger.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Angel Iglesias <ang.iglesiasg@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: pressure: Honeywell mpr pressure sensor
Date: Thu, 6 Apr 2023 21:43:57 +0200 [thread overview]
Message-ID: <ZC8g/dfMYWZcW4zg@arbad> (raw)
In-Reply-To: <20230401185717.1b971617@jic23-huawei>
Hi Jonathan,
thanks for the extensive review. Most of it is clear but one questions remain.
See below.
Jonathan Cameron <jic23@kernel.org> schrieb am Sa, 01. Apr 18:57:
> > +static void mpr_reset(struct mpr_data *data)
> > +{
> > + if (data->gpiod_reset) {
> > + gpiod_set_value(data->gpiod_reset, 0);
> > + udelay(10);
> > + gpiod_set_value(data->gpiod_reset, 1);
> > + }
>
> If there isn't a reset signal, I'd like to see an attempt at least to write
> all configuration registers to a known value (same as the one you'd
> get after reset).
There is no configuration register in the sensor I could write to. But maybe I
didn't comprehend your point.
Andreas
next prev parent reply other threads:[~2023-04-06 19:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 9:10 [PATCH 2/3] iio: pressure: Honeywell mpr pressure sensor Andreas Klinger
2023-04-01 12:05 ` kernel test robot
2023-04-01 17:57 ` Jonathan Cameron
2023-04-06 19:43 ` Andreas Klinger [this message]
2023-04-08 11:29 ` Jonathan Cameron
2023-04-01 18:29 ` Lars-Peter Clausen
2023-04-02 3:02 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-04-01 9:09 [PATCH 1/3] dt-bindings: iio: pressure: Support Honeywell mpr sensors Andreas Klinger
2023-04-01 9:42 ` Krzysztof Kozlowski
2023-04-01 15:27 ` Jonathan Cameron
2023-04-06 20:15 ` Andreas Klinger
2023-04-07 6:45 ` Krzysztof Kozlowski
2023-04-14 7:27 ` Andreas Klinger
2023-04-14 7:52 ` Krzysztof Kozlowski
2023-04-01 15:22 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC8g/dfMYWZcW4zg@arbad \
--to=ak@it-klinger.de \
--cc=ang.iglesiasg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).