From: Andreas Klinger <ak@it-klinger.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Angel Iglesias <ang.iglesiasg@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: iio: pressure: Support Honeywell mpr sensors
Date: Thu, 6 Apr 2023 22:15:54 +0200 [thread overview]
Message-ID: <ZC8oepuINTaMqN9M@arbad> (raw)
In-Reply-To: <20230401162701.1d3caebc@jic23-huawei>
Hi,
thanks to Krzysztof, Lars-Peter and Jonathan for the review and suggestions. I
have one thing to clarify. See below.
Jonathan Cameron <jic23@kernel.org> schrieb am Sa, 01. Apr 16:27:
> On Sat, 1 Apr 2023 11:42:15 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
> > On 01/04/2023 11:09, Andreas Klinger wrote:
[...]
> > > + honeywell,pmin:
> > > + description:
> > > + Minimum pressure value the sensor can measure in pascal.
> >
> > Use standard unit suffix:
> > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml
> >
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > +
> > > + honeywell,pmax:
> > > + description:
> > > + Maximum pressure value the sensor can measure in pascal.
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> >
> > Same.
> >
> > Why these values are suitable for DT? Does it depend on type of sensor
> > (thus it is implied from compatible) or on system setup?
>
> I think we'll end up with a lot of compatibles, but that's still better
> than free form description. May still need these as well though given
> the datasheet helpfully adds a foot note.
>
> 1. Custom pressure ranges are available.
>
> Might not be worth including all the details though but unhelpfully the
> bits we care about are after details like is the gel food grade or the port long.
> Definitely can ignore the encoding of i2c address / spi in the last few bits but
> may need the transfer function.
>
>
> mpr-0025GA-A maybe as a form?
Just to clarify: There are 32 different pressure ranges and 3 transfer functions
which means we'll end up with 96 compatibles and 96 I2C ids.
Would it be an option to have only one dt compatible and to add the pressure
range as dt property?
e. g.: honeywell,range = "0025PA";
But because of "Custom pressure ranges" we still need the DT properties. In this
case there's another "mpr-custom" compatible, right?
Andreas
next prev parent reply other threads:[~2023-04-06 20:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 9:09 [PATCH 1/3] dt-bindings: iio: pressure: Support Honeywell mpr sensors Andreas Klinger
2023-04-01 9:42 ` Krzysztof Kozlowski
2023-04-01 15:27 ` Jonathan Cameron
2023-04-06 20:15 ` Andreas Klinger [this message]
2023-04-07 6:45 ` Krzysztof Kozlowski
2023-04-14 7:27 ` Andreas Klinger
2023-04-14 7:52 ` Krzysztof Kozlowski
2023-04-01 15:22 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2023-04-01 9:10 [PATCH 2/3] iio: pressure: Honeywell mpr pressure sensor Andreas Klinger
2023-04-01 12:05 ` kernel test robot
2023-04-01 17:57 ` Jonathan Cameron
2023-04-06 19:43 ` Andreas Klinger
2023-04-08 11:29 ` Jonathan Cameron
2023-04-01 18:29 ` Lars-Peter Clausen
2023-04-02 3:02 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC8oepuINTaMqN9M@arbad \
--to=ak@it-klinger.de \
--cc=ang.iglesiasg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).