From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D643C76195 for ; Mon, 27 Mar 2023 20:13:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229971AbjC0UNB (ORCPT ); Mon, 27 Mar 2023 16:13:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229940AbjC0UNA (ORCPT ); Mon, 27 Mar 2023 16:13:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B79B1BDF; Mon, 27 Mar 2023 13:12:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F6C6614E2; Mon, 27 Mar 2023 20:12:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21EF9C433EF; Mon, 27 Mar 2023 20:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679947978; bh=ztuneWnacYJNX61OcSRLH6dtkEQaVL91CZmSDSc+HvA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BGKc7m3TJ1K2Ad+LniE+5DTg+auW75CPse6loLp5HVcL/vZvqbDF9t19XyobR6gzU qE8zqtxoQgi8BOnBQOIYzGcrBan8AgDwAY1AGcKU6dAzqu+Bg99o5POZl8tv0yAJgu G2uzAInEbtj7GrgHfQpKpRWEAV19EvxCo7lt0es5RKzByzgJ7/pkdAAxOqn+sLzqOa dG20RD9sOICkaRFYrBWzyz63wDiXXdcv9ELvhHVpWi+lOJ4rPzAo7nwhSK323biZMb gzjV4Yn13exs+q6DU+ir1A6ToP2zFU6cHj8v5MbWwMF46mS4Fbx3WBsR6hNO7anLBX pAcJw7Ano5gEA== Date: Mon, 27 Mar 2023 20:12:56 +0000 From: Eric Biggers To: Bjorn Andersson Cc: Abel Vesa , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , Manivannan Sadhasivam , Alim Akhtar , Avri Altman , Bart Van Assche , Adrian Hunter , "James E . J . Bottomley" , "Martin K . Petersen" , Herbert Xu , "David S . Miller" , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH v4 4/7] soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver Message-ID: References: <20230327134734.3256974-1-abel.vesa@linaro.org> <20230327134734.3256974-5-abel.vesa@linaro.org> <20230327185358.c4emwquhouq42itf@ripper> <20230327190954.GE73752@sol.localdomain> <20230327192704.ywczpr2otbwxnsh5@ripper> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230327192704.ywczpr2otbwxnsh5@ripper> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Mar 27, 2023 at 12:27:04PM -0700, Bjorn Andersson wrote: > > That's a valid reason that I was looking for. Wouldn't this be a common > problem, something other parts of the stack would like to avoid? > Or it's just a byte array until we get here? > > > It could be done with unaligned memory accesses, though, if you prefer that: > > > > No need to jump through the hoops, but a comment would have saved > (robbed?) me from wondering. The parameter to qcom_ice_program_key() is 'const u8 crypto_key[]', which has no inherent alignment in the type. It might be that the callers currently only pass 4-byte aligned buffers, but I don't think that should be relied on here. - Eric