From: Thierry Reding <thierry.reding@gmail.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Maxim Schwalm <maxim.schwalm@gmail.com>,
Dmitry Osipenko <digetx@gmail.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] ARM: tegra: transformer: use labels for mmc in aliases
Date: Tue, 28 Mar 2023 13:39:05 +0200 [thread overview]
Message-ID: <ZCLR2XYBrOVuJHL3@orome> (raw)
In-Reply-To: <20230304084319.18424-4-clamor95@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]
On Sat, Mar 04, 2023 at 10:43:17AM +0200, Svyatoslav Ryhel wrote:
> Since mmc devices in common dtsi are labeled let's use labels
> for simpler comprehension of tree.
>
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
> arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> index 08ea9cb32d0e..70f7f279fd35 100644
> --- a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> +++ b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> @@ -12,9 +12,9 @@ / {
> chassis-type = "convertible";
>
> aliases {
> - mmc0 = "/mmc@78000600"; /* eMMC */
> - mmc1 = "/mmc@78000000"; /* uSD slot */
> - mmc2 = "/mmc@78000400"; /* WiFi */
> + mmc0 = &sdmmc4; /* eMMC */
> + mmc1 = &sdmmc1; /* uSD slot */
> + mmc2 = &sdmmc3; /* WiFi */
I find it hard to see the improvement here. If you really need this,
please merge this with the patch that adds the labels and add them on an
as-needed basis. That is, if you want to replace the paths by phandle
references here, then introduce the sdmmc{1,3,4} labels, but not the
other ones which aren't used.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-03-28 11:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 8:43 [PATCH v2 0/5] Tegra DTS improvements Svyatoslav Ryhel
2023-03-04 8:43 ` [PATCH v2 1/5] ARM: tegra: Add labels to tegra30.dtsi Svyatoslav Ryhel
2023-03-28 11:27 ` Thierry Reding
2023-03-04 8:43 ` [PATCH v2 2/5] ARM: tegra: Add labels to tegra114.dtsi Svyatoslav Ryhel
2023-03-04 8:43 ` [PATCH v2 3/5] ARM: tegra: transformer: use labels for mmc in aliases Svyatoslav Ryhel
2023-03-28 11:39 ` Thierry Reding [this message]
2023-03-28 12:48 ` Svyatoslav Ryhel
2023-03-04 8:43 ` [PATCH v2 4/5] ARM: tegra: asus-tf101: fix accelerometer mount matrix Svyatoslav Ryhel
2023-03-04 8:43 ` [PATCH v2 5/5] tegra30: peripherals: add 266.5MHz nodes Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCLR2XYBrOVuJHL3@orome \
--to=thierry.reding@gmail.com \
--cc=clamor95@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maxim.schwalm@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).