From: Vinod Koul <vkoul@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 10/12] arm64: dts: qcom: Introduce the SC8180x platform
Date: Tue, 28 Mar 2023 18:43:34 +0530 [thread overview]
Message-ID: <ZCLn/m8GKVo7p/Ga@matsya> (raw)
In-Reply-To: <5ad54197-3638-fc75-02ee-5c285fe4dabb@linaro.org>
On 27-03-23, 10:49, Konrad Dybcio wrote:
> On 27.03.2023 07:38, Vinod Koul wrote:
> > On 25-03-23, 13:34, Konrad Dybcio wrote:
> >>> + cpus {
> >>> + #address-cells = <2>;
> >>> + #size-cells = <0>;
> >>> +
> >>> + CPU0: cpu@0 {
> >>> + device_type = "cpu";
> >>> + compatible = "qcom,kryo485";
> >>> + reg = <0x0 0x0>;
> >> Please add clocks = <&cpufreq_hw n>;
> >>
> >>> + enable-method = "psci";
> >>> + capacity-dmips-mhz = <602>;
> >>> + next-level-cache = <&L2_0>;
> >>> + qcom,freq-domain = <&cpufreq_hw 0>;
> >
> > You mean this or something else?
> Check
>
> https://lore.kernel.org/lkml/20221102065448.GA10650@thinkpad/T/
Good point, thanks
> >>> + compatible = "qcom,sc8180x-camnoc-virt";
> >>> + #interconnect-cells = <2>;
> >>> + qcom,bcm-voters = <&apps_bcm_voter>;
> >>> + };
> >>> +
> >>> + mc_virt: interconnect-mc-virt {
> >> Please be consistent with your naming.
> >
> > Are you referring to adding -0 for this?
> I'm not sure which is preferred (-n vs -name), there's a mixed bag
> upstream.. Krzysztof?
Either ways this should be consistent, so camnoc_virt:
interconnect-camnoc_virt makes sense rather than arbitrary -0
> >>> + compatible = "qcom,sc8180x-mc-virt";
> >>> + #interconnect-cells = <2>;
> >>> + qcom,bcm-voters = <&apps_bcm_voter>;
> >>> + };
> >>> +
> >>> + qup_virt: interconnect-qup-virt {
> >>> + compatible = "qcom,sc8180x-qup-virt";
> >>> + #interconnect-cells = <2>;
> >>> + qcom,bcm-voters = <&apps_bcm_voter>;
> >>> + };
> >>> +
> >> [...]
> >>
> >>> + reserved-memory {
> >>> + #address-cells = <2>;
> >>> + #size-cells = <2>;
> >>> + ranges;
> >>> +
> >>> + hyp_mem: hyp-region@85700000 {
> >> the -region seems a bit unnecessary in all of these nodes
> >
> > This is reserved for hyp, I think we should add it here so that we dont
> > touch this piece..?
> I meant the '-region' bit in the node names
>
> (label: name@unit-address)
ack, thanks for clearing my misunderstanding
--
~Vinod
next prev parent reply other threads:[~2023-03-28 13:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 12:24 [PATCH v2 00/12] Introduce the SC8180x devices Vinod Koul
2023-03-25 12:24 ` [PATCH v2 01/12] dt-bindings: firmware: document Qualcomm SC8180X SCM Vinod Koul
2023-03-25 12:24 ` [PATCH v2 02/12] dt-bindings: PCI: qcom: Document sc8180x properties Vinod Koul
2023-03-27 7:52 ` Krzysztof Kozlowski
2023-03-25 12:24 ` [PATCH v2 03/12] dt-bindings: phy: qcom,qmp-pcie: fix the sc8180x regs Vinod Koul
2023-03-27 7:54 ` Krzysztof Kozlowski
2023-03-25 12:24 ` [PATCH v2 04/12] dt-bindings: usb: qcom,dwc3: Add SC8180x binding Vinod Koul
2023-03-27 7:55 ` Krzysztof Kozlowski
2023-03-28 8:43 ` Vinod Koul
2023-03-25 12:24 ` [PATCH v2 05/12] dt-bindings: interconnect: split SC8180x to own schema Vinod Koul
2023-03-26 14:10 ` Rob Herring
2023-03-28 8:29 ` Vinod Koul
2023-03-25 12:24 ` [PATCH v2 06/12] scsi: ufs: dt-bindings: Add SC8180x binding Vinod Koul
2023-03-27 7:59 ` Krzysztof Kozlowski
2023-03-27 10:19 ` Manivannan Sadhasivam
2023-03-25 12:24 ` [PATCH v2 07/12] dt-bindings: phy: qcom,qmp-ufs: fix the sc8180x regs Vinod Koul
2023-03-27 7:59 ` Krzysztof Kozlowski
2023-03-25 12:24 ` [PATCH v2 08/12] regulator: dt-bindings: qcom,rpmh: Add compatible for PMC8180 Vinod Koul
2023-03-27 8:01 ` Krzysztof Kozlowski
2023-03-25 12:24 ` [PATCH v2 09/12] dt-bindings: qcom,pdc: Add SC8180x compatible Vinod Koul
2023-03-25 12:24 ` [PATCH v2 10/12] arm64: dts: qcom: Introduce the SC8180x platform Vinod Koul
2023-03-25 12:34 ` Konrad Dybcio
2023-03-27 5:38 ` Vinod Koul
2023-03-27 8:49 ` Konrad Dybcio
2023-03-28 13:13 ` Vinod Koul [this message]
2023-03-28 13:15 ` Konrad Dybcio
2023-03-25 12:24 ` [PATCH v2 11/12] arm64: dts: qcom: sc8180x: Introduce Primus Vinod Koul
2023-03-25 12:36 ` Konrad Dybcio
2023-03-27 5:39 ` Vinod Koul
2023-03-27 8:12 ` Krzysztof Kozlowski
2023-03-27 8:14 ` Krzysztof Kozlowski
2023-03-25 12:24 ` [PATCH v2 12/12] arm64: dts: qcom: sc8180x: Introduce Lenovo Flex 5G Vinod Koul
2023-03-25 12:40 ` Konrad Dybcio
2023-03-27 5:43 ` Vinod Koul
2023-03-27 8:51 ` Konrad Dybcio
2023-03-27 14:20 ` Bjorn Andersson
2023-03-27 7:46 ` [PATCH v2 00/12] Introduce the SC8180x devices Krzysztof Kozlowski
2023-03-27 14:12 ` Bjorn Andersson
2023-04-03 15:07 ` (subset) " Mark Brown
2023-04-05 4:09 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCLn/m8GKVo7p/Ga@matsya \
--to=vkoul@kernel.org \
--cc=andersson@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox