From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A91C761AF for ; Wed, 29 Mar 2023 06:44:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229598AbjC2GoG (ORCPT ); Wed, 29 Mar 2023 02:44:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjC2GoF (ORCPT ); Wed, 29 Mar 2023 02:44:05 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E219A1BC0; Tue, 28 Mar 2023 23:44:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 86010B82012; Wed, 29 Mar 2023 06:44:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2128FC433EF; Wed, 29 Mar 2023 06:43:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680072239; bh=nh9FiwEaOwTEBrwBZ6zuJlCaeUs/sVh8B7364nNJ4vw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SDvohtFr983sjS5qsaneARzdF22qBbj0NiFIBh7uVWjHUd4L5CK7uRXWy8hMBmfjo 1sJ98lrgJKJV0kj4b6l5kTzypuRMa6hM3dya/yegS+A2v8BFruiQuKzA3rl/HL0xWo z0Q/0qZ7MqIeY5zktC6CNFBpHSo+uB13cmbNRJGd1bFtsy6plXcqFMETxaU51lazwG 9dEl14BmNUJQkR1R9YqUyjq7UWKsqtriNDE7F/KW0uanhlLgN+zA+ghMvzbBkefZtw yeJ4tMyTwQUQ9u9li921WGFThoaCq8A7gAB/TCvnG2ucqwqbHN7cJRvQn3iDE6vUGo rRAFPmkXdthUQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1phPXa-0004PO-0A; Wed, 29 Mar 2023 08:44:14 +0200 Date: Wed, 29 Mar 2023 08:44:13 +0200 From: Johan Hovold To: Steev Klimaszewski Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Sven Peter , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, Mark Pearson Subject: Re: [PATCH v8 4/4] arm64: dts: qcom: sc8280xp-x13s: Add bluetooth Message-ID: References: <20230326233812.28058-1-steev@kali.org> <20230326233812.28058-5-steev@kali.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230326233812.28058-5-steev@kali.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Mar 26, 2023 at 06:38:12PM -0500, Steev Klimaszewski wrote: > The Lenovo Thinkpad X13s has a WCN6855 Bluetooth controller on uart2, > add this. > > Signed-off-by: Steev Klimaszewski > --- > Changes since v7: > * Drop regulator now in a different patchset from Johan > * Fix alphabetization > > Changes since v6: > * Remove allowed-modes as they aren't needed > * Remove regulator-allow-set-load > * Set regulator-always-on because the wifi chip also uses the regulator > * cts pin uses bias-bus-hold > * Alphabetize uart2 pins > > Changes since v5: > * Update patch subject > * Specify initial mode (via guess) for vreg_s1c > * Drop uart17 definition > * Rename bt_en to bt_default because configuring more than one pin > * Correct (maybe) bias configurations > * Correct cts gpio > * Split rts-tx into two nodes > * Drop incorrect link in the commit message > > Changes since v4: > * Address Konrad's review comments. > > Changes since v3: > * Add vreg_s1c > * Add regulators and not dead code > * Fix commit message changelog > > Changes since v2: > * Remove dead code and add TODO comment > * Make dtbs_check happy with the pin definitions Looks like we're good to go now. Thanks for sticking with it. Reviewed-by: Johan Hovold Tested-by: Johan Hovold Johan