* [PATCH] dt-bindings: usb: tps6598x: make interrupts optional
[not found] <20230324131853.41102-1-rogerq@kernel.org>
@ 2023-03-24 13:37 ` Roger Quadros
2023-03-29 7:05 ` Roger Quadros
0 siblings, 1 reply; 4+ messages in thread
From: Roger Quadros @ 2023-03-24 13:37 UTC (permalink / raw)
To: heikki.krogerus, gregkh, robh+dt
Cc: vigneshr, srk, r-gunasekaran, linux-usb, linux-kernel, devicetree,
Roger Quadros
The driver can poll for interrupt status so interrupts
can be optional. It is still recommended to use the
interrupt line. Polling should only be used for debug
and prototyping.
Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 2 --
1 file changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
index 348a715d61f4..8c2db282735a 100644
--- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
+++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
@@ -35,8 +35,6 @@ properties:
required:
- compatible
- reg
- - interrupts
- - interrupt-names
additionalProperties: true
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: usb: tps6598x: make interrupts optional
2023-03-24 13:37 ` [PATCH] dt-bindings: usb: tps6598x: make interrupts optional Roger Quadros
@ 2023-03-29 7:05 ` Roger Quadros
2023-03-29 10:43 ` Heikki Krogerus
2023-03-31 18:55 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Roger Quadros @ 2023-03-29 7:05 UTC (permalink / raw)
To: heikki.krogerus, gregkh, robh+dt
Cc: vigneshr, srk, r-gunasekaran, linux-usb, linux-kernel, devicetree
Hi Heikki & Rob,
On 24/03/2023 15:37, Roger Quadros wrote:
> The driver can poll for interrupt status so interrupts
> can be optional. It is still recommended to use the
> interrupt line. Polling should only be used for debug
> and prototyping.
>
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
> Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> index 348a715d61f4..8c2db282735a 100644
> --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> @@ -35,8 +35,6 @@ properties:
> required:
> - compatible
> - reg
> - - interrupts
> - - interrupt-names
>
> additionalProperties: true
>
We need this patch as well along with the driver changes [1]
Could you please Ack. Thanks!
[1] - https://lore.kernel.org/r/20230324131853.41102-1-rogerq@kernel.org
cheers,
-roger
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: usb: tps6598x: make interrupts optional
2023-03-29 7:05 ` Roger Quadros
@ 2023-03-29 10:43 ` Heikki Krogerus
2023-03-31 18:55 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2023-03-29 10:43 UTC (permalink / raw)
To: Roger Quadros
Cc: gregkh, robh+dt, vigneshr, srk, r-gunasekaran, linux-usb,
linux-kernel, devicetree
On Wed, Mar 29, 2023 at 10:05:33AM +0300, Roger Quadros wrote:
> Hi Heikki & Rob,
>
> On 24/03/2023 15:37, Roger Quadros wrote:
> > The driver can poll for interrupt status so interrupts
> > can be optional. It is still recommended to use the
> > interrupt line. Polling should only be used for debug
> > and prototyping.
> >
> > Signed-off-by: Roger Quadros <rogerq@kernel.org>
> > ---
> > Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> > index 348a715d61f4..8c2db282735a 100644
> > --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> > +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> > @@ -35,8 +35,6 @@ properties:
> > required:
> > - compatible
> > - reg
> > - - interrupts
> > - - interrupt-names
> >
> > additionalProperties: true
> >
>
> We need this patch as well along with the driver changes [1]
> Could you please Ack. Thanks!
I can give my ack FWIW, but we should still wait for Rob.
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
thanks,
--
heikki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: usb: tps6598x: make interrupts optional
2023-03-29 7:05 ` Roger Quadros
2023-03-29 10:43 ` Heikki Krogerus
@ 2023-03-31 18:55 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2023-03-31 18:55 UTC (permalink / raw)
To: Roger Quadros
Cc: heikki.krogerus, gregkh, vigneshr, srk, r-gunasekaran, linux-usb,
linux-kernel, devicetree
On Wed, Mar 29, 2023 at 10:05:33AM +0300, Roger Quadros wrote:
> Hi Heikki & Rob,
>
> On 24/03/2023 15:37, Roger Quadros wrote:
> > The driver can poll for interrupt status so interrupts
> > can be optional. It is still recommended to use the
> > interrupt line. Polling should only be used for debug
> > and prototyping.
> >
> > Signed-off-by: Roger Quadros <rogerq@kernel.org>
> > ---
> > Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> > index 348a715d61f4..8c2db282735a 100644
> > --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> > +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> > @@ -35,8 +35,6 @@ properties:
> > required:
> > - compatible
> > - reg
> > - - interrupts
> > - - interrupt-names
> >
> > additionalProperties: true
> >
>
> We need this patch as well along with the driver changes [1]
> Could you please Ack. Thanks!
If get_maintainers.pl had been properly used, then it probably would
have been acked by Krzysztof already. Otherwise, it's in my queue if the
DT list is copied.
Acked-by: Rob Herring <robh@kernel.org>
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-31 18:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230324131853.41102-1-rogerq@kernel.org>
2023-03-24 13:37 ` [PATCH] dt-bindings: usb: tps6598x: make interrupts optional Roger Quadros
2023-03-29 7:05 ` Roger Quadros
2023-03-29 10:43 ` Heikki Krogerus
2023-03-31 18:55 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).