Re: [PATCH] arm64: dts: renesas: falcon-csi-dsi: Set bus-type for MAX96712

["Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>]

Hi Geert,

Thanks for your comments.

On 2023-03-31 17:08:50 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
> 
> Thanks for your patch!
> 
> On Fri, Mar 31, 2023 at 4:15 PM Niklas Söderlund
> <niklas.soderlund+renesas@ragnatech.se> wrote:
> > Specify the bus-type property for all three connected MAX96712.
> 
> Probably this can use a little bit more explanation?
> E.g. what does not work?

Everything works both with and without this patch. This is done in 
preparation to making the property mandatory. The default behavior when 
parsing a node without this property is to default to D-PHY. So this is 
just playing it safe and future prof tings as the default parsing comes 
from the V4L2 core and not the driver itself.

> 
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> 
> LGTM, so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Does this need a Fixes: tag?
> Fixes: 283252132cb578cf ("arm64: dts: renesas: falcon-csi-dsi: Add and
> connect MAX96712")
> 
> Note that a backport to v6.1 and earlier will depend on a backport of
> commit f7eeb00845934851 ("media: dt-bindings: media: Add macros for
> video interface bus types") in v6.2, too.

In a perfect word it would. But since the change is backward compatible 
I'm not sure it's worth the effort given the dependency on the macro 
definitions? If you think this is a good idea maybe a separate patch 
posted for stable that uses the numerical values directly?

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
Kind Regards,
Niklas Söderlund