From: Vinod Koul <vkoul@kernel.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Jack Zhu <jack.zhu@starfivetech.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 2/3] phy: starfive: Add mipi dphy rx support
Date: Mon, 3 Apr 2023 12:04:52 +0530 [thread overview]
Message-ID: <ZCpzjIrcKt4t93gn@matsya> (raw)
In-Reply-To: <b07842e4-54cc-873e-3140-4a933e054802@starfivetech.com>
On 03-04-23, 14:31, Changhuang Liang wrote:
>
>
> On 2023/4/3 14:24, Conor Dooley wrote:
> > On Mon, Apr 03, 2023 at 09:39:00AM +0800, Changhuang Liang wrote:
> >> On 2023/3/31 21:52, Vinod Koul wrote:
> >>> On 21-03-23, 14:08, Changhuang Liang wrote:
> >>>> On 2023/3/20 20:37, Vinod Koul wrote:
> >>>>> On 22-02-23, 17:59, Changhuang Liang wrote:
> >>>>>> +static int stf_dphy_configure(struct phy *phy, union phy_configure_opts *opts)
> >>>>>> +{
> >>>>>> + struct stf_dphy *dphy = phy_get_drvdata(phy);
> >>>>>> + int map[6] = {4, 0, 1, 2, 3, 5};
> >>>>>
> >>>>> what does this mean?
> >>>>
> >>>> This is the physical lane and logical lane mapping table, should I add a note for it?
> >>>
> >>> Yes please. Also will the mapping be always static or ever change?
> >>>
> >>
> >> The mapping is always static on the visionfive2 single board computer.
> >> Thanks for your comments.
> >
> > What about other boards featuring a JH7110?
>
> maybe add this mapping in the device tree, we just need to parse the device tree is better.
If the mapping is hw description then yes it makes sense
--
~Vinod
next prev parent reply other threads:[~2023-04-03 6:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 1:59 [PATCH v2 0/3] Add JH7110 MIPI DPHY RX support Changhuang Liang
2023-02-23 1:59 ` [PATCH v2 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx Changhuang Liang
2023-02-27 18:34 ` Rob Herring
2023-02-28 8:55 ` Changhuang Liang
2023-02-23 1:59 ` [PATCH v2 2/3] phy: starfive: Add mipi dphy rx support Changhuang Liang
2023-03-20 12:37 ` Vinod Koul
2023-03-21 6:08 ` Changhuang Liang
2023-03-31 13:52 ` Vinod Koul
2023-04-03 1:39 ` Changhuang Liang
2023-04-03 6:24 ` Conor Dooley
2023-04-03 6:31 ` Changhuang Liang
2023-04-03 6:34 ` Vinod Koul [this message]
2023-04-03 6:39 ` Changhuang Liang
2023-02-23 1:59 ` [PATCH v2 3/3] riscv: dts: starfive: Add dphy rx node Changhuang Liang
2023-03-03 6:05 ` [PATCH v2 0/3] Add JH7110 MIPI DPHY RX support Changhuang Liang
2023-03-20 12:39 ` Vinod Koul
2023-03-21 2:09 ` Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCpzjIrcKt4t93gn@matsya \
--to=vkoul@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=changhuang.liang@starfivetech.com \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jack.zhu@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox