RE: [PATCH v1 2/2] gpio: ds4520: Add ADI DS4520 Regulator Support

Sahin, Okan
2023-04-04T14:36:12Z

>Hi Okan,
>
>thanks for your patch!
>
>First: why is the word "Regulator" in the subject? I don't quite get it.
>
>On Mon, Mar 27, 2023 at 3:01 PM Okan Sahin <okan.sahin@analog.com> wrote:
>>
>> Gpio I/O expander.
>>
>> Signed-off-by: Okan Sahin <okan.sahin@analog.com>
>
>This commit log is too terse. Write a bit about what this hardware is.
>
>> +config GPIO_DS4520
>> + tristate "DS4520 I2C GPIO expander"
>> + select REGMAP_I2C
>> + help
>> + GPIO driver for Maxim MAX7300 I2C-based GPIO expander.
>
>Is it MAX7300, I don't get this, it seems super-confused.
>
>> + Say yes here to enable the GPIO driver for the ADI DS4520 chip.
>> +
>> + To compile this driver as a module, choose M here: the module will
>> + be called gpio-ds4520.
>
>(...)
>
>The driver is pretty straight-forward, but I think this can use the generic
>GPIO_REGMAP helpers in drivers/gpio/gpio-regmap.c check other drivers selecting
>this helper library for inspiration.
>
>Yours,
>Linus Walleij

Hi Linus,

Thank you for your contribution. Should I add select GPIO_REGMAP into Kconfig?
I am trying to understand completely before sending new patch.
I will fix your other comments.

Regards,
Okan Sahin