From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 872B8C77B71 for ; Sun, 9 Apr 2023 13:44:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbjDINoj (ORCPT ); Sun, 9 Apr 2023 09:44:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbjDINoi (ORCPT ); Sun, 9 Apr 2023 09:44:38 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC57D3A9B for ; Sun, 9 Apr 2023 06:44:36 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id ga37so7332971ejc.0 for ; Sun, 09 Apr 2023 06:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681047875; x=1683639875; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XkDkuaBPjpy+EJtSPevUxDWOfOvzo71cgS8AvzVvmes=; b=kGpQFbNrH/sZl9SHXTheP1vIDUq6XbItuidowGQMpGZlUuUhOXLwcsudyVGHF4ivaz ZevGcIeeF8jhx6gckp/kYIYg4cmNG1mrt4N3jdfzMNUlsXyWKv1fKRAuMulC7kQO7hSE 0/W15kGG/f0SihfSwTvmX3dNmxgp7UnyRRKi2DtdGaNVNCivv3a1nPp0BQj7CyvmC1Js UWwcYXuHGQUaT3D1Oj1gUB5rM4mwwgVZJBo1MWl1SSFAlhtMo8cA1qdoeBnQ+kij/f8q 3sTRg1DmJgT/urbI0/KynQt2IJ5e1iWmhcrBsEUpSi2f/jzw2X9YAKR5Hukak8c0psZk 6+hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681047875; x=1683639875; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XkDkuaBPjpy+EJtSPevUxDWOfOvzo71cgS8AvzVvmes=; b=5RHDGMWCLQBrKacKry6gq16m30eolyvuUjgNQIEqbamT0VcyTkVCU1zBia9uK13JLQ 34q72593cxJyZeoBHaZtvgzSX27yTPPUlCkATwBk4mmeH+eTh7se2Oa64K1nz8Rk6RQ+ Wh6uewqEAnxTLmRg8USj+qymReIj8GYyol3/6a1K/s7dSmXj8M+A5NvNW2UKHkTGcX60 C8avFoOWhbaTgqsQGr79U8iI92eJo5b6fepbWWyh+OgV7xlBW4aF2NgtR9MMFuXYMCDB Ytl5jyS7aAQb0G49kyjo+UJ5nptJPtyRWyJpkbOZKN7YmuxzEXU785V6zZ5FuJ0gpxSg ajZw== X-Gm-Message-State: AAQBX9eKuBgUWfitGSyZE1emXhmVKd/Ucr+GU1b52wgWLPtlYkOV3Wv1 cajwEELhkq9DvY8bi6uvGAE5ew== X-Google-Smtp-Source: AKy350bNFZIuIh+vV8kCLJfSB+asCNAdxTw09g9zMvMd/eWOiygIOtcmHZksluJaGdImKJABTV5gGQ== X-Received: by 2002:a17:906:2706:b0:947:71bf:ca19 with SMTP id z6-20020a170906270600b0094771bfca19mr3853980ejc.65.1681047875261; Sun, 09 Apr 2023 06:44:35 -0700 (PDT) Received: from linaro.org ([188.25.26.161]) by smtp.gmail.com with ESMTPSA id a12-20020a17090680cc00b00922a79e79c2sm4142096ejx.217.2023.04.09.06.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Apr 2023 06:44:34 -0700 (PDT) Date: Sun, 9 Apr 2023 16:44:33 +0300 From: Abel Vesa To: "Peng Fan (OSS)" Cc: abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Peng Fan , Jacky Bai Subject: Re: [PATCH V3 1/7] clk: imx: fracn-gppll: fix the rate table Message-ID: References: <20230403095300.3386988-1-peng.fan@oss.nxp.com> <20230403095300.3386988-2-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230403095300.3386988-2-peng.fan@oss.nxp.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23-04-03 17:52:54, Peng Fan (OSS) wrote: > From: Peng Fan > > The Fvco should be range 2.4GHz to 5GHz, the original table voilate the > spec, so update the table to fix it. > > Fixes: c196175acdd3 ("clk: imx: clk-fracn-gppll: Add more freq config for video pll") > Fixes: 044034efbeea ("clk: imx: clk-fracn-gppll: fix mfd value") > Fixes: 1b26cb8a77a4 ("clk: imx: support fracn gppll") > Signed-off-by: Jacky Bai > Signed-off-by: Peng Fan Reviewed-by: Abel Vesa > --- > drivers/clk/imx/clk-fracn-gppll.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/clk/imx/clk-fracn-gppll.c b/drivers/clk/imx/clk-fracn-gppll.c > index a2aaa14fc1ae..ec50c41e2a4c 100644 > --- a/drivers/clk/imx/clk-fracn-gppll.c > +++ b/drivers/clk/imx/clk-fracn-gppll.c > @@ -60,18 +60,20 @@ struct clk_fracn_gppll { > }; > > /* > - * Fvco = Fref * (MFI + MFN / MFD) > - * Fout = Fvco / (rdiv * odiv) > + * Fvco = (Fref / rdiv) * (MFI + MFN / MFD) > + * Fout = Fvco / odiv > + * The (Fref / rdiv) should be in range 20MHz to 40MHz > + * The Fvco should be in range 2.5Ghz to 5Ghz > */ > static const struct imx_fracn_gppll_rate_table fracn_tbl[] = { > - PLL_FRACN_GP(650000000U, 81, 0, 1, 0, 3), > + PLL_FRACN_GP(650000000U, 162, 50, 100, 0, 6), > PLL_FRACN_GP(594000000U, 198, 0, 1, 0, 8), > - PLL_FRACN_GP(560000000U, 70, 0, 1, 0, 3), > - PLL_FRACN_GP(498000000U, 83, 0, 1, 0, 4), > + PLL_FRACN_GP(560000000U, 140, 0, 1, 0, 6), > + PLL_FRACN_GP(498000000U, 166, 0, 1, 0, 8), > PLL_FRACN_GP(484000000U, 121, 0, 1, 0, 6), > PLL_FRACN_GP(445333333U, 167, 0, 1, 0, 9), > - PLL_FRACN_GP(400000000U, 50, 0, 1, 0, 3), > - PLL_FRACN_GP(393216000U, 81, 92, 100, 0, 5) > + PLL_FRACN_GP(400000000U, 200, 0, 1, 0, 12), > + PLL_FRACN_GP(393216000U, 163, 84, 100, 0, 10) > }; > > struct imx_fracn_gppll_clk imx_fracn_gppll = { > -- > 2.37.1 >