From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org,
bhelgaas@google.com, konrad.dybcio@linaro.org,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "dt-bindings: PCI: qcom: Add iommu-map properties"
Date: Wed, 12 Apr 2023 15:27:24 +0200 [thread overview]
Message-ID: <ZDaxvBK9IqAhZwIM@lpieralisi> (raw)
In-Reply-To: <20230412112918.GB9463@thinkpad>
On Wed, Apr 12, 2023 at 04:59:18PM +0530, Manivannan Sadhasivam wrote:
[...]
> > > This is fine. The plan is to remove the "iommus" property from Qcom PCI binding
> > > since we have removed the usage of that property from devicetree [1]. Initially
> > > the iommu properties were not documented at all in the binding. But commit,
> > > "dt-bindings: PCI: qcom: Add SM8550 compatible" added them to the binding to
> > > satisfy dtbs check. But in parallel, the patch removing "iommus" property from
> > > dts got merged to qcom tree.
> > >
> > > So now we have 2 options here:
> > >
> > > 1. Amend the commit "dt-bindings: PCI: qcom: Add SM8550 compatible" to remove
> > > the "iommus" property.
> > >
> > > 2. I will submit a separate patch removing that property.
> > >
> > > Lorenzo, let me know what works for you. Sorry for the mess! Confusion happened
> > > due to patches getting applied without sync.
> >
> > You can inline a diff here for (1), I will amend the commit.
> >
>
> Here you go:
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> index a1318a4ecadf..1548a7114732 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> @@ -60,9 +60,6 @@ properties:
> minItems: 1
> maxItems: 8
>
> - iommus:
> - maxItems: 1
> -
> iommu-map:
> maxItems: 2
Done, please check, thanks.
Lorenzo
next prev parent reply other threads:[~2023-04-12 13:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 12:15 [PATCH] Revert "dt-bindings: PCI: qcom: Add iommu-map properties" Manivannan Sadhasivam
2023-04-11 16:36 ` Lorenzo Pieralisi
2023-04-11 17:47 ` Rob Herring
2023-04-11 18:42 ` Manivannan Sadhasivam
2023-04-12 8:15 ` Lorenzo Pieralisi
2023-04-12 10:11 ` Manivannan Sadhasivam
2023-04-12 10:46 ` Lorenzo Pieralisi
2023-04-12 11:29 ` Manivannan Sadhasivam
2023-04-12 13:27 ` Lorenzo Pieralisi [this message]
2023-04-12 14:23 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDaxvBK9IqAhZwIM@lpieralisi \
--to=lpieralisi@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).