From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32FCFC77B6C for ; Thu, 13 Apr 2023 02:17:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229501AbjDMCRp (ORCPT ); Wed, 12 Apr 2023 22:17:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjDMCRp (ORCPT ); Wed, 12 Apr 2023 22:17:45 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48EC85FC6; Wed, 12 Apr 2023 19:17:44 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id nh20-20020a17090b365400b0024496d637e1so19022871pjb.5; Wed, 12 Apr 2023 19:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681352264; x=1683944264; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XzcH2FGOl08HFZvLq7fg5qxkoIepaHQ4FukgMx688Jk=; b=gOWuvAiw/ZvvfqD+R8MDOwyGYWTn3B5qj39QZ8QoHVss5kzm89guBxBCR0uqR4ogKJ XQ8zZ+gW4/8bPp407bVQIw7aiWyi/N1bcvg6ooZmrQyCzIINsQqE6hopNKujckzVxWHU NhpZjIjKhjFg5MwRBHFjhOGqEMeGvBNhHVHwdg0pWn8O+YAuZRnTWkLhzfD0Lgv0w1FN tEcnEEht3cEB7aRrrDUdfyWf30L67WBNsQPzm+oZKREc252vG0DmFXJWp3eBVVa9GhvW E0seWLo+LphZR8vL1gG6VgcsPYpkkg/RInVQJWlxiAl41xPRkUh+acdTBHvR1If6rU5A ZDfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681352264; x=1683944264; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XzcH2FGOl08HFZvLq7fg5qxkoIepaHQ4FukgMx688Jk=; b=SPI8+uFmUiCwBQC4pVFPc3NKzeDolf19BmJVzYKxB6jsENuSajsfpsrPVGIl0aEE7p kxyH3AKOSYPm6JpDSnlLmtB0H3PPoZFzcQlQnR0W1z3d0w/xmgY/Taee4jYOx3A24RMe 1jK8zSSQL+Bf5sRFmLq3q0xff9awmwkAKuIlrxvSCYgiXffbhImXY/6GL9+BsdGfB8Lq OZsSL0211bpJPjnVhpK6zTWyayDq+FdWIe4IsGRqJP7PWI0eGBOAgkZ0arwnkGzNuTMZ w+MmWop9IT4VU9ljAJN/z6z8E/fHaWriBW2RQHE66PwTJHnlyD4njLoVJFIQ0NYn9pHd cSDw== X-Gm-Message-State: AAQBX9f0lwoE9ZOjQtiuGY1/ZWtbm76GrAkMhohs8botqbiDZ0ApcTio wuZ4xToKXy+r01c0T+TVuwo= X-Google-Smtp-Source: AKy350ZHPpvDc7QsJM94lFPJrADqw+6R9qxFkznRZmfyqpJieEhL/+HXBqbmS8QzvaLxKVY54G2fqA== X-Received: by 2002:a17:903:28f:b0:1a6:370c:ce79 with SMTP id j15-20020a170903028f00b001a6370cce79mr462529plr.22.1681352263687; Wed, 12 Apr 2023 19:17:43 -0700 (PDT) Received: from Gentoo (n220246252240.netvigator.com. [220.246.252.240]) by smtp.gmail.com with ESMTPSA id u5-20020a17090282c500b001a4edbabad3sm234301plz.230.2023.04.12.19.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 19:17:43 -0700 (PDT) Date: Thu, 13 Apr 2023 10:17:37 +0800 From: Jianhua Lu To: Konrad Dybcio Cc: Neil Armstrong , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Marijn Suijten , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] drm/panel: nt36523: Add Lenovo J606F panel Message-ID: References: <20230412-topic-lenovopanel-v1-0-00b25df46824@linaro.org> <20230412-topic-lenovopanel-v1-5-00b25df46824@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230412-topic-lenovopanel-v1-5-00b25df46824@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Apr 12, 2023 at 09:46:02PM +0200, Konrad Dybcio wrote: > Some Lenovo J606F tablets come with a 2K (2000x1200) 60Hz 11" 5:3 > video mode display. Add support for these panels. > > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/panel/panel-novatek-nt36523.c | 491 ++++++++++++++++++++++++++ > 1 file changed, 491 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c b/drivers/gpu/drm/panel/panel-novatek-nt36523.c > index db4b4af13ec1..4bf9f8db26ba 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt36523.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt36523.c > @@ -13,6 +13,8 @@ > #include > #include > [..] > +static const struct panel_desc j606f_boe_desc = { > + .modes = j606f_boe_modes, > + .num_modes = ARRAY_SIZE(j606f_boe_modes), > + .dsi_info = { > + .type = "J606F BOE", > + .channel = 0, > + .node = NULL, > + }, The dsi_info just be used to register slave dsi, for single dsi case, can drop it. Otherwise looks great, thanks! Reviewed-by: Jianhua Lu > + .width_mm = 143, > + .height_mm = 235, > + .bpc = 8, > + .lanes = 4, > + .format = MIPI_DSI_FMT_RGB888, > + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | > + MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM, > + .init_sequence = j606f_boe_init_sequence, > + .has_dcs_backlight = true, > +}; > + > static void nt36523_reset(struct panel_info *pinfo) > { > gpiod_set_value_cansleep(pinfo->reset_gpio, 1); > @@ -826,6 +1313,10 @@ static int nt36523_probe(struct mipi_dsi_device *dsi) > } > > static const struct of_device_id nt36523_of_match[] = { > + { > + .compatible = "lenovo,j606f-boe-nt36523w", > + .data = &j606f_boe_desc, > + }, > { > .compatible = "xiaomi,elish-boe-nt36523", > .data = &elish_boe_desc, > > -- > 2.40.0 >